RFR: 7507: Fixing project setup [v2]

Marcus Hirt hirt at openjdk.java.net
Fri Jan 14 13:35:11 UTC 2022


On Thu, 13 Jan 2022 21:49:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> application/uitests/pom.xml line 93:
> 
>> 91: 		<dependency>
>> 92: 			<groupId>org.openjdk.jmc</groupId>
>> 93: 			<artifactId>flightrecorder.serializers</artifactId>
> 
> Is there anything in the uitests that use serializers and writer?

Writer, probably not right now, but doesn't hurt. I think the serializers are used by the Websocket stuff, so added them for good measure. Was trying to figure out why it's not possible to sometimes run the UI-tests after having run the RCP app from within Eclipse. I think the conclusion was that this doesn't matter, but having all of core available shouldn't hurt.

-------------

PR: https://git.openjdk.java.net/jmc/pull/355


More information about the jmc-dev mailing list