RFR: 7056: Fix dark mode
Brice Dutheil
duke at openjdk.java.net
Mon Jan 17 11:55:55 UTC 2022
On Sun, 16 Jan 2022 15:32:33 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:
> This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes.
>
> Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin.
> In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file.
>
>
>
> **After**
> 
> 
>
>
>
> **Before**
> 
> There's no theme, as such the combo box doesn't open either.
Note this PR doesn't fix the graph issues mentioned in [JMC-7056](https://bugs.openjdk.java.net/browse/JMC-7056).
For JMC-7056, I'm not quite sure how to fix that yet, but using the following APIs might prove useful:
* `PlatformUI.getWorkbench().getThemeManager().getCurrentTheme()` gets an `ITheme`
* `theme.getColorRegistry().get(String)` gets the `Color` or a symbolic name
It makes sense, let's fix those.
-------------
PR: https://git.openjdk.java.net/jmc/pull/362
More information about the jmc-dev
mailing list