RFR: 7537: build script assumes that Darwin always targets x86_64

Johannes Bechberger duke at openjdk.java.net
Thu Jan 20 17:35:53 UTC 2022


On Thu, 20 Jan 2022 17:28:42 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> Tested on Mac M1.
>
> build.sh line 10:
> 
>> 8: if [[ "`uname -m`" =~ "arm64" ]]; then 
>> 9:   ARCH="aarch64"
>> 10: fi
> 
> I think we could use result from `uname -m` in any case:
> 
>   ARCH=`uname -m`

No, this would break our current build, as `uname -m` outputs `arm64` instead of `aarch64` which is expected by the rest of the build system. Changing it would require to change the build system.

-------------

PR: https://git.openjdk.java.net/jmc/pull/366


More information about the jmc-dev mailing list