RFR: 7417: Fix incorrect identifier in result for biased locking revocation rule

Marcus Hirt hirt at openjdk.java.net
Fri Jan 21 12:14:55 UTC 2022


On Mon, 20 Sep 2021 06:40:14 GMT, mohno007 <duke at openjdk.java.net> wrote:

> This PR fixes a wrong placeholder in `BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG`.
> 
> `BiasedLockingRevocationRule.java` used `{revokedClasses}` for placeholder identifier but `messages.properties` used `{revokedTypes}`.

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/BiasedLockingRevocationRule.java line 116:

> 114: 			MAX_NUMBER_OF_CLASSES_TO_REPORT, FILTERED_CLASSES);
> 115: 
> 116: 	public static final TypedCollectionResult<IMCType> REVOKED_CLASSES = new TypedCollectionResult<>("revokedClasses", //$NON-NLS-1$

Need to update copyright year.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 77:

> 75: BiasedLockingRevocationRule_TEXT_OK=No classes were disabled from participating in biased locking
> 76: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND=Fully revoked classes found.
> 77: BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG=The following classes were disabled from using biased locking: {revokedClasses}

Need to update copyright year.

-------------

PR: https://git.openjdk.java.net/jmc/pull/309


More information about the jmc-dev mailing list