RFR: 7512: Update lz4-java and remove the osgi bundle name override [v2]

Marcus Hirt hirt at openjdk.java.net
Tue Jan 25 21:42:40 UTC 2022


On Tue, 25 Jan 2022 14:17:57 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Bump lz4-java, removes the osgi bundle name override

Changes requested by hirt (Lead).

application/org.openjdk.jmc.feature.core/feature.xml line 4:

> 2: <!--   
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

We don't add copyright lines to already existing files. Only when creating new files.

application/org.openjdk.jmc.feature.flightrecorder/feature.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

Same here. Only add a Datadog (in this case) specific copyright line if it is a new file.

releng/platform-definitions/pom.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

Here as well. Don't add copyright line.

releng/third-party/pom.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2022, Datadog, Inc. All rights reserved.

And here as well.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356


More information about the jmc-dev mailing list