RFR: 7512: Update lz4-java and remove the osgi bundle name override [v3]

Marcus Hirt hirt at openjdk.java.net
Wed Jan 26 05:27:36 UTC 2022


On Tue, 25 Jan 2022 23:59:08 GMT, Brice Dutheil <duke at openjdk.java.net> wrote:

>> The core library dependency decalred in maven is aligned with the one in the .target files, `1.8.0`.
>> 
>> Also I noticed the lz4-java library has an OSGI bundle symbolic name: `lz4-java`, introduced in 1.3.0 : https://github.com/lz4/lz4-java/pull/39/files#diff-e3399fe1dc27b086e517883c6cab943edbfab64139839c965b14db8d11c8a99aR1-R4
>> However probably due to some previous bugs this required an override, done [here](https://github.com/openjdk/jmc/commit/b6e5bde2f45e7e44f252f42488332fc81b58506b#diff-ae8e739504eac3280387ceb987f669e68fbb07806266732c4ab21409d593b1dcR81-R86), but this may not be necessary anymore. Hence this PR tries to use the actual osgi name.
>> 
>> The change is little, and hopefully won't ripple beyond.
>
> Brice Dutheil has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Bump lz4-java, removes the osgi bundle name override

There is no need to force push changes. The tooling will take care of the squashing and merging automatically. It's actually easier to do the review if changes aren't force pushed.

-------------

PR: https://git.openjdk.java.net/jmc/pull/356


More information about the jmc-dev mailing list