From clanger at openjdk.org Tue Jul 5 06:08:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 5 Jul 2022 06:08:07 GMT Subject: RFR: 7834: Improve GitHub Actions validation workflow Message-ID: Improve validation workflow. - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs) - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice - Updates to a branch should cancel running actions in favor of a new run to save resources - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested - Used actions can be version-bumped - Naming of some steps can be improved - The test steps and their order can be improved to make the steps more logical and explicit: 1. Build&Test core 2. Start P2 repository 3. Build&Test application 4. Build&Test agent 5. Run spotless - Use maven option --no-transfer-progress to get less noisy logs Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts. One could think of deleting them but maybe they are used elsewhere, so keep them (up to date). ------------- Commit messages: - Improve validation workflow Changes: https://git.openjdk.org/jmc/pull/407/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=407&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7834 Stats: 181 lines in 11 files changed: 53 ins; 93 del; 35 mod Patch: https://git.openjdk.org/jmc/pull/407.diff Fetch: git fetch https://git.openjdk.org/jmc pull/407/head:pull/407 PR: https://git.openjdk.org/jmc/pull/407 From hirt at openjdk.org Wed Jul 6 18:37:55 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 6 Jul 2022 18:37:55 GMT Subject: RFR: 7834: Improve GitHub Actions validation workflow In-Reply-To: References: Message-ID: <53fvDePAzbBeQYX9f4aEh9rD6ZeAya-H_9g-9rBEogE=.96649097-ceb1-4e52-b85a-29f122bc87cd@github.com> On Tue, 5 Jul 2022 06:01:21 GMT, Christoph Langer wrote: > Improve validation workflow. > > - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs) > - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice > - Updates to a branch should cancel running actions in favor of a new run to save resources > - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested > - Used actions can be version-bumped > - Naming of some steps can be improved > - The test steps and their order can be improved to make the steps more logical and explicit: > 1. Build&Test core > 2. Start P2 repository > 3. Build&Test application > 4. Build&Test agent > 5. Run spotless > - Use maven option --no-transfer-progress to get less noisy logs > > Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts. > One could think of deleting them but maybe they are used elsewhere, so keep them (up to date). Looks great! ------------- Marked as reviewed by hirt (Lead). PR: https://git.openjdk.org/jmc/pull/407 From clanger at openjdk.org Thu Jul 7 08:00:57 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 7 Jul 2022 08:00:57 GMT Subject: Integrated: 7834: Improve GitHub Actions validation workflow In-Reply-To: References: Message-ID: On Tue, 5 Jul 2022 06:01:21 GMT, Christoph Langer wrote: > Improve validation workflow. > > - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs) > - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice > - Updates to a branch should cancel running actions in favor of a new run to save resources > - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested > - Used actions can be version-bumped > - Naming of some steps can be improved > - The test steps and their order can be improved to make the steps more logical and explicit: > 1. Build&Test core > 2. Start P2 repository > 3. Build&Test application > 4. Build&Test agent > 5. Run spotless > - Use maven option --no-transfer-progress to get less noisy logs > > Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts. > One could think of deleting them but maybe they are used elsewhere, so keep them (up to date). This pull request has now been integrated. Changeset: 0889d60d Author: Christoph Langer URL: https://git.openjdk.org/jmc/commit/0889d60dea0cd6c2f6bc29ca8fb84ccf4758d1df Stats: 181 lines in 11 files changed: 53 ins; 93 del; 35 mod 7834: Improve GitHub Actions validation workflow Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/407 From clanger at openjdk.org Thu Jul 7 07:57:55 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 7 Jul 2022 07:57:55 GMT Subject: RFR: 7834: Improve GitHub Actions validation workflow In-Reply-To: References: Message-ID: On Wed, 6 Jul 2022 17:45:52 GMT, Marcus Hirt wrote: >> Improve validation workflow. >> >> - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs) >> - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice >> - Updates to a branch should cancel running actions in favor of a new run to save resources >> - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested >> - Used actions can be version-bumped >> - Naming of some steps can be improved >> - The test steps and their order can be improved to make the steps more logical and explicit: >> 1. Build&Test core >> 2. Start P2 repository >> 3. Build&Test application >> 4. Build&Test agent >> 5. Run spotless >> - Use maven option --no-transfer-progress to get less noisy logs >> >> Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts. >> One could think of deleting them but maybe they are used elsewhere, so keep them (up to date). > > Nice! Thanks, @thegreystone ------------- PR: https://git.openjdk.org/jmc/pull/407 From hirt at openjdk.org Wed Jul 6 17:48:57 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 6 Jul 2022 17:48:57 GMT Subject: RFR: 7834: Improve GitHub Actions validation workflow In-Reply-To: References: Message-ID: On Tue, 5 Jul 2022 06:01:21 GMT, Christoph Langer wrote: > Improve validation workflow. > > - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs) > - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice > - Updates to a branch should cancel running actions in favor of a new run to save resources > - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested > - Used actions can be version-bumped > - Naming of some steps can be improved > - The test steps and their order can be improved to make the steps more logical and explicit: > 1. Build&Test core > 2. Start P2 repository > 3. Build&Test application > 4. Build&Test agent > 5. Run spotless > - Use maven option --no-transfer-progress to get less noisy logs > > Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts. > One could think of deleting them but maybe they are used elsewhere, so keep them (up to date). Nice! ------------- PR: https://git.openjdk.org/jmc/pull/407 From duke at openjdk.org Sat Jul 9 14:01:22 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sat, 9 Jul 2022 14:01:22 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v15] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits: - JMC-7455: Rebase and upgrade to 8.3.0 - JMC-7455: Upgrade to Jolokia 1.7.1 and manage jolokia JVM dependency - JMC-7455: Cleanup: remove redundant code - JMC-7455: Remaining OSGi cleanup - JMC-7455: Re-export jolokia JMX adapter for simplicity - JMC-7455: Use third party to pull inn Jolokia modules - Review corrections: Javadoc and refactoring attempt to use local operation info - Removed -XstartOnFirstThread as it is not valid for some JVMs - Used spotbugs to format more code - Used spotbugs to format according to convention - ... and 7 more: https://git.openjdk.org/jmc/compare/0889d60d...19dfea25 ------------- Changes: https://git.openjdk.org/jmc/pull/332/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=14 Stats: 3168 lines in 54 files changed: 3168 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From schaturvedi at openjdk.org Wed Jul 13 11:49:20 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 13 Jul 2022 11:49:20 GMT Subject: RFR: 7820: Add validations for master password [v2] In-Reply-To: References: Message-ID: > This PR adds password validations for master password field. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Added Junit test cases and moved the logic to common util file ------------- Changes: - all: https://git.openjdk.org/jmc/pull/406/files - new: https://git.openjdk.org/jmc/pull/406/files/6e709d4f..10d0e54a Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=00-01 Stats: 81 lines in 3 files changed: 71 ins; 8 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/406.diff Fetch: git fetch https://git.openjdk.org/jmc pull/406/head:pull/406 PR: https://git.openjdk.org/jmc/pull/406 From schaturvedi at openjdk.org Wed Jul 13 15:35:44 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 13 Jul 2022 15:35:44 GMT Subject: RFR: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions Message-ID: This PR resolves the issue of thread attribute discrepancy between different JDK versions. The issue had two parts - first one was already resolved as part of another bug, second part will be fixed as part of this PR. 1. switchRate attribute in JDK 11 onwards have the content type as frequency but pre JDK 11 the content type was number. 2. Pre JDK 9 the attribute name was javalangthread whereas post JDK 9 its thread. ------------- Commit messages: - 7243: Resolve discrepancy between JDK attributes coming from different JDK versions Changes: https://git.openjdk.org/jmc/pull/411/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=411&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7243 Stats: 15 lines in 1 file changed: 13 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/411.diff Fetch: git fetch https://git.openjdk.org/jmc pull/411/head:pull/411 PR: https://git.openjdk.org/jmc/pull/411 From rschmelter at openjdk.org Thu Jul 14 11:36:10 2022 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Thu, 14 Jul 2022 11:36:10 GMT Subject: RFR: 7842: policy file is missing entry for test on Windows [v2] In-Reply-To: References: Message-ID: <2ljUtWrFEdueCKdNp6fUKx_975IGnwWsrpHf9ozVjcE=.877d7d2b-2202-4652-8fc0-7926dc0fb0ac@github.com> > This change adds an entry to the test policy file to allow acces to the temporary directory. This is needed since the surefire plugin places it files there on Windows, in contrast to other platforms where they are placed in the target/surefire directory. Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: Prepare permissions for new failsafe version und handle 8.3 names for the temp dir ------------- Changes: - all: https://git.openjdk.org/jmc/pull/410/files - new: https://git.openjdk.org/jmc/pull/410/files/0285f423..408d812f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=410&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=410&range=00-01 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/410.diff Fetch: git fetch https://git.openjdk.org/jmc pull/410/head:pull/410 PR: https://git.openjdk.org/jmc/pull/410 From clanger at openjdk.org Thu Jul 14 12:28:14 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 14 Jul 2022 12:28:14 GMT Subject: RFR: 7842: policy file is missing entry for test on Windows [v2] In-Reply-To: <2ljUtWrFEdueCKdNp6fUKx_975IGnwWsrpHf9ozVjcE=.877d7d2b-2202-4652-8fc0-7926dc0fb0ac@github.com> References: <2ljUtWrFEdueCKdNp6fUKx_975IGnwWsrpHf9ozVjcE=.877d7d2b-2202-4652-8fc0-7926dc0fb0ac@github.com> Message-ID: <1JnETpYuXqlsZ5wGxXWPK_nDTxzVi1WL9aBL29AX2Cs=.92ce8081-248d-4021-ad54-fbe055c8c7e1@github.com> On Thu, 14 Jul 2022 11:36:10 GMT, Ralf Schmelter wrote: >> This change adds an entry to the test policy file to allow acces to the temporary directory. This is needed since the surefire plugin places it files there on Windows, in contrast to other platforms where they are placed in the target/surefire directory. > > Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: > > Prepare permissions for new failsafe version und handle 8.3 names for the temp dir Looks good. Thanks for digging into this. Now the tests can run on Windows as well. ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/410 From rschmelter at openjdk.org Thu Jul 14 12:45:16 2022 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Thu, 14 Jul 2022 12:45:16 GMT Subject: Integrated: 7842: JMC agent: policy file is missing entry for test on Windows In-Reply-To: References: Message-ID: <4kX8U8gjjXV53dYAs6POPhCEp0-bVqICtFeY4JYwd5U=.3d627c8f-7f94-4b89-abeb-0e204cda5eff@github.com> On Tue, 12 Jul 2022 14:44:35 GMT, Ralf Schmelter wrote: > This change adds an entry to the test policy file to allow acces to the temporary directory. This is needed since the surefire plugin places it files there on Windows, in contrast to other platforms where they are placed in the target/surefire directory. This pull request has now been integrated. Changeset: 056139f0 Author: Ralf Schmelter Committer: Christoph Langer URL: https://git.openjdk.org/jmc/commit/056139f05ae8406c7203a68543c9e9041240427f Stats: 11 lines in 4 files changed: 2 ins; 6 del; 3 mod 7842: JMC agent: policy file is missing entry for test on Windows Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jmc/pull/410 From jbachorik at openjdk.org Fri Jul 15 11:16:40 2022 From: jbachorik at openjdk.org (Jaroslav Bachorik) Date: Fri, 15 Jul 2022 11:16:40 GMT Subject: RFR: JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks Message-ID: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical. This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`. ------------- Commit messages: - JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks Changes: https://git.openjdk.org/jmc/pull/412/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=412&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7855 Stats: 1119 lines in 15 files changed: 1108 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jmc/pull/412.diff Fetch: git fetch https://git.openjdk.org/jmc pull/412/head:pull/412 PR: https://git.openjdk.org/jmc/pull/412 From clanger at openjdk.org Fri Jul 15 13:17:18 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 15 Jul 2022 13:17:18 GMT Subject: RFR: JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks In-Reply-To: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> References: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> Message-ID: On Thu, 14 Jul 2022 18:44:14 GMT, Jaroslav Bachorik wrote: > Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical. > > This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`. Hi, I made a few initial comments, will try to review it in the next days. One other hint: Maybe you could update your branch with current master? core/tests/org.openjdk.jmc.flightrecorder.writer.test/src/main/java/org/openjdk/jmc/flightrecorder/testutils/parser/MetadataEvent.java line 1: > 1: package org.openjdk.jmc.flightrecorder.testutils.parser; The package declaration should go after the copyright header. core/tests/org.openjdk.jmc.flightrecorder.writer.test/src/main/java/org/openjdk/jmc/flightrecorder/testutils/parser/package-info.java line 1: > 1: /** Copyright header is missing. core/tests/org.openjdk.jmc.flightrecorder.writer.test/src/main/java/org/openjdk/jmc/flightrecorder/testutils/parser/test/StreamingChunkParserTest.java line 1: > 1: package org.openjdk.jmc.flightrecorder.testutils.parser.test; Copyright header is missing. ------------- PR: https://git.openjdk.org/jmc/pull/412 From jbachorik at openjdk.org Fri Jul 15 13:28:05 2022 From: jbachorik at openjdk.org (Jaroslav Bachorik) Date: Fri, 15 Jul 2022 13:28:05 GMT Subject: RFR: JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v2] In-Reply-To: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> References: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> Message-ID: > Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical. > > This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`. Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Update copyrights - Merge branch 'master' into jb/JMC-7855 - JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks ------------- Changes: - all: https://git.openjdk.org/jmc/pull/412/files - new: https://git.openjdk.org/jmc/pull/412/files/faf5a14f..d0e5225d Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=412&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=412&range=00-01 Stats: 517 lines in 27 files changed: 323 ins; 105 del; 89 mod Patch: https://git.openjdk.org/jmc/pull/412.diff Fetch: git fetch https://git.openjdk.org/jmc pull/412/head:pull/412 PR: https://git.openjdk.org/jmc/pull/412 From clanger at openjdk.org Fri Jul 15 21:29:40 2022 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 15 Jul 2022 21:29:40 GMT Subject: RFR: 7856: Fix errors in Eclipse projects after JMC-7769 Message-ID: [JMC-7769](https://bugs.openjdk.org/browse/JMC-7769) cleaned up the project layout for missioncontrol core, especially the test projects. However, after that patch, an Eclipse IDE setup shows errors in test projects of the application, e.g. in org.openjdk.jmc.rjmx.test. This is caused by an issue in project setup of core/tests/org.openjdk.jmc.common.test, which is a prerequisite to some other test projects. Class files are generated into the target/test-classes folder but Eclipse only exposes target/classes to dependent projects. The fix is to set up org.openjdk.jmc.common.test like a general library project, only using src/main/java -> target/classes. Because it is a module of missioncontrol.core.tests, the property `fail.if.no.tests=false` needs to be set, otherwise the build fails because tests would be expected. ------------- Commit messages: - JMC-7856 Changes: https://git.openjdk.org/jmc/pull/413/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=413&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7856 Stats: 15 lines in 3 files changed: 8 ins; 5 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/413.diff Fetch: git fetch https://git.openjdk.org/jmc pull/413/head:pull/413 PR: https://git.openjdk.org/jmc/pull/413 From duke at openjdk.org Sun Jul 17 06:12:08 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 17 Jul 2022 06:12:08 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v16] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-7455: Removed unused logger field to fix spotbugs error ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/19dfea25..96abdf1f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=15 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=14-15 Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 17 13:36:07 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 17 Jul 2022 13:36:07 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v17] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-7455: Use proper dependency machanism for awaitility ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/96abdf1f..1dba9790 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=16 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=15-16 Stats: 19 lines in 3 files changed: 2 ins; 15 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From clanger at openjdk.org Mon Jul 18 22:00:20 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 18 Jul 2022 22:00:20 GMT Subject: RFR: JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v2] In-Reply-To: References: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> Message-ID: On Fri, 15 Jul 2022 13:28:05 GMT, Jaroslav Bachorik wrote: >> Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical. >> >> This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`. > > Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Update copyrights > - Merge branch 'master' into jb/JMC-7855 > - JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks Hi Jaroslav, I went through your change. Generally the approach to more correctly calculate start ticks and add a duration field looks ok. Please find some comments inline. When I discovered that in RecordingImpl:finalizeRecording the calculated duration wasn't passed to writeMetadataEvent, I tried to enhance RecordingImplTest to assert on metadata.duration > -1L. This doesn't work though, because the LEB128Writer would write a -1 as 10 slots of 7 bit but the readVarint() method of RecordingStream only reads 9 slots and will hence just read Long.MAX_VALUE. But when I change readVarint() to read 10 slots, I get other test failures. Your comment also suggests that the JMC parser assumes it is a Java unsigned long. Since I'm not so much into the intrinsics of JFR, I'm not sure what would be correct here. I also did not review all details of testutils/parser. Another, more general question which might sound dumb: Where is the flightrecorder.writer component used in JMC itself? Or is it just some auxiliary library used elsewhere? ? Best regards Christoph core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java line 101: > 99: private final MetadataImpl metadata = new MetadataImpl(constantPools); > 100: private final TypesImpl types; > 101: private final long duration; Maybe move this line to L90? core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java line 291: > 289: writeCheckpointEvent(); > 290: long metadataOffset = globalWriter.position(); > 291: writeMetadataEvent(duration); shouldn't it then be recDuration here, too? core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingSettingsBuilderImpl.java line 42: > 40: private long timestamp = -1; > 41: private long startTicks = -1; > 42: remove empty line? core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingSettingsBuilderImpl.java line 60: > 58: @Override > 59: public RecordingSettingsBuilder withDuration(long ticks) { > 60: this.duration = duration; must be ... `withDuration(long duration)` ... core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/RecordingSettings.java line 42: > 40: private final long startTimestamp; > 41: private final long startTicks; > 42: remove empty line? core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/RecordingSettingsBuilder.java line 57: > 55: * @since 8.3.0 > 56: */ > 57: default RecordingSettingsBuilder withStartTicks(long ticks) { Do we really need a default method here? That is, could it be that we load an older implementation class of this interface that doesn't have this method implemented? core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/RecordingSettingsBuilder.java line 69: > 67: * @since 8.3.0 > 68: */ > 69: default RecordingSettingsBuilder withDuration(long ticks) { Same here about default... core/tests/org.openjdk.jmc.flightrecorder.writer.test/pom.xml line 93: > 91: org.jctools > 92: jctools-core > 93: 3.3.0 Can you define the newly introduced dependency versions in [core/tests/pom.xml](https://github.com/openjdk/jmc/blob/master/core/tests/pom.xml) and only inherit here, like you've done it for mockito-junit-jupiter? core/tests/org.openjdk.jmc.flightrecorder.writer.test/pom.xml line 103: > 101: org.slf4j > 102: slf4j-simple > 103: 1.7.32 Any reason for not using 1.7.36 here as well? ------------- Changes requested by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/412 From clanger at openjdk.org Mon Jul 18 22:06:11 2022 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 18 Jul 2022 22:06:11 GMT Subject: RFR: JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v2] In-Reply-To: References: <-0SXAK6-q6u7WKMe7H7u9hpjV7qsrnCyxhlVGOVdKPM=.7af628b0-7f3d-43a9-8a67-af7eeeeb01db@github.com> Message-ID: On Fri, 15 Jul 2022 13:28:05 GMT, Jaroslav Bachorik wrote: >> Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical. >> >> This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`. > > Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Update copyrights > - Merge branch 'master' into jb/JMC-7855 > - JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks And one more thing: In RecordingImpl::writeCheckpointEvent, I see that a duration is calculated as well. Shouldn't it then maybe also rather use the value of `duration` if it is > 0? ------------- PR: https://git.openjdk.org/jmc/pull/412 From clanger at openjdk.org Tue Jul 19 11:58:10 2022 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 19 Jul 2022 11:58:10 GMT Subject: RFR: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions In-Reply-To: References: Message-ID: On Wed, 13 Jul 2022 15:22:54 GMT, Suchita Chaturvedi wrote: > This PR resolves the issue of thread attribute discrepancy between different JDK versions. > > The issue had two parts - first one was already resolved as part of another bug, second part will be fixed as part of this PR. > > 1. switchRate attribute in JDK 11 onwards have the content type as frequency but pre JDK 11 the content type was number. > 2. Pre JDK 9 the attribute name was javalangthread whereas post JDK 9 its thread. LGTM ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/411 From hirt at openjdk.org Wed Jul 20 18:04:13 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 20 Jul 2022 18:04:13 GMT Subject: RFR: 7856: Fix errors in Eclipse projects after JMC-7769 In-Reply-To: References: Message-ID: On Fri, 15 Jul 2022 21:23:34 GMT, Christoph Langer wrote: > [JMC-7769](https://bugs.openjdk.org/browse/JMC-7769) cleaned up the project layout for missioncontrol core, especially the test projects. > However, after that patch, an Eclipse IDE setup shows errors in test projects of the application, e.g. in org.openjdk.jmc.rjmx.test. > > This is caused by an issue in project setup of core/tests/org.openjdk.jmc.common.test, which is a prerequisite to some other test projects. > Class files are generated into the target/test-classes folder but Eclipse only exposes target/classes to dependent projects. > > The fix is to set up org.openjdk.jmc.common.test like a general library project, only using src/main/java -> target/classes. > > Because it is a module of missioncontrol.core.tests, the property `fail.if.no.tests=false` needs to be set, otherwise the build fails because tests would be expected. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/413 From clanger at openjdk.org Wed Jul 20 20:16:14 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 20 Jul 2022 20:16:14 GMT Subject: Integrated: 7856: Fix errors in Eclipse projects after JMC-7769 In-Reply-To: References: Message-ID: On Fri, 15 Jul 2022 21:23:34 GMT, Christoph Langer wrote: > [JMC-7769](https://bugs.openjdk.org/browse/JMC-7769) cleaned up the project layout for missioncontrol core, especially the test projects. > However, after that patch, an Eclipse IDE setup shows errors in test projects of the application, e.g. in org.openjdk.jmc.rjmx.test. > > This is caused by an issue in project setup of core/tests/org.openjdk.jmc.common.test, which is a prerequisite to some other test projects. > Class files are generated into the target/test-classes folder but Eclipse only exposes target/classes to dependent projects. > > The fix is to set up org.openjdk.jmc.common.test like a general library project, only using src/main/java -> target/classes. > > Because it is a module of missioncontrol.core.tests, the property `fail.if.no.tests=false` needs to be set, otherwise the build fails because tests would be expected. This pull request has now been integrated. Changeset: b5e03c67 Author: Christoph Langer URL: https://git.openjdk.org/jmc/commit/b5e03c6761aaf70e21374068d5fb6a4a4ad8d4f2 Stats: 15 lines in 3 files changed: 8 ins; 5 del; 2 mod 7856: Fix errors in Eclipse projects after JMC-7769 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/413 From clanger at openjdk.org Wed Jul 20 21:29:11 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 20 Jul 2022 21:29:11 GMT Subject: RFR: 7820: Add validations for master password [v2] In-Reply-To: References: Message-ID: On Wed, 13 Jul 2022 11:49:20 GMT, Suchita Chaturvedi wrote: >> This PR adds password validations for master password field. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Added Junit test cases and moved the logic to common util file Overall looks good. Thanks for adding a unit test. I've added some minor review points. application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/PersistentCredentials.java line 86: > 84: > 85: public static boolean isPasswordValid(final String password) { > 86: Pattern PASSWORD_PATTERN = Pattern Maybe you want to have PASSWORD_PATTERN as a static field with lazy initialization? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/security/MasterPasswordWizardPage.java line 37: > 35: import java.util.regex.Matcher; > 36: import java.util.regex.Pattern; > 37: Not needed any more application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/security/MasterPasswordWizardPage.java line 40: > 38: import org.eclipse.jface.resource.JFaceResources; > 39: import org.eclipse.jface.wizard.WizardPage; > 40: import org.eclipse.osgi.util.NLS; the import org.eclipse.osgi.util.NLS is unnecessary now application/org.openjdk.jmc.ui/src/main/resources/org/openjdk/jmc/ui/security/messages.properties line 43: > 41: MasterPasswordWizardPage_ERROR_PASSWORD_EMPTY_TEXT=Password can not be empty! > 42: # {0} is a number > 43: MasterPasswordWizardPage_ERROR_MESSAGE_PASSWORD_VALIDATION_FAILED=Password must contain at least one lowercase character, one uppercase character, one digit, one special character, and a length between 8 to 20. Wording: ... and have a length ... ------------- Changes requested by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/406 From hirt at openjdk.org Thu Jul 21 10:54:17 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 21 Jul 2022 10:54:17 GMT Subject: RFR: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions In-Reply-To: References: Message-ID: On Wed, 13 Jul 2022 15:22:54 GMT, Suchita Chaturvedi wrote: > This PR resolves the issue of thread attribute discrepancy between different JDK versions. > > The issue had two parts - first one was already resolved as part of another bug, second part will be fixed as part of this PR. > > 1. switchRate attribute in JDK 11 onwards have the content type as frequency but pre JDK 11 the content type was number. > 2. Pre JDK 9 the attribute name was javalangthread whereas post JDK 9 its thread. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/411 From schaturvedi at openjdk.org Fri Jul 22 05:49:50 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 22 Jul 2022 05:49:50 GMT Subject: Integrated: 7243: Resolve discrepancy between JDK attributes coming from different JDK versions In-Reply-To: References: Message-ID: On Wed, 13 Jul 2022 15:22:54 GMT, Suchita Chaturvedi wrote: > This PR resolves the issue of thread attribute discrepancy between different JDK versions. > > The issue had two parts - first one was already resolved as part of another bug, second part will be fixed as part of this PR. > > 1. switchRate attribute in JDK 11 onwards have the content type as frequency but pre JDK 11 the content type was number. > 2. Pre JDK 9 the attribute name was javalangthread whereas post JDK 9 its thread. This pull request has now been integrated. Changeset: e65b5fe6 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/e65b5fe601fab4b8417ed23b28971d7061dc5aab Stats: 15 lines in 1 file changed: 13 ins; 0 del; 2 mod 7243: Resolve discrepancy between JDK attributes coming from different JDK versions Reviewed-by: clanger, hirt ------------- PR: https://git.openjdk.org/jmc/pull/411 From duke at openjdk.org Sat Jul 23 11:44:54 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sat, 23 Jul 2022 11:44:54 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v18] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-7455: Use proper dependency machanism for wiremock ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/1dba9790..412ad827 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=17 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=16-17 Stats: 46 lines in 7 files changed: 12 ins; 7 del; 27 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sat Jul 23 16:45:08 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sat, 23 Jul 2022 16:45:08 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v19] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/412ad827..51c97824 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=18 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=17-18 Stats: 792 lines in 25 files changed: 792 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From hdafgard at openjdk.org Sun Jul 24 00:29:12 2022 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sun, 24 Jul 2022 00:29:12 GMT Subject: RFR: 7820: Add validations for master password [v2] In-Reply-To: References: Message-ID: On Wed, 13 Jul 2022 11:49:20 GMT, Suchita Chaturvedi wrote: >> This PR adds password validations for master password field. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Added Junit test cases and moved the logic to common util file Changes requested by hdafgard (Reviewer). application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/PersistentCredentials.java line 87: > 85: public static boolean isPasswordValid(final String password) { > 86: Pattern PASSWORD_PATTERN = Pattern > 87: .compile("^(?=.*[0-9])(?=.*[a-z])(?=.*[A-Z])(?=.*[!@#(&)[{-}]:;',?/*~$^+=<>]).{8,20}$"); //$NON-NLS-1$ I think we could make this quite a lot simpler. Generally I'd say that password length is more important than checking for special characters and numbers. application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/security/MasterPasswordTest.java line 59: > 57: } > 58: > 59: } I would prefer better testing here. This is a decent place to implement some property based tests that use fuzzing to verify that inputs will satisfy the requirements of a minimum length, alphanumeric-ness and special characters. ------------- PR: https://git.openjdk.org/jmc/pull/406 From hdafgard at openjdk.org Sun Jul 24 00:29:13 2022 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sun, 24 Jul 2022 00:29:13 GMT Subject: RFR: 7820: Add validations for master password [v2] In-Reply-To: References: Message-ID: On Wed, 20 Jul 2022 20:18:36 GMT, Christoph Langer wrote: >> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: >> >> Added Junit test cases and moved the logic to common util file > > application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/PersistentCredentials.java line 86: > >> 84: >> 85: public static boolean isPasswordValid(final String password) { >> 86: Pattern PASSWORD_PATTERN = Pattern > > Maybe you want to have PASSWORD_PATTERN as a static field with lazy initialization? Or just initialized on class load, but it should not be done for each password comparison. ------------- PR: https://git.openjdk.org/jmc/pull/406 From duke at openjdk.org Sun Jul 24 07:02:16 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 07:02:16 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v20] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/51c97824..43d21621 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=19 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=18-19 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 24 07:26:23 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 07:26:23 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v21] In-Reply-To: References: Message-ID: <8wA2Ut_zHx3jYqTxlFdNBuC_VB_0GgTuB-jSgM48LZQ=.2f2201a1-fcde-49fd-9f1b-7efbd737a798@github.com> > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/43d21621..f523ab38 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=20 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=19-20 Stats: 48 lines in 7 files changed: 2 ins; 40 del; 6 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 24 07:33:24 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 07:33:24 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v22] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/f523ab38..0e9e1461 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=21 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=20-21 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 24 07:45:06 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 07:45:06 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v6] In-Reply-To: <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com> References: <07YA3dr8ItooyEahwJ_DcBZRmAMQWopNjy1bJKUfX5o=.9447a826-e0db-47bd-ae41-d67c08320528@github.com> Message-ID: On Mon, 20 Dec 2021 10:42:08 GMT, Marcus Hirt wrote: >> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: >> >> Removed -XstartOnFirstThread as it is not valid for some JVMs > > I took a quick pass on (mainly) the javadocs. Hi again! Have been missing in action for a bit due to very critical phase at client, but have taken some time off my holiday to figure out a way to test the kubernetes support by mocking. If I could please have a CI test run to see that it works fine in the pipeline. Also rebased and updated to 8.3. cc: @thegreystone ------------- PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 24 07:48:54 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 07:48:54 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v23] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/0e9e1461..350617e1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=22 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=21-22 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Sun Jul 24 13:52:10 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Jul 2022 13:52:10 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v24] In-Reply-To: References: Message-ID: > Setting back for review. The azure problem requires a fix in Jolokia. > > Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: JMC-7455: Create a test plugin for kubernetes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/332/files - new: https://git.openjdk.org/jmc/pull/332/files/350617e1..7337f3a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=23 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=22-23 Stats: 58 lines in 1 file changed: 19 ins; 15 del; 24 mod Patch: https://git.openjdk.org/jmc/pull/332.diff Fetch: git fetch https://git.openjdk.org/jmc pull/332/head:pull/332 PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Wed Jul 27 06:42:07 2022 From: duke at openjdk.org (Virag Purnam) Date: Wed, 27 Jul 2022 06:42:07 GMT Subject: RFR: 7858: Upgrade jetty.project in github to 10.0.11 Message-ID: With eclipse 4.24, default jetty version is 10.0.9. Some important issues have been addressed in latest releases 10.0.10 and 10.0.11. So we need to upgrade jetty to latest version 10.0.11. ------------- Commit messages: - 7858: Upgrade jetty.project in github to 10.0.11 Changes: https://git.openjdk.org/jmc/pull/414/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=414&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7858 Stats: 33 lines in 8 files changed: 0 ins; 0 del; 33 mod Patch: https://git.openjdk.org/jmc/pull/414.diff Fetch: git fetch https://git.openjdk.org/jmc pull/414/head:pull/414 PR: https://git.openjdk.org/jmc/pull/414 From duke at openjdk.org Wed Jul 27 08:47:17 2022 From: duke at openjdk.org (Brice Dutheil) Date: Wed, 27 Jul 2022 08:47:17 GMT Subject: RFR: 7858: Upgrade jetty.project in github to 10.0.11 In-Reply-To: References: Message-ID: On Wed, 27 Jul 2022 06:36:18 GMT, Virag Purnam wrote: > With eclipse 4.24, default jetty version is 10.0.9. Some important issues have been addressed in latest releases 10.0.10 and 10.0.11. So we need to upgrade jetty to latest version 10.0.11. Marked as reviewed by bric3 at github.com (no known OpenJDK username). ------------- PR: https://git.openjdk.org/jmc/pull/414 From clanger at openjdk.org Wed Jul 27 08:52:07 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 27 Jul 2022 08:52:07 GMT Subject: RFR: 7858: Upgrade jetty.project in github to 10.0.11 In-Reply-To: References: Message-ID: On Wed, 27 Jul 2022 06:36:18 GMT, Virag Purnam wrote: > With eclipse 4.24, default jetty version is 10.0.9. Some important issues have been addressed in latest releases 10.0.10 and 10.0.11. So we need to upgrade jetty to latest version 10.0.11. Marked as reviewed by clanger (Committer). ------------- PR: https://git.openjdk.org/jmc/pull/414 From duke at openjdk.org Wed Jul 27 10:00:27 2022 From: duke at openjdk.org (Virag Purnam) Date: Wed, 27 Jul 2022 10:00:27 GMT Subject: Integrated: 7858: Upgrade jetty.project in github to 10.0.11 In-Reply-To: References: Message-ID: On Wed, 27 Jul 2022 06:36:18 GMT, Virag Purnam wrote: > With eclipse 4.24, default jetty version is 10.0.9. Some important issues have been addressed in latest releases 10.0.10 and 10.0.11. So we need to upgrade jetty to latest version 10.0.11. This pull request has now been integrated. Changeset: 7606e1c4 Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/7606e1c4fdbe9a3f1745ef4d2b5f8403e25484af Stats: 33 lines in 8 files changed: 0 ins; 0 del; 33 mod 7858: Upgrade jetty.project in github to 10.0.11 Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jmc/pull/414 From clanger at openjdk.org Wed Jul 27 11:28:37 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 27 Jul 2022 11:28:37 GMT Subject: RFR: 7861: Bump Agent build to Java 11 compliance and cleanup POM Message-ID: <9w5LulZ5aF3cYLKfHf44T7HvN5LZENmjPJTghdKjuLQ=.f77d3912-4795-4f95-b4ae-7edd62219c85@github.com> The JMC Agent project is set up in a somewhat awkward way at the moment. The maven.compiler.source and maven.compiler.target properties are set to 1.8 but we enforce a JDK 11 during the build and also have a test case that implicitly uses/tests JDK11 features. Maybe it is time now to bump the agent to Java 11 compliance? Furthermore, the POM file could be cleaned up and a few maven plugins that are used could be bumped to more recent versions. ------------- Commit messages: - Cleanup JMC agent pom Changes: https://git.openjdk.org/jmc/pull/415/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=415&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7861 Stats: 214 lines in 3 files changed: 87 ins; 86 del; 41 mod Patch: https://git.openjdk.org/jmc/pull/415.diff Fetch: git fetch https://git.openjdk.org/jmc pull/415/head:pull/415 PR: https://git.openjdk.org/jmc/pull/415 From duke at openjdk.org Wed Jul 27 11:31:26 2022 From: duke at openjdk.org (Virag Purnam) Date: Wed, 27 Jul 2022 11:31:26 GMT Subject: RFR: 7860: Upgrade d3-flame-graph in github to 4.1.3 Message-ID: Upgraded the d3-flame-graph from 4.0.6 to latest version 4.1.3 and updated the license accordingly. ------------- Commit messages: - 7860: Upgrade d3-flame-graph in github to 4.1.3 Changes: https://git.openjdk.org/jmc/pull/416/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=416&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7860 Stats: 431 lines in 3 files changed: 192 ins; 207 del; 32 mod Patch: https://git.openjdk.org/jmc/pull/416.diff Fetch: git fetch https://git.openjdk.org/jmc pull/416/head:pull/416 PR: https://git.openjdk.org/jmc/pull/416 From schaturvedi at openjdk.org Wed Jul 27 15:56:30 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 27 Jul 2022 15:56:30 GMT Subject: RFR: 7820: Add validations for master password [v3] In-Reply-To: References: Message-ID: <9pnKx89-tf1itu-DLqPpmKC6Eqb32hv6N1A3yvxy2qY=.b97df34f-e4b9-4bc0-8098-f49ec29e8a11@github.com> > This PR adds password validations for master password field. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments ------------- Changes: - all: https://git.openjdk.org/jmc/pull/406/files - new: https://git.openjdk.org/jmc/pull/406/files/10d0e54a..ba4bbfa3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=01-02 Stats: 39 lines in 4 files changed: 30 ins; 6 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/406.diff Fetch: git fetch https://git.openjdk.org/jmc pull/406/head:pull/406 PR: https://git.openjdk.org/jmc/pull/406 From clanger at openjdk.org Wed Jul 27 21:08:08 2022 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 27 Jul 2022 21:08:08 GMT Subject: RFR: 7820: Add validations for master password [v3] In-Reply-To: <9pnKx89-tf1itu-DLqPpmKC6Eqb32hv6N1A3yvxy2qY=.b97df34f-e4b9-4bc0-8098-f49ec29e8a11@github.com> References: <9pnKx89-tf1itu-DLqPpmKC6Eqb32hv6N1A3yvxy2qY=.b97df34f-e4b9-4bc0-8098-f49ec29e8a11@github.com> Message-ID: On Wed, 27 Jul 2022 15:56:30 GMT, Suchita Chaturvedi wrote: >> This PR adds password validations for master password field. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Implemented review comments Thanks for the update. Nearly close from my POV, just few minor nits. application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/security/PersistentCredentials.java line 89: > 87: > 88: public static boolean isPasswordValid(final String password) { > 89: empty line can be removed application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/security/MasterPasswordTest.java line 44: > 42: public class MasterPasswordTest { > 43: > 44: private final String invalidPwdValue = "Jmc20"; // Invalid Length, Missing alphanumeric You mean missing special character (instead of alphanumeric), no? application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/security/MasterPasswordTest.java line 46: > 44: private final String invalidPwdValue = "Jmc20"; // Invalid Length, Missing alphanumeric > 45: private final String validPwdValue = "Jmc at 2022"; // Following all standards > 46: private final String invalidPwdValue1 = "Jmcu2022"; // Missing alphanumeric Same here: not alphanumeric but "special character" application/tests/org.openjdk.jmc.ui.test/src/test/java/org/openjdk/jmc/ui/test/security/MasterPasswordTest.java line 64: > 62: > 63: @Test > 64: public void testInvalidPwdMissingAlphaNum() throws Exception { should then rather be `testInvalidPwdMissingSpecialChar` ------------- Changes requested by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/406 From schaturvedi at openjdk.org Thu Jul 28 00:59:54 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 28 Jul 2022 00:59:54 GMT Subject: RFR: 7820: Add validations for master password [v4] In-Reply-To: References: Message-ID: > This PR adds password validations for master password field. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Minor modifications as per review ------------- Changes: - all: https://git.openjdk.org/jmc/pull/406/files - new: https://git.openjdk.org/jmc/pull/406/files/ba4bbfa3..0bce856a Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=02-03 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/406.diff Fetch: git fetch https://git.openjdk.org/jmc pull/406/head:pull/406 PR: https://git.openjdk.org/jmc/pull/406 From hirt at openjdk.org Thu Jul 28 19:46:43 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 28 Jul 2022 19:46:43 GMT Subject: RFR: 7860: Upgrade d3-flame-graph in github to 4.1.3 In-Reply-To: References: Message-ID: On Wed, 27 Jul 2022 11:23:40 GMT, Virag Purnam wrote: > Upgraded the d3-flame-graph from 4.0.6 to latest version 4.1.3 and updated the license accordingly. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/416 From clanger at openjdk.org Thu Jul 28 21:53:51 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 28 Jul 2022 21:53:51 GMT Subject: RFR: 7820: Add validations for master password [v4] In-Reply-To: References: Message-ID: On Thu, 28 Jul 2022 00:59:54 GMT, Suchita Chaturvedi wrote: >> This PR adds password validations for master password field. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Minor modifications as per review Thumbs up ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/406 From duke at openjdk.org Fri Jul 29 05:43:49 2022 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 29 Jul 2022 05:43:49 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v24] In-Reply-To: References: Message-ID: On Sun, 24 Jul 2022 13:52:10 GMT, Martin Skarsaune wrote: >> Setting back for review. The azure problem requires a fix in Jolokia. >> >> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. > > Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > JMC-7455: Create a test plugin for kubernetes Yeah, whenever I think I am done done, I think of something more to fix .... Set to draft now. Will probably draw the line in not too many days. ------------- PR: https://git.openjdk.org/jmc/pull/332 From duke at openjdk.org Fri Jul 29 12:03:22 2022 From: duke at openjdk.org (Bhogesh Patil) Date: Fri, 29 Jul 2022 12:03:22 GMT Subject: RFR: 7862: Platform-definitions-2022-06.target file has space in pde version Message-ID: 7862: Platform-definitions-2022-06.target file has space in pde version ------------- Commit messages: - Merge branch 'jmc-7862' of https://github.com/bhopatil/jmc into jmc-7862 - Removed space from platform-definition-2022-06.target - JMC-7862: Removed space from platform-definition-2022-06.target Changes: https://git.openjdk.org/jmc/pull/417/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=417&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7862 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/417.diff Fetch: git fetch https://git.openjdk.org/jmc pull/417/head:pull/417 PR: https://git.openjdk.org/jmc/pull/417 From hirt at openjdk.org Fri Jul 29 12:03:23 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 29 Jul 2022 12:03:23 GMT Subject: RFR: 7862: Platform-definitions-2022-06.target file has space in pde version In-Reply-To: References: Message-ID: On Fri, 29 Jul 2022 11:43:02 GMT, Bhogesh Patil wrote: > 7862: Platform-definitions-2022-06.target file has space in pde version Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/417 From duke at openjdk.org Fri Jul 29 12:06:44 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 29 Jul 2022 12:06:44 GMT Subject: Integrated: 7860: Upgrade d3-flame-graph in github to 4.1.3 In-Reply-To: References: Message-ID: On Wed, 27 Jul 2022 11:23:40 GMT, Virag Purnam wrote: > Upgraded the d3-flame-graph from 4.0.6 to latest version 4.1.3 and updated the license accordingly. This pull request has now been integrated. Changeset: 591d7b6b Author: vpurnam Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/591d7b6b8e291d57426aed80715c743bf947cddc Stats: 431 lines in 3 files changed: 192 ins; 207 del; 32 mod 7860: Upgrade d3-flame-graph in github to 4.1.3 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/416 From duke at openjdk.org Fri Jul 29 12:28:44 2022 From: duke at openjdk.org (Bhogesh Patil) Date: Fri, 29 Jul 2022 12:28:44 GMT Subject: Integrated: 7862: Platform-definitions-2022-06.target file has space in pde version In-Reply-To: References: Message-ID: <5Fbf4Iz-6ODc6Qzn9mD1cgycE0UZczzJIs3ee6_S83o=.0346f3c8-d51f-4ec1-8cbc-4aa326dee09e@github.com> On Fri, 29 Jul 2022 11:43:02 GMT, Bhogesh Patil wrote: > 7862: Platform-definitions-2022-06.target file has space in pde version This pull request has now been integrated. Changeset: eabb8615 Author: Bhogesh Patil Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/eabb8615a3f73360626374748b36324f77a6cef3 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7862: Platform-definitions-2022-06.target file has space in pde version Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/417