RFR: 7834: Improve GitHub Actions validation workflow

Marcus Hirt hirt at openjdk.org
Wed Jul 6 18:37:55 UTC 2022


On Tue, 5 Jul 2022 06:01:21 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Improve validation workflow.
> 
> - It should not run on "pull_request" (OpenJDK repos don't allow this but will transfer results of push runs in forked repositories into status checks of PRs)
> - A possibility to trigger the workflow manually via "workflow_dispatch" would be nice
> - Updates to a branch should cancel running actions in favor of a new run to save resources
> - The workflow script can have less redundant code by using a matrix strategy for the different operating systems that are tested
> - Used actions can be version-bumped
> - Naming of some steps can be improved
> - The test steps and their order can be improved to make the steps more logical and explicit:
>   1. Build&Test core
>   2. Start P2 repository
>   3. Build&Test application
>   4. Build&Test agent
>   5. Run spotless
> - Use maven option --no-transfer-progress to get less noisy logs
> 
> Now also the Windows actions run in the bash shell and use the .sh scripts instead of their .bat counterparts.
> One could think of deleting them but maybe they are used elsewhere, so keep them (up to date).

Looks great!

-------------

Marked as reviewed by hirt (Lead).

PR: https://git.openjdk.org/jmc/pull/407


More information about the jmc-dev mailing list