From hirt at openjdk.org Sat Jun 18 21:10:21 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 18 Jun 2022 21:10:21 GMT Subject: RFR: 7827: Update to Eclipse 2022-06 Message-ID: Just a platform update. ------------- Commit messages: - 7827: Update to 2022-06 Changes: https://git.openjdk.org/jmc/pull/403/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=403&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7827 Stats: 42 lines in 5 files changed: 39 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/403.diff Fetch: git fetch https://git.openjdk.org/jmc pull/403/head:pull/403 PR: https://git.openjdk.org/jmc/pull/403 From hirt at openjdk.org Sat Jun 18 21:42:47 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 18 Jun 2022 21:42:47 GMT Subject: RFR: 7827: Update to Eclipse 2022-06 [v2] In-Reply-To: References: Message-ID: > Just a platform update. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Updated wrong file ------------- Changes: - all: https://git.openjdk.org/jmc/pull/403/files - new: https://git.openjdk.org/jmc/pull/403/files/79b560f2..24b63449 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=403&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=403&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/403.diff Fetch: git fetch https://git.openjdk.org/jmc pull/403/head:pull/403 PR: https://git.openjdk.org/jmc/pull/403 From jpbempel at openjdk.org Sun Jun 19 20:30:39 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Sun, 19 Jun 2022 20:30:39 GMT Subject: RFR: 7827: Update to Eclipse 2022-06 [v2] In-Reply-To: References: Message-ID: On Sat, 18 Jun 2022 21:42:47 GMT, Marcus Hirt wrote: >> Just a platform update. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Updated wrong file Marked as reviewed by jpbempel (Committer). ------------- PR: https://git.openjdk.org/jmc/pull/403 From duke at openjdk.org Sun Jun 19 23:14:07 2022 From: duke at openjdk.org (Brice Dutheil) Date: Sun, 19 Jun 2022 23:14:07 GMT Subject: RFR: 7827: Update to Eclipse 2022-06 [v2] In-Reply-To: References: Message-ID: On Sat, 18 Jun 2022 21:42:47 GMT, Marcus Hirt wrote: >> Just a platform update. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Updated wrong file Marked as reviewed by bric3 at github.com (no known OpenJDK username). ------------- PR: https://git.openjdk.org/jmc/pull/403 From hirt at openjdk.org Mon Jun 20 09:10:09 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 20 Jun 2022 09:10:09 GMT Subject: Integrated: 7827: Update to Eclipse 2022-06 In-Reply-To: References: Message-ID: <6z2RYFFgOO4Y32A3Uog-s8vK9HNi_POT927-YPwuja4=.e8a89092-b39c-444d-aff0-7586abc83b51@github.com> On Sat, 18 Jun 2022 21:05:57 GMT, Marcus Hirt wrote: > Just a platform update. This pull request has now been integrated. Changeset: cd7b6e6c Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/cd7b6e6c0d0c1ec1de04aa0c3481511445bf425d Stats: 46 lines in 5 files changed: 39 ins; 0 del; 7 mod 7827: Update to Eclipse 2022-06 Reviewed-by: jpbempel ------------- PR: https://git.openjdk.org/jmc/pull/403 From duke at openjdk.org Tue Jun 28 14:34:24 2022 From: duke at openjdk.org (Brice Dutheil) Date: Tue, 28 Jun 2022 14:34:24 GMT Subject: RFR: 7831: Add new view for hierarchical edge bundling Message-ID: Joint effort with @cimi to provide _hierarchical edge_ visualization to JMC. ![Hierarchical Edge view](https://user-images.githubusercontent.com/803621/176186654-04f458f5-6f7d-4755-822c-f63e53ccfc31.png) Here when the mouse hovers `java.util.concurrent` on the bottom right. One can see the relations with other packages. Based on the preliminary work of @cimi here : https://observablehq.com/@cimi/jfr-graph-hierarchical-edge-bundling ------------- Commit messages: - Fix StackFrame parsing for native frames that have . in method name - Add a simple package level filter - First working example of hierarchical edge bundling - Initial import of hierarchical viz JS from observable - Update hierarchical-edge page.template: remove JS comments, add debug - Initial Hierarchical Edge Vizualisation - fix project name - Fix package name in HierarchicalEdgeView - Add .classpath and .project files for hierarchical viz - Initial Hierarchical Edge Vizualisation - fix plugin id typo - Initial Hierarchical Edge Vizualisation - add icons - ... and 2 more: https://git.openjdk.org/jmc/compare/cd7b6e6c...64f3602c Changes: https://git.openjdk.org/jmc/pull/405/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=405&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7831 Stats: 840 lines in 19 files changed: 817 ins; 9 del; 14 mod Patch: https://git.openjdk.org/jmc/pull/405.diff Fetch: git fetch https://git.openjdk.org/jmc pull/405/head:pull/405 PR: https://git.openjdk.org/jmc/pull/405 From duke at openjdk.org Tue Jun 28 14:35:17 2022 From: duke at openjdk.org (Brice Dutheil) Date: Tue, 28 Jun 2022 14:35:17 GMT Subject: RFR: 7832: Refresh dev guide Message-ID: **Changes** * Update the style of interface navigation for easier readability (like _Preferences | Java ..._). * Mentioned the compiler language level, Eclipse may default to a higher level like 17 and results in IAE (`Unsupported class file major version` / `Incompatible class version`) * I believe the minimum version needed is now 2021-06 ? ------------- Commit messages: - Refresh dev guide Changes: https://git.openjdk.org/jmc/pull/404/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=404&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7832 Stats: 19 lines in 2 files changed: 6 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/404.diff Fetch: git fetch https://git.openjdk.org/jmc pull/404/head:pull/404 PR: https://git.openjdk.org/jmc/pull/404 From hirt at openjdk.org Tue Jun 28 14:35:17 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 28 Jun 2022 14:35:17 GMT Subject: RFR: 7832: Refresh dev guide In-Reply-To: References: Message-ID: On Tue, 28 Jun 2022 08:12:19 GMT, Brice Dutheil wrote: > **Changes** > * Update the style of interface navigation for easier readability (like _Preferences | Java ..._). > * Mentioned the compiler language level, Eclipse may default to a higher level like 17 and results in IAE (`Unsupported class file major version` / `Incompatible class version`) > * I believe the minimum version needed is now 2021-06 ? Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/404 From duke at openjdk.org Tue Jun 28 19:56:41 2022 From: duke at openjdk.org (Brice Dutheil) Date: Tue, 28 Jun 2022 19:56:41 GMT Subject: Integrated: 7832: Refresh dev guide In-Reply-To: References: Message-ID: On Tue, 28 Jun 2022 08:12:19 GMT, Brice Dutheil wrote: > **Changes** > * Update the style of interface navigation for easier readability (like _Preferences | Java ..._). > * Mentioned the compiler language level, Eclipse may default to a higher level like 17 and results in IAE (`Unsupported class file major version` / `Incompatible class version`) > * I believe the minimum version needed is now 2021-06 ? This pull request has now been integrated. Changeset: 50efd930 Author: Brice Dutheil Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/50efd930f93e80a6d19960bae750fce7badc2380 Stats: 19 lines in 2 files changed: 6 ins; 0 del; 13 mod 7832: Refresh dev guide Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/404 From schaturvedi at openjdk.org Wed Jun 29 22:22:11 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 29 Jun 2022 22:22:11 GMT Subject: RFR: 7820: Add validations for master password Message-ID: This PR adds password validations for master password field. ------------- Commit messages: - 7820: Add validations for master password Changes: https://git.openjdk.org/jmc/pull/406/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=406&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7820 Stats: 21 lines in 3 files changed: 11 ins; 3 del; 7 mod Patch: https://git.openjdk.org/jmc/pull/406.diff Fetch: git fetch https://git.openjdk.org/jmc pull/406/head:pull/406 PR: https://git.openjdk.org/jmc/pull/406 From clanger at openjdk.org Thu Jun 30 08:37:39 2022 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 30 Jun 2022 08:37:39 GMT Subject: RFR: 7820: Add validations for master password In-Reply-To: References: Message-ID: On Wed, 29 Jun 2022 22:16:18 GMT, Suchita Chaturvedi wrote: > This PR adds password validations for master password field. The change looks good in general. Would it be possible to create a unit test for password validation? ------------- PR: https://git.openjdk.org/jmc/pull/406