From hirt at openjdk.java.net  Wed Mar  2 14:15:10 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Wed, 2 Mar 2022 14:15:10 GMT
Subject: RFR: JMC-9999 Allowing char attribute to be parsed [v3]
In-Reply-To: <BF7XMJgCVxOXu6GdvT5C-kfNudNZj3ZGhzwxG-LS8DE=.d2cbb25d-4704-403a-bd11-5194b8c3270c@github.com>
References: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
 <BF7XMJgCVxOXu6GdvT5C-kfNudNZj3ZGhzwxG-LS8DE=.d2cbb25d-4704-403a-bd11-5194b8c3270c@github.com>
Message-ID: <WW98pR3M8bilFpbxmwRm8HSHQmmbp_fyBezLv6Sos6s=.51a216e3-cf93-439c-b1db-8deab68fc28c@github.com>

On Fri, 25 Feb 2022 15:45:40 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

>> Hey @thegreystone, I noticed that JFR events with `char` attributes cannot be loaded into JMC:
>> 
>> 
>> org.openjdk.jmc.flightrecorder.internal.InvalidJfrFileException: Unknown integer type: char
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$PrimitiveReader.readLong(ValueReaders.java:424)
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$QuantityReader.read(ValueReaders.java:192)
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager$EventTypeEntry.readEvent(TypeManager.java:319)
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager.readEvent(TypeManager.java:420)
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:92)
>> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:47)
>> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>> 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
>> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>> 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
>> 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
>> 	at java.base/java.lang.Thread.run(Thread.java:833)
>> 
>> 
>> The code in `ValueReaders::isNumeric` considers `char` to be numeric, causing this to be treated as `long` during parsing later on. With this fix, I can successfully load and examine a recording with such an attribute type using the `RecordingPrinter` (I haven't tried with the JMC UI, as I haven't set up the toolchain required for building it).
>> 
>> If you agree on the fix per se, could you
>> 
>> * log a JMC issue to which I can attribute this fix
>> * advice me on how/where to test this change (I didn't find any tests in the `flightrecorder` module)
>> 
>> Thanks!
>
> Gunnar Morling has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - JMC-9999 Improving misleading variable name
>  - JMC-9999 Allowing char attribute to be parsed

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/378

From duke at openjdk.java.net  Wed Mar  2 18:03:12 2022
From: duke at openjdk.java.net (Alex Ciminian)
Date: Wed, 2 Mar 2022 18:03:12 GMT
Subject: RFR: 7449: Add GitHub action to verify copyright year [v3]
In-Reply-To: <QSPAx7l74ZNGYG35CA55z9GBo4Fvs-qXigZoLe-UXl4=.4ede5341-4d70-4f17-829f-aa933b39cbe9@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
 <QSPAx7l74ZNGYG35CA55z9GBo4Fvs-qXigZoLe-UXl4=.4ede5341-4d70-4f17-829f-aa933b39cbe9@github.com>
Message-ID: <mgRjO8bIGgGmdx3dj9gWAE3IC1BTbUSHyDWfJUiErg4=.46d1a1d8-a6cf-449e-a037-a39700acd8a4@github.com>

On Sat, 11 Dec 2021 20:20:44 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

>> This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ?? 
>> 
>> The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).
>> 
>> It works as follows:
>> 
>> * diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
>> * for every changed file (except deletions), validate the copyright header
>>   - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
>>   - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
>> * we compare file contents from objects in the git repo, not the files themselves
>> * currently we don't validate we're in the correct directory or the commits
>> 
>> The output looks like this:
>> 
>> 
>> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                     
>> Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
>> ?? scripts/copyrightchecker.main.kts
>> ? Validation succeeded
>> 
>> 
>> 
>> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                       
>> Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
>> ?? .gitignore
>> ?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
>> ?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
>> Expected:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>> 	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>> 	Copyright (c) 2021, Datadog, Inc. All rights reserved.
>> 
>> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> Actual:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>>    Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>>    Copyright (c) 2021, Datadog, Inc. All rights reserved.
>> 
>>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
>> (check whitespace if strings seem to match)
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
>> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
>> ?? application/pom.xml
>> Expected:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>> 	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>> 
>> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>> Actual:
>> <?xml version="1.0" encoding="UTF-8"?>
>> <!--
>>    Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
>> 
>>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
>> (check whitespace if strings seem to match)
>> 
>> ? Validation failed
>
> Alex Ciminian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Run copyright checker during validate workflow on linux

I've put the script in a gist here: https://gist.github.com/cimi/3c623176fd0a2cab2dc8c4696178baf3

I'll close this PR, if you have ideas on how to run this if we write it in Java (and if you think it's worth it), I'm happy to port the code ??

-------------

PR: https://git.openjdk.java.net/jmc/pull/342

From duke at openjdk.java.net  Wed Mar  2 18:03:13 2022
From: duke at openjdk.java.net (Alex Ciminian)
Date: Wed, 2 Mar 2022 18:03:13 GMT
Subject: Withdrawn: 7449: Add GitHub action to verify copyright year
In-Reply-To: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
References: <va8OiL7O92WOuIQR0pHi0TDa5LXRka7XS_672iUQUhA=.b9168167-c1c4-4597-9a76-d086b4376e4e@github.com>
Message-ID: <O4EZyMBYEwHvJ71JGjt5_GKjsetzDGPzeQeFFZLO8sE=.9969041f-d962-44ad-a660-21ed301c852e@github.com>

On Sun, 5 Dec 2021 19:33:50 GMT, Alex Ciminian <duke at openjdk.java.net> wrote:

> This PR adds a script to check copyright notices on changed files. I've not added a GitHub action yet, I'd like to get some feedback before doing that ?? 
> 
> The script is written in Kotlin and uses [JGit](https://www.eclipse.org/jgit/) to interface with the git repository. To run, it only needs the kotlin compiler which is [preinstalled on GitHub Actions runners](https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md).
> 
> It works as follows:
> 
> * diff the HEAD commit and the merge base between it and master (i.e. where the feature branch diverged from)
> * for every changed file (except deletions), validate the copyright header
>   - if the file is new, it should have Oracle and Datadog copyright starting from the year of the HEAD commit
>   - if the file is not new, it should keep the existing copyright holders and update the year range if necessary
> * we compare file contents from objects in the git repo, not the files themselves
> * currently we don't validate we're in the correct directory or the commits
> 
> The output looks like this:
> 
> 
> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                     
> Checked out at: 759788185939b16f447e553b3ee64121187ea311 (base: 8b8aa7c299b92b655ba669a92d16f193beb406bc)
> ?? scripts/copyrightchecker.main.kts
> ? Validation succeeded
> 
> 
> 
> kotlinc -script scripts/copyrightchecker.main.kts                                                                                                                                                       
> Checked out at: 7ad43eed12c9eb85a96882c9518a9acbe12e74c5 (base: ca204424ce32336f2923aff66f619d571b1fc720)
> ?? .gitignore
> ?? application/org.openjdk.jmc.feature.flightrecorder/feature.xml
> ?? Failed to parse:    Copyright (c) 2018, 2021 Oracle and/or its affiliates. All rights reserved.
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.classpath
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/.gitignore
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/META-INF/MANIFEST.MF
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/build.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/icons/heatmap at 2x.png
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.properties
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/plugin.xml
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
> 	Copyright (c) 2021, Datadog, Inc. All rights reserved.
> 
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>    Copyright (c) 2021, Datadog, Inc. All rights reserved.
> 
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HE
> (check whitespace if strings seem to match)
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/java/org/openjdk/jmc/flightrecorder/heatmap/views/HeatmapView.java
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/heatmap.js
> ?? application/org.openjdk.jmc.flightrecorder.heatmap/src/main/resources/page.template
> ?? application/pom.xml
> Expected:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
> 	Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> 	DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> Actual:
> <?xml version="1.0" encoding="UTF-8"?>
> <!--
>    Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 
>    DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEAD
> (check whitespace if strings seem to match)
> 
> ? Validation failed

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.java.net/jmc/pull/342

From schaturvedi at openjdk.java.net  Fri Mar  4 12:03:22 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 4 Mar 2022 12:03:22 GMT
Subject: RFR: 7569: Improve the implementation of Twitter plugin
Message-ID: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>

Modified the Twitter plugin implementation a bit for a better approach.

-------------

Commit messages:
 - 7569: Improve the implementation of Twitter plugin

Changes: https://git.openjdk.java.net/jmc/pull/384/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=384&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7569
  Stats: 26 lines in 2 files changed: 7 ins; 9 del; 10 mod
  Patch: https://git.openjdk.java.net/jmc/pull/384.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/384/head:pull/384

PR: https://git.openjdk.java.net/jmc/pull/384

From schaturvedi at openjdk.java.net  Fri Mar  4 14:33:42 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 4 Mar 2022 14:33:42 GMT
Subject: RFR: 7569: Improve the implementation of Twitter plugin [v2]
In-Reply-To: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>
References: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>
Message-ID: <BsYA4ay4cfAiEFWxJ7U_9dDSqYfe0lG-qt0mmOaCHqg=.b072ce89-dec2-480a-b097-48339ade87a7@github.com>

> Modified the Twitter plugin implementation a bit for a better approach.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Added missing files

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/384/files
  - new: https://git.openjdk.java.net/jmc/pull/384/files/f3eaa0c8..f541fd1a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=384&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=384&range=00-01

  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/384.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/384/head:pull/384

PR: https://git.openjdk.java.net/jmc/pull/384

From schaturvedi at openjdk.java.net  Fri Mar  4 17:20:25 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Fri, 4 Mar 2022 17:20:25 GMT
Subject: RFR: 7443: Wrong version in THIRDPARTYREADME
Message-ID: <3enN6TezurDgMHGvNAi_GlPJMLCvnrk-_7u-xgl-WD4=.6b7834ae-4b0a-4272-8161-8ac4219b2c83@github.com>

Corrected Eclipse and D3 versions.

-------------

Commit messages:
 - 7443: Wrong version in THIRDPARTYREADME

Changes: https://git.openjdk.java.net/jmc/pull/385/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=385&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7443
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/385.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/385/head:pull/385

PR: https://git.openjdk.java.net/jmc/pull/385

From duke at openjdk.java.net  Mon Mar  7 16:01:07 2022
From: duke at openjdk.java.net (Gunnar Morling)
Date: Mon, 7 Mar 2022 16:01:07 GMT
Subject: Integrated: 7568: Support parsing char fields in jfr events
In-Reply-To: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
References: <TEqc7tglR8X-y56bbr4NSu5dlelEdeFBTI6B3rKWs0s=.43032549-ae29-48c6-ae21-a37baf1f6f7c@github.com>
Message-ID: <w9iClEQphq4QhrUHR_fPIjdHqI3lusrUDmtoAih4Di8=.75b6c768-7f11-4ff8-b022-4eea060778a2@github.com>

On Fri, 18 Feb 2022 10:18:33 GMT, Gunnar Morling <duke at openjdk.java.net> wrote:

> Hey @thegreystone, I noticed that JFR events with `char` attributes cannot be loaded into JMC:
> 
> 
> org.openjdk.jmc.flightrecorder.internal.InvalidJfrFileException: Unknown integer type: char
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$PrimitiveReader.readLong(ValueReaders.java:424)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ValueReaders$QuantityReader.read(ValueReaders.java:192)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager$EventTypeEntry.readEvent(TypeManager.java:319)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.TypeManager.readEvent(TypeManager.java:420)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:92)
> 	at org.openjdk.jmc.flightrecorder.internal.parser.v1.ChunkLoaderV1.call(ChunkLoaderV1.java:47)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> 	at java.base/java.lang.Thread.run(Thread.java:833)
> 
> 
> The code in `ValueReaders::isNumeric` considers `char` to be numeric, causing this to be treated as `long` during parsing later on. With this fix, I can successfully load and examine a recording with such an attribute type using the `RecordingPrinter` (I haven't tried with the JMC UI, as I haven't set up the toolchain required for building it).
> 
> If you agree on the fix per se, could you
> 
> * log a JMC issue to which I can attribute this fix
> * advice me on how/where to test this change (I didn't find any tests in the `flightrecorder` module)
> 
> Thanks!

This pull request has now been integrated.

Changeset: ab2f75d2
Author:    Gunnar Morling <gunnar.morling at googlemail.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/ab2f75d21c72733c43d3f7cb02550fb1c4c69fd6
Stats:     109 lines in 3 files changed: 105 ins; 1 del; 3 mod

7568: Support parsing char fields in jfr events

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/378

From hirt at openjdk.java.net  Mon Mar  7 16:02:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 7 Mar 2022 16:02:07 GMT
Subject: RFR: 7569: Improve the implementation of Twitter plugin [v2]
In-Reply-To: <BsYA4ay4cfAiEFWxJ7U_9dDSqYfe0lG-qt0mmOaCHqg=.b072ce89-dec2-480a-b097-48339ade87a7@github.com>
References: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>
 <BsYA4ay4cfAiEFWxJ7U_9dDSqYfe0lG-qt0mmOaCHqg=.b072ce89-dec2-480a-b097-48339ade87a7@github.com>
Message-ID: <le-NlGpE-3K3uIZRcZEI5eh9j4VenD2165zVHOjdQTw=.0e0a762e-250f-48d4-ac40-968b84c532b3@github.com>

On Fri, 4 Mar 2022 14:33:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Modified the Twitter plugin implementation a bit for a better approach.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added missing files

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/384

From hirt at openjdk.java.net  Mon Mar  7 16:02:08 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 7 Mar 2022 16:02:08 GMT
Subject: RFR: 7443: Wrong version in THIRDPARTYREADME
In-Reply-To: <3enN6TezurDgMHGvNAi_GlPJMLCvnrk-_7u-xgl-WD4=.6b7834ae-4b0a-4272-8161-8ac4219b2c83@github.com>
References: <3enN6TezurDgMHGvNAi_GlPJMLCvnrk-_7u-xgl-WD4=.6b7834ae-4b0a-4272-8161-8ac4219b2c83@github.com>
Message-ID: <xG5bHKupYilUNyOyH1CvHE2hIUV74E6M3i4pYz_LbXg=.90f66e1d-354a-43ab-b88d-cc3f552cbd54@github.com>

On Fri, 4 Mar 2022 17:14:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Corrected Eclipse and D3 versions.

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc/pull/385

From schaturvedi at openjdk.java.net  Mon Mar  7 16:30:10 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 7 Mar 2022 16:30:10 GMT
Subject: Integrated: 7443: Wrong version in THIRDPARTYREADME
In-Reply-To: <3enN6TezurDgMHGvNAi_GlPJMLCvnrk-_7u-xgl-WD4=.6b7834ae-4b0a-4272-8161-8ac4219b2c83@github.com>
References: <3enN6TezurDgMHGvNAi_GlPJMLCvnrk-_7u-xgl-WD4=.6b7834ae-4b0a-4272-8161-8ac4219b2c83@github.com>
Message-ID: <g1dOmTZ0u-RiBct8BvJv-TvjyY0cON6gOeVAORMwQ_g=.2a669688-2f27-4971-ad74-68e9fe430053@github.com>

On Fri, 4 Mar 2022 17:14:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Corrected Eclipse and D3 versions.

This pull request has now been integrated.

Changeset: d33cecb3
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/d33cecb345499794e1b4d7cfb5dab068b563b4b8
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

7443: Wrong version in THIRDPARTYREADME

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/385

From schaturvedi at openjdk.java.net  Mon Mar  7 16:32:11 2022
From: schaturvedi at openjdk.java.net (Suchita Chaturvedi)
Date: Mon, 7 Mar 2022 16:32:11 GMT
Subject: Integrated: 7569: Improve the implementation of Twitter plugin
In-Reply-To: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>
References: <J-swskm1_8woM8LEmVNBBRYiCsnpmQDVADlt5OALBX4=.7e9ce1cf-03a4-4a0a-84d3-33fd27ed8688@github.com>
Message-ID: <qV_gdTT9mNi5qOiFLVEE8EVGO7mJwQ5UUkpqF4CBSAQ=.c125f2ab-0984-4351-99f3-3bb41447921b@github.com>

On Fri, 4 Mar 2022 11:56:24 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Modified the Twitter plugin implementation a bit for a better approach.

This pull request has now been integrated.

Changeset: cc2d3812
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/cc2d381244e7fd26b428677868d02115d91a11fb
Stats:     30 lines in 4 files changed: 9 ins; 9 del; 12 mod

7569: Improve the implementation of Twitter plugin

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc/pull/384

From duke at openjdk.java.net  Thu Mar 10 13:27:06 2022
From: duke at openjdk.java.net (duke)
Date: Thu, 10 Mar 2022 13:27:06 GMT
Subject: git: openjdk/jmc: 7569: Improve the implementation of Twitter plugin
Message-ID: <3931ea80-6040-4158-a151-09e17c480225@openjdk.java.net>

Changeset: 2e5caafd
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
Committer: Marcus Hirt <marcus at hirt.se>
Date:      2022-03-07 16:28:27 +0000
URL:       https://git.openjdk.java.net/jmc/commit/2e5caafdb991a6f3bb969f48ad072fe0d219d23d

7569: Improve the implementation of Twitter plugin

Reviewed-by: hirt

! application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthAuthenticator.java
! application/org.openjdk.jmc.console.twitter/src/main/java/org/openjdk/jmc/console/twitter/TwitterOAuthHeaderGenerator.java
! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/actions/internal/Messages.java
! application/org.openjdk.jmc.rjmx/src/main/resources/org/openjdk/jmc/rjmx/triggers/actions/internal/messages.properties


From marcus.hirt at datadoghq.com  Thu Mar 10 13:38:34 2022
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Thu, 10 Mar 2022 14:38:34 +0100
Subject: Preparing for JMC 8.2.0 GA.
Message-ID: <CAOpWGx3hN7OZbPmJmSDoP1=mg1kE5mcOCwCAcXdxm_C=9c52Xw@mail.gmail.com>

Hi all,

The last two changes are now in the jmc8 branch. Unless final testing finds
something horrible, I will set the GA tag for 8.2.0 on Thursday next week.

Kind regards,
Marcus

From duke at openjdk.java.net  Thu Mar 10 14:08:55 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Thu, 10 Mar 2022 14:08:55 GMT
Subject: RFR: 7526: JMC not buildable with jdk17 [v14]
In-Reply-To: <P0aqSW5p50rdkPMHpa_Ydxy269HXHvDqkK9jlP6Mcus=.5074e1a7-2281-4336-b941-71d68ad9fce4@github.com>
References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com>
 <P0aqSW5p50rdkPMHpa_Ydxy269HXHvDqkK9jlP6Mcus=.5074e1a7-2281-4336-b941-71d68ad9fce4@github.com>
Message-ID: <F3_jDaiNJdp3tkM4S4BtWU7HdDslrR5poSb4XYeTbac=.b152183a-b879-4172-9c4a-ddf31f6b51cf@github.com>

On Thu, 3 Feb 2022 08:18:04 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting

The next tycho version is properly tested with JDK 17: https://github.com/eclipse/tycho/commit/4e7ca10e61f585966a7a8091e1418cc29ac2e63d

-------------

PR: https://git.openjdk.java.net/jmc/pull/363

From hirt at openjdk.java.net  Fri Mar 18 22:31:04 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Fri, 18 Mar 2022 22:31:04 GMT
Subject: RFR: 7573: Release notes for 8.2.0
Message-ID: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>

Run the Transform class to generate the html.

-------------

Commit messages:
 - Removing serializers images
 - 7573: Release notes for 8.2.0

Changes: https://git.openjdk.java.net/jmc/pull/389/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7573
  Stats: 184 lines in 20 files changed: 180 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/389.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/389/head:pull/389

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Sat Mar 19 17:46:04 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sat, 19 Mar 2022 17:46:04 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v2]
In-Reply-To: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
Message-ID: <iUvlPIG-mF0CgIlo-dyflnosZr0g4Ah1UWT90_w5-_Q=.551c622b-3024-4dce-b436-e17bd4d43242@github.com>

> Run the Transform class to generate the html.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Adding Jeff's new duke to the release notes - Jeff will add it later to jmc-graphics

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/389/files
  - new: https://git.openjdk.java.net/jmc/pull/389/files/7804eafc..0b984fd5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=00-01

  Stats: 1 line in 3 files changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jmc/pull/389.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/389/head:pull/389

PR: https://git.openjdk.java.net/jmc/pull/389

From aptmac at openjdk.java.net  Sat Mar 19 19:55:33 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Sat, 19 Mar 2022 19:55:33 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v2]
In-Reply-To: <iUvlPIG-mF0CgIlo-dyflnosZr0g4Ah1UWT90_w5-_Q=.551c622b-3024-4dce-b436-e17bd4d43242@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <iUvlPIG-mF0CgIlo-dyflnosZr0g4Ah1UWT90_w5-_Q=.551c622b-3024-4dce-b436-e17bd4d43242@github.com>
Message-ID: <zA1PA7GWC88jZjoQuIFlH0PBUrhDmJKdhzEQ58bIYzo=.8fda3124-15d2-4183-980c-1858c876cf4c@github.com>

On Sat, 19 Mar 2022 17:46:04 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Run the Transform class to generate the html.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding Jeff's new duke to the release notes - Jeff will add it later to jmc-graphics

releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 75:

> 73: 			<title>Heat map view</title>
> 74: 			<description>
> 75: 				A new heat map view has been added, which is handed to

Not sure if "handed" is the right word to use here?

releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 157:

> 155: 		<issue>
> 156: 			<area>JFR</area>
> 157: 			<bugid>7068</bugid>

This bug was resolved after an Eclipse update: https://bugs.openjdk.java.net/browse/JMC-7068

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From duke at openjdk.java.net  Sat Mar 19 21:19:31 2022
From: duke at openjdk.java.net (Johannes Bechberger)
Date: Sat, 19 Mar 2022 21:19:31 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v2]
In-Reply-To: <zA1PA7GWC88jZjoQuIFlH0PBUrhDmJKdhzEQ58bIYzo=.8fda3124-15d2-4183-980c-1858c876cf4c@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <iUvlPIG-mF0CgIlo-dyflnosZr0g4Ah1UWT90_w5-_Q=.551c622b-3024-4dce-b436-e17bd4d43242@github.com>
 <zA1PA7GWC88jZjoQuIFlH0PBUrhDmJKdhzEQ58bIYzo=.8fda3124-15d2-4183-980c-1858c876cf4c@github.com>
Message-ID: <KGOeLKX-1czzmgKKTGQhUn4fBglmwsodtfe9y2VFJBk=.f97f1a77-6fa7-4ce0-80e2-6e287045c4ef@github.com>

On Sat, 19 Mar 2022 19:51:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding Jeff's new duke to the release notes - Jeff will add it later to jmc-graphics
>
> releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 75:
> 
>> 73: 			<title>Heat map view</title>
>> 74: 			<description>
>> 75: 				A new heat map view has been added, which is handed to
> 
> Not sure if "handed" is the right word to use here?

"used"?

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Sun Mar 20 03:24:15 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 20 Mar 2022 03:24:15 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v3]
In-Reply-To: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
Message-ID: <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>

> Run the Transform class to generate the html.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixing issues

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/389/files
  - new: https://git.openjdk.java.net/jmc/pull/389/files/0b984fd5..658f63da

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=01-02

  Stats: 26 lines in 1 file changed: 12 ins; 12 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/389.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/389/head:pull/389

PR: https://git.openjdk.java.net/jmc/pull/389

From jpbempel at openjdk.java.net  Sun Mar 20 09:07:29 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Sun, 20 Mar 2022 09:07:29 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v3]
In-Reply-To: <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
Message-ID: <iPSwBuN8WJ4ZF_g4orW138p8tayO-1NyXB31eCPw-v4=.34a1f52e-f756-476c-8b65-8d788a0e079b@github.com>

On Sun, 20 Mar 2022 03:24:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Run the Transform class to generate the html.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing issues

@thegreystone, I am not sure why you have included the images `parserperf.png` related to parser performances. Those images seem not included in the release note, and that's good because it was fixed in 8.1 anyway.
I missed something?

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Sun Mar 20 17:34:09 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 20 Mar 2022 17:34:09 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v4]
In-Reply-To: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
Message-ID: <LuyHByMKvcdnqhLwEXfMw0wI6PPrpVNdmLrWdtZIMts=.9805b9a1-a111-4bcd-9eca-70ba58b78900@github.com>

> Run the Transform class to generate the html.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Removing unnecessary pictures

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/389/files
  - new: https://git.openjdk.java.net/jmc/pull/389/files/658f63da..b5c4970d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=02-03

  Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/389.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/389/head:pull/389

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Sun Mar 20 17:34:10 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 20 Mar 2022 17:34:10 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v3]
In-Reply-To: <iPSwBuN8WJ4ZF_g4orW138p8tayO-1NyXB31eCPw-v4=.34a1f52e-f756-476c-8b65-8d788a0e079b@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
 <iPSwBuN8WJ4ZF_g4orW138p8tayO-1NyXB31eCPw-v4=.34a1f52e-f756-476c-8b65-8d788a0e079b@github.com>
Message-ID: <Crp2SGdJUKRgmSPWw6pr60zMDohIQiQK0Z4aNjbnCbk=.d6fb7b5a-5a30-49e5-a9dd-80ec4c0caf29@github.com>

On Sun, 20 Mar 2022 09:04:05 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> @thegreystone, I am not sure why you have included the images `parserperf.png` related to parser performances. Those images seem not included in the release note, and that's good because it was fixed in 8.1 anyway. I missed something?

Copy paste error. Fixed! Thanks!

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Sun Mar 20 17:34:12 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Sun, 20 Mar 2022 17:34:12 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v3]
In-Reply-To: <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
Message-ID: <UE3Yk1hQ3Utw2aWXeuU3_CnXv7fwebBMO38x-tW65iE=.01455e7c-a8de-48fd-879b-6e5541f6fcc3@github.com>

On Sun, 20 Mar 2022 03:24:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Run the Transform class to generate the html.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing issues

@viragpurnam - do you see anything that should be added?

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From duke at openjdk.java.net  Sun Mar 20 17:55:51 2022
From: duke at openjdk.java.net (duke)
Date: Sun, 20 Mar 2022 17:55:51 GMT
Subject: git: openjdk/jmc: Added tag 8.2.0-ga for changeset 66f32188
Message-ID: <ab71e691-e84e-4a8f-a569-4191c98419ed@openjdk.java.net>

Tagged by: thegreystone <marcus at hirt.se>
Date:      2022-03-20 18:55:18 +0000

GA source release for JMC 8.2.0
Changeset: 66f32188
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
Committer: Marcus Hirt <marcus at hirt.se>
Date:      2022-03-07 16:26:42 +0000
URL:       https://git.openjdk.java.net/jmc/commit/66f321886da89fe4cc54a7e8d978b22fb65519ca


From aptmac at openjdk.java.net  Mon Mar 21 18:46:41 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 21 Mar 2022 18:46:41 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v4]
In-Reply-To: <LuyHByMKvcdnqhLwEXfMw0wI6PPrpVNdmLrWdtZIMts=.9805b9a1-a111-4bcd-9eca-70ba58b78900@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <LuyHByMKvcdnqhLwEXfMw0wI6PPrpVNdmLrWdtZIMts=.9805b9a1-a111-4bcd-9eca-70ba58b78900@github.com>
Message-ID: <sZ1TNm1WKCggBdMTtFF8V5OdnteCfyd4XuRiJ7VirmM=.071dc78d-0032-4fb3-a652-3a930172b006@github.com>

On Sun, 20 Mar 2022 17:34:09 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Run the Transform class to generate the html.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removing unnecessary pictures

releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 10:

> 8: 			<title>JMC 8.2 - New Release!</title>
> 9: 			<description>
> 10: 				This is a new minor release of Java Mission Control. The

Should this be "JDK Mission Control" instead of "Java Mission Control"? At least on the GitHub open source notes.

releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 22:

> 20: 			<description>
> 21: 				The Mission Control client is now built to run optimally
> 22: 				on Eclipse 2021-06 and later. To install Java Mission Control into

s/Java Mission Control/JDK Mission Control ?

releng/tools/org.openjdk.jmc.util.releasenotes/notes/8.2/notes.xml line 173:

> 171: 			</synopsis>
> 172: 			<description>
> 173: 				This is due to a bug with the Windows based browser

While I guess it looks like a bug on our side, this is caused by an intentional implementation detail in how the Chromium URLs work iirc.

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From duke at openjdk.java.net  Mon Mar 21 18:55:39 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Mon, 21 Mar 2022 18:55:39 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v3]
In-Reply-To: <UE3Yk1hQ3Utw2aWXeuU3_CnXv7fwebBMO38x-tW65iE=.01455e7c-a8de-48fd-879b-6e5541f6fcc3@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <OQ8It-a0G7T9jkvWaw9dsbYMsKgG61buUxW7BuekAa4=.666bd377-6ad0-4986-92ab-a1a9d4ebaba4@github.com>
 <UE3Yk1hQ3Utw2aWXeuU3_CnXv7fwebBMO38x-tW65iE=.01455e7c-a8de-48fd-879b-6e5541f6fcc3@github.com>
Message-ID: <wsAUXM_udlNQ493RhDrd91gclA0I2jKYPkwZ7kvaaNg=.5f83bac3-3c14-41c8-9802-ae8e032c8920@github.com>

On Sun, 20 Mar 2022 17:31:21 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> @viragpurnam - do you see anything that should be added?

Hi @thegreystone, Looks good to me.

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From hirt at openjdk.java.net  Mon Mar 21 19:00:07 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Mar 2022 19:00:07 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v5]
In-Reply-To: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
Message-ID: <kF_T8pvlVBGl8WGt7pHDcd1o3kmfgPsfbpO_yKGqW1k=.06ab4cd5-a781-4f8b-9469-f13182862f44@github.com>

> Run the Transform class to generate the html.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Fixes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/389/files
  - new: https://git.openjdk.java.net/jmc/pull/389/files/b5c4970d..1733d045

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=389&range=03-04

  Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod
  Patch: https://git.openjdk.java.net/jmc/pull/389.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/389/head:pull/389

PR: https://git.openjdk.java.net/jmc/pull/389

From aptmac at openjdk.java.net  Mon Mar 21 19:05:33 2022
From: aptmac at openjdk.java.net (Alex Macdonald)
Date: Mon, 21 Mar 2022 19:05:33 GMT
Subject: RFR: 7573: Release notes for 8.2.0 [v5]
In-Reply-To: <kF_T8pvlVBGl8WGt7pHDcd1o3kmfgPsfbpO_yKGqW1k=.06ab4cd5-a781-4f8b-9469-f13182862f44@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
 <kF_T8pvlVBGl8WGt7pHDcd1o3kmfgPsfbpO_yKGqW1k=.06ab4cd5-a781-4f8b-9469-f13182862f44@github.com>
Message-ID: <bJORLqlEvs419s8l8b0xWWfJn0h6GJQFm3DQjDN9hIc=.4806389b-2793-48e3-b264-02d48e24a016@github.com>

On Mon, 21 Mar 2022 19:00:07 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Run the Transform class to generate the html.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes

Marked as reviewed by aptmac (Reviewer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From jeff at openjdk.java.net  Mon Mar 21 20:09:04 2022
From: jeff at openjdk.java.net (Jeff Dinkins)
Date: Mon, 21 Mar 2022 20:09:04 GMT
Subject: [jmc-graphics] RFR: 7574: Image for no System.gc release note
Message-ID: <m7OlVW21eRgsb7zXsgW0jMXf1b5Y2952JF5pmnmmvwM=.5dcc9e29-1c95-4500-8c71-abed7ecd8863@github.com>

JMC-7574: Adding duke no-gc artwork

-------------

Commit messages:
 - Create duke-no-gc.png

Changes: https://git.openjdk.java.net/jmc-graphics/pull/8/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc-graphics&pr=8&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7574
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc-graphics/pull/8.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc-graphics pull/8/head:pull/8

PR: https://git.openjdk.java.net/jmc-graphics/pull/8

From hirt at openjdk.java.net  Mon Mar 21 20:09:05 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Mar 2022 20:09:05 GMT
Subject: [jmc-graphics] RFR: 7574: Image for no System.gc release note
In-Reply-To: <m7OlVW21eRgsb7zXsgW0jMXf1b5Y2952JF5pmnmmvwM=.5dcc9e29-1c95-4500-8c71-abed7ecd8863@github.com>
References: <m7OlVW21eRgsb7zXsgW0jMXf1b5Y2952JF5pmnmmvwM=.5dcc9e29-1c95-4500-8c71-abed7ecd8863@github.com>
Message-ID: <OGwRas6jr05xHOhv3NSTl9v4d6b92Hyt8xNJ42-lfxw=.9e84a2f6-017e-47da-9521-0ec9e1151d5a@github.com>

On Mon, 21 Mar 2022 20:00:38 GMT, Jeff Dinkins <jeff at openjdk.org> wrote:

> JMC-7574: Adding duke no-gc artwork

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.java.net/jmc-graphics/pull/8

From jeff at openjdk.java.net  Mon Mar 21 20:14:36 2022
From: jeff at openjdk.java.net (Jeff Dinkins)
Date: Mon, 21 Mar 2022 20:14:36 GMT
Subject: [jmc-graphics] Integrated: 7574: Image for no System.gc release note
In-Reply-To: <m7OlVW21eRgsb7zXsgW0jMXf1b5Y2952JF5pmnmmvwM=.5dcc9e29-1c95-4500-8c71-abed7ecd8863@github.com>
References: <m7OlVW21eRgsb7zXsgW0jMXf1b5Y2952JF5pmnmmvwM=.5dcc9e29-1c95-4500-8c71-abed7ecd8863@github.com>
Message-ID: <1Q9zuQHmPEPU0IU1HDLOb4VA1cY5z6QPUkV7GYQY8Vw=.27eace0f-8686-499d-ad73-8fc5b1201d37@github.com>

On Mon, 21 Mar 2022 20:00:38 GMT, Jeff Dinkins <jeff at openjdk.org> wrote:

> JMC-7574: Adding duke no-gc artwork

This pull request has now been integrated.

Changeset: 6f9f5497
Author:    Jeff Dinkins <jeff at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc-graphics/commit/6f9f54970490015f94014e46a92775799863b6af
Stats:     0 lines in 1 file changed: 0 ins; 0 del; 0 mod

7574: Image for no System.gc release note

Reviewed-by: hirt

-------------

PR: https://git.openjdk.java.net/jmc-graphics/pull/8

From hirt at openjdk.java.net  Mon Mar 21 20:28:32 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Mon, 21 Mar 2022 20:28:32 GMT
Subject: Integrated: 7573: Release notes for 8.2.0
In-Reply-To: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
References: <Kup8jaF4gtVf371H_8fz--Lrmsqb5FEdNsmLErPAZo0=.8a24a78b-2b94-40df-8318-742c42c50069@github.com>
Message-ID: <w1Lr5pEYp6fxvnGyh60dMxEDK98NmCu_iMCJ1JuPguM=.d3bff1d2-1c7b-4a7b-8a17-a15e8ef2a84d@github.com>

On Fri, 18 Mar 2022 22:24:21 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Run the Transform class to generate the html.

This pull request has now been integrated.

Changeset: e43746c1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.java.net/jmc/commit/e43746c1546527223b27c37a85cdb3e1e719b80c
Stats:     183 lines in 20 files changed: 179 ins; 0 del; 4 mod

7573: Release notes for 8.2.0

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.java.net/jmc/pull/389

From duke at openjdk.java.net  Wed Mar 23 18:38:49 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Wed, 23 Mar 2022 18:38:49 GMT
Subject: RFR: 6972: Naming and Version Numbering Issues with Plugins
Message-ID: <RQZ_buL6zOTIBJMoOBWSvN9vUwuJDTlRk5TOLPOD5vY=.12ebf4bc-16d8-4f50-a595-c717eeeb48c1@github.com>

**Issue:** As for core plugins, maven tycho is not used, '.qualifier' is not getting replaced with the build time stamp. 
Plug-in details in JMC shows 8.3.0.qualifier.
<img width="597" alt="BundleVersionIssue" src="https://user-images.githubusercontent.com/97600378/159768661-e4928c03-e986-4a83-9886-51f27a026605.png">

**Solution:** Manifest file needs to be updated. '.qualifier' can be removed from the manifest file. (Only for the core plugins.) 
e.g Bundle-Version: 8.3.0.qualifier  to Bundle-Version: 8.3.0
With the above change Plug-in details in JMC shows 8.3.0.
<img width="591" alt="BundleVersionIssueResolved" src="https://user-images.githubusercontent.com/97600378/159768955-32ee9cae-2fdd-4c19-90ad-a4767b2b5364.png">

**Issue:** Bundle names are not uniform.
<img width="594" alt="JOverFlowBundleNameIssue" src="https://user-images.githubusercontent.com/97600378/159769336-d08fe913-af2b-489f-8980-162f31620ea2.png">

Duplicate bundle name.
<img width="686" alt="DuplicateBundleName" src="https://user-images.githubusercontent.com/97600378/159769670-2507094e-2379-4b89-8350-b8b34d70154d.png">

**Solution:** Below mentioned Bundle-Name needs to be modified to make it uniform.

- _Joverflow_ to _JOverFlow Plug-in_  for  org.openjdk.jmc.joverflow
- _JOverFlow Plugin_ to _JOverFlow UI Plug-in_ for org.openjdk.jmc.joverflow.ui
- _Greychart UI Plug-in_ to _GreyChart UI Plug-in_  for org.openjdk.jmc.greychart.ui
- _Flightrecorder Plug-in_ to _Flight Recorder UI Plug-in_ for org.openjdk.jmc.flightrecorder.ui
- _Common Plug-in_ to  _Flight Recorder Serializers Plug-in_ for org.openjdk.jmc.flightrecorder.serializers
- _Mission Control Flight Recorder Rules_ to _Mission Control Flight Recorder Rules JDK_ for org.openjdk.jmc.flightrecorder.rules.jdk
- _Mission Control Flight Recorder Writer_ to _Mission Control Flight Recorder Writer Test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin)
- _Flight Recorder Test_ to _Flight Recorder Rules Test_ for org.openjdk.jmc.flightrecorder.rules.test
- _Flight Recorder Test_ to _Flight Recorder Rules JDK Test_ for org.openjdk.jmc.flightrecorder.rules.jdk.test

<img width="593" alt="JOverFlowBundleNameIssueResolved" src="https://user-images.githubusercontent.com/97600378/159770397-d063a268-db9d-45dc-80d7-06c8b2237256.png">
<img width="682" alt="DuplicateBundleNameResolved" src="https://user-images.githubusercontent.com/97600378/159770398-1a0eb6e9-ab9e-4af5-9641-c3055f3222f4.png">

**Issue:** Duplicate Bundle-SymbolicName

**Solution:**  Bundle-SymbolicName has been modified
_org.openjdk.jmc.flightrecorder.writer_ to _org.openjdk.jmc.flightrecorder.writer.test_ for org.openjdk.jmc.flightrecorder.writer (Test Plugin)

-------------

Commit messages:
 - 6972: Naming and Version Numbering Issues with Plugins

Changes: https://git.openjdk.java.net/jmc/pull/390/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=390&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-6972
  Stats: 25 lines in 19 files changed: 0 ins; 0 del; 25 mod
  Patch: https://git.openjdk.java.net/jmc/pull/390.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/390/head:pull/390

PR: https://git.openjdk.java.net/jmc/pull/390

From xxinliu at amazon.com  Mon Mar 28 06:37:19 2022
From: xxinliu at amazon.com (Liu, Xin)
Date: Sun, 27 Mar 2022 23:37:19 -0700
Subject: support IUnit of Allocation Rate
Message-ID: <2f5b073f-6431-d249-e946-be2b66b9828c@amazon.com>

Hi, Developers,

I am new for the codebase of Java mission control. I would like to add
allocation Rate in Summary page(JMC-7301).

I manage to extend aggregators ALLOC_INSIDE_TLAB_SUM and
ALLOC_OUTSIDE_TLAB_SUM. The duration is known from TlabPage::visibleRange.

The biggest challenge is to align with the new unit. IUnit of Allocation
Rate is B/s. I haven't found similar IUnit like that. Is there a way to
derive B/s from Memory?

To display the correct unit of allocation rate, I create a new
LinearKindOfQuantity "memory bandwidth". The only difference of it from
memory is that its atom unit is B/s.

Here is my attempt. sorry it looks awful. Any suggest to make it more
elegant?

https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793


thanks,
--lx






From marcus.hirt at datadoghq.com  Mon Mar 28 12:19:15 2022
From: marcus.hirt at datadoghq.com (Marcus Hirt)
Date: Mon, 28 Mar 2022 14:19:15 +0200
Subject: support IUnit of Allocation Rate
In-Reply-To: <2f5b073f-6431-d249-e946-be2b66b9828c@amazon.com>
References: <2f5b073f-6431-d249-e946-be2b66b9828c@amazon.com>
Message-ID: <CAOpWGx1R2jvR89e1REBnvDGVyrPn915EHhbTHV2C_2CPfoUY6g@mail.gmail.com>

Hi Xin Liu,

Fixing this properly is probably a bit bigger. We'd probably want to have a
compound unit and add support for compound units in a general way.

Kind regards,
Marcus

On Mon, Mar 28, 2022 at 8:37 AM Liu, Xin <xxinliu at amazon.com> wrote:

> Hi, Developers,
>
> I am new for the codebase of Java mission control. I would like to add
> allocation Rate in Summary page(JMC-7301).
>
> I manage to extend aggregators ALLOC_INSIDE_TLAB_SUM and
> ALLOC_OUTSIDE_TLAB_SUM. The duration is known from TlabPage::visibleRange.
>
> The biggest challenge is to align with the new unit. IUnit of Allocation
> Rate is B/s. I haven't found similar IUnit like that. Is there a way to
> derive B/s from Memory?
>
> To display the correct unit of allocation rate, I create a new
> LinearKindOfQuantity "memory bandwidth". The only difference of it from
> memory is that its atom unit is B/s.
>
> Here is my attempt. sorry it looks awful. Any suggest to make it more
> elegant?
>
>
> https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793
>
>
> thanks,
> --lx
>
>
>
>
>
>

From xxinliu at amazon.com  Mon Mar 28 23:36:54 2022
From: xxinliu at amazon.com (Liu, Xin)
Date: Mon, 28 Mar 2022 16:36:54 -0700
Subject: support IUnit of Allocation Rate
In-Reply-To: <CAOpWGx1R2jvR89e1REBnvDGVyrPn915EHhbTHV2C_2CPfoUY6g@mail.gmail.com>
References: <2f5b073f-6431-d249-e946-be2b66b9828c@amazon.com>
 <CAOpWGx1R2jvR89e1REBnvDGVyrPn915EHhbTHV2C_2CPfoUY6g@mail.gmail.com>
Message-ID: <1f891868-4cea-8f71-7068-bf3fe6df9c75@amazon.com>

hi, Marcus,

Yes, I am looking for a general approach to combine two units and get a
compound unit. Is there any other scenarios besides B/s.

Or we treat B/s as a special case. I look up wikipedia, maybe it's not
an appalling hack to create a unit called "data-rate"
https://en.wikipedia.org/wiki/Data-rate_units. It has a clear
definition, symbol and scales.

I plan to create a map in UnitLookup. it maps MEMORY to MEMORY/s. does
it sound reasonable?

thanks,
--lx

On 3/28/22 5:19 AM, Marcus Hirt wrote:
> *CAUTION*: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender
> and know the content is safe.
> 
> 
> Hi?Xin Liu,
> 
> Fixing this properly is probably a bit bigger. We'd probably want to
> have a compound unit and add support for compound?units in a general way.
> 
> Kind regards,
> Marcus
> 
> On Mon, Mar 28, 2022 at 8:37 AM Liu, Xin <xxinliu at amazon.com
> <mailto:xxinliu at amazon.com>> wrote:
> 
>     Hi, Developers,
> 
>     I am new for the codebase of Java mission control. I would like to add
>     allocation Rate in Summary page(JMC-7301).
> 
>     I manage to extend aggregators ALLOC_INSIDE_TLAB_SUM and
>     ALLOC_OUTSIDE_TLAB_SUM. The duration is known from
>     TlabPage::visibleRange.
> 
>     The biggest challenge is to align with the new unit. IUnit of Allocation
>     Rate is B/s. I haven't found similar IUnit like that. Is there a way to
>     derive B/s from Memory?
> 
>     To display the correct unit of allocation rate, I create a new
>     LinearKindOfQuantity "memory bandwidth". The only difference of it from
>     memory is that its atom unit is B/s.
> 
>     Here is my attempt. sorry it looks awful. Any suggest to make it more
>     elegant?
> 
>     https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793
>     <https://github.com/navyxliu/jmc/commit/b3cd19b1b6bb5cb93241b4dbb8086a6305fe4023#diff-d740b28fe16b17f85bf34790e5afc60eb0d2f39d7827f894184713430d74131bR793>
> 
> 
>     thanks,
>     --lx
> 
> 
> 
> 
> 

From jpbempel at openjdk.java.net  Tue Mar 29 20:12:24 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 29 Mar 2022 20:12:24 GMT
Subject: RFR: 7508: Use preferred way for test-jars
Message-ID: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>

based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
I have modified the way test jars are structured:
we put all classes in src/main/java instead of src/test/java
and changed scope from test to compile accordingly
we now don't need to create explicitly test-jar neither reference them
as is.
Help to build/run/debug correctly in Intellij

-------------

Commit messages:
 - add resources source folder for common.test
 - update .classpath
 - update build.properties
 - use preferred way for test-jars

Changes: https://git.openjdk.java.net/jmc/pull/354/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=354&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7508
  Stats: 119 lines in 166 files changed: 1 ins; 78 del; 40 mod
  Patch: https://git.openjdk.java.net/jmc/pull/354.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/354/head:pull/354

PR: https://git.openjdk.java.net/jmc/pull/354

From duke at openjdk.java.net  Tue Mar 29 20:12:24 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 29 Mar 2022 20:12:24 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
Message-ID: <j84uZnGf86rYbWXjTzfALA6PqlLn778UVUztyN8l03E=.ef020ed7-eb42-49d2-ae4e-139c47c29682@github.com>

On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
> I have modified the way test jars are structured:
> we put all classes in src/main/java instead of src/test/java
> and changed scope from test to compile accordingly
> we now don't need to create explicitly test-jar neither reference them
> as is.
> Help to build/run/debug correctly in Intellij

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

Tested during the R&D week.

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From reinhapa at openjdk.java.net  Tue Mar 29 20:12:25 2022
From: reinhapa at openjdk.java.net (Patrick Reinhart)
Date: Tue, 29 Mar 2022 20:12:25 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
Message-ID: <8gKPVrbpZHsnXEgBb12wKKcvsKinfdn2dgzSxeMqQPQ=.ffc3056c-c0e1-4bdf-ba36-b01f7393e6b4@github.com>

On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
> I have modified the way test jars are structured:
> we put all classes in src/main/java instead of src/test/java
> and changed scope from test to compile accordingly
> we now don't need to create explicitly test-jar neither reference them
> as is.
> Help to build/run/debug correctly in Intellij

@jpbempel just for my understanding: do those test projects solely contain classes used as kind of test fixtures?

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From duke at openjdk.java.net  Tue Mar 29 20:12:26 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 29 Mar 2022 20:12:26 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <8gKPVrbpZHsnXEgBb12wKKcvsKinfdn2dgzSxeMqQPQ=.ffc3056c-c0e1-4bdf-ba36-b01f7393e6b4@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
 <8gKPVrbpZHsnXEgBb12wKKcvsKinfdn2dgzSxeMqQPQ=.ffc3056c-c0e1-4bdf-ba36-b01f7393e6b4@github.com>
Message-ID: <rXTrrArEHoBqFvLIynDYJoNyRqBJMysVp5seZyKk0W4=.740d451d-f93b-4d1c-863e-9d1400aacfbb@github.com>

On Thu, 13 Jan 2022 13:54:47 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

>> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
>> I have modified the way test jars are structured:
>> we put all classes in src/main/java instead of src/test/java
>> and changed scope from test to compile accordingly
>> we now don't need to create explicitly test-jar neither reference them
>> as is.
>> Help to build/run/debug correctly in Intellij
>
> @jpbempel just for my understanding: do those test projects solely contain classes used as kind of test fixtures?

@reinhapa Yes these jar only contains tests or test _tools_. With this change opening and developing the core libraries in IJ got significantly easier and faster

![image](https://user-images.githubusercontent.com/803621/149349808-bcaa8d8e-7fc3-4cec-a450-e61ec5b1fb80.png)


And in Eclipse 

![image](https://user-images.githubusercontent.com/803621/149350606-889a5a96-680f-49eb-8a7e-a36b9d58d971.png)

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From hirt at openjdk.java.net  Tue Mar 29 20:12:26 2022
From: hirt at openjdk.java.net (Marcus Hirt)
Date: Tue, 29 Mar 2022 20:12:26 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
Message-ID: <OSdvjAWslgyQQoUuUeb6KJdMtfeOFIYfVMq8pFBADBA=.53da4ec3-ba32-4150-bd17-03c81e59767f@github.com>

On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
> I have modified the way test jars are structured:
> we put all classes in src/main/java instead of src/test/java
> and changed scope from test to compile accordingly
> we now don't need to create explicitly test-jar neither reference them
> as is.
> Help to build/run/debug correctly in Intellij

Already doing these, i.e. fixing project files, in a separate PR. See #355.

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From jpbempel at openjdk.java.net  Tue Mar 29 20:12:27 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Tue, 29 Mar 2022 20:12:27 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <OSdvjAWslgyQQoUuUeb6KJdMtfeOFIYfVMq8pFBADBA=.53da4ec3-ba32-4150-bd17-03c81e59767f@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
 <OSdvjAWslgyQQoUuUeb6KJdMtfeOFIYfVMq8pFBADBA=.53da4ec3-ba32-4150-bd17-03c81e59767f@github.com>
Message-ID: <cpuD6vigPBc22GLq5KfWk5f1dDDlPWoNRHDI5nreaOs=.1273132f-1911-4507-93ac-81491551c276@github.com>

On Thu, 13 Jan 2022 15:24:56 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Already doing these, i.e. fixing project files, in a separate PR. See #355.

ok removing the .project files then

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From duke at openjdk.java.net  Tue Mar 29 20:12:27 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Tue, 29 Mar 2022 20:12:27 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <OSdvjAWslgyQQoUuUeb6KJdMtfeOFIYfVMq8pFBADBA=.53da4ec3-ba32-4150-bd17-03c81e59767f@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
 <OSdvjAWslgyQQoUuUeb6KJdMtfeOFIYfVMq8pFBADBA=.53da4ec3-ba32-4150-bd17-03c81e59767f@github.com>
Message-ID: <rEwu5pZ569mFh7N4mE4kYuXdl_T1cS_IBdh728lbtEQ=.2e15b28d-c423-4c1f-b22b-6a33f94d9115@github.com>

On Thu, 13 Jan 2022 15:24:56 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
>> I have modified the way test jars are structured:
>> we put all classes in src/main/java instead of src/test/java
>> and changed scope from test to compile accordingly
>> we now don't need to create explicitly test-jar neither reference them
>> as is.
>> Help to build/run/debug correctly in Intellij
>
> Already doing these, i.e. fixing project files, in a separate PR. See #355.

@thegreystone There is however a change in the declaration of the maven projects see : 502313d

This PR may have to be rebased over #355

-------------

PR: https://git.openjdk.java.net/jmc/pull/354

From xliu at openjdk.java.net  Wed Mar 30 01:57:12 2022
From: xliu at openjdk.java.net (Xin Liu)
Date: Wed, 30 Mar 2022 01:57:12 GMT
Subject: RFR: 7301: Add allocation rate aggregators to TLAB Allocation General
 screen
Message-ID: <r_oJzUu-wnl3duJISjnLLyKoHDOLfoHYiyDnOHt7MFk=.64b5bbc3-63cd-4997-801c-66fcf0d269aa@github.com>

7301: Add allocation rate aggregators to TLAB Allocation General screen

-------------

Commit messages:
 - add a map from MEMORY to MemoryBandwidth.
 - 7301: Add allocation rate aggregators to TLAB Allocation General screen

Changes: https://git.openjdk.java.net/jmc/pull/391/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=391&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7301
  Stats: 79 lines in 6 files changed: 79 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jmc/pull/391.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/391/head:pull/391

PR: https://git.openjdk.java.net/jmc/pull/391

From xliu at openjdk.java.net  Wed Mar 30 02:18:32 2022
From: xliu at openjdk.java.net (Xin Liu)
Date: Wed, 30 Mar 2022 02:18:32 GMT
Subject: RFR: 7301: Add allocation rate aggregators to TLAB Allocation
 General screen [v2]
In-Reply-To: <r_oJzUu-wnl3duJISjnLLyKoHDOLfoHYiyDnOHt7MFk=.64b5bbc3-63cd-4997-801c-66fcf0d269aa@github.com>
References: <r_oJzUu-wnl3duJISjnLLyKoHDOLfoHYiyDnOHt7MFk=.64b5bbc3-63cd-4997-801c-66fcf0d269aa@github.com>
Message-ID: <zRHxo4o7_oGKdeeLletz_iMQtn90-lBPMOyrVpgC9bo=.2e960c5d-7995-4777-86b1-847a1a42ddc3@github.com>

> Add allocation rate aggregators to TLAB Allocation General screen: 
> 1.  Allocation rate for TLABs (inside of TLAB)
> 2. Allocation rate for Objects (outside of TLAB)
> 
> There are 2 extra locales(Chinese and Japanese) besides English.  I am not sure I am qualified to provide translation. If it is possible, I will add them in next revision.

Xin Liu has updated the pull request incrementally with one additional commit since the last revision:

  run 'mvn spotless:apply' (hint given by GHA).

-------------

Changes:
  - all: https://git.openjdk.java.net/jmc/pull/391/files
  - new: https://git.openjdk.java.net/jmc/pull/391/files/0c6abfd9..894bfa4d

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmc&pr=391&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmc&pr=391&range=00-01

  Stats: 11 lines in 2 files changed: 5 ins; 3 del; 3 mod
  Patch: https://git.openjdk.java.net/jmc/pull/391.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/391/head:pull/391

PR: https://git.openjdk.java.net/jmc/pull/391

From duke at openjdk.java.net  Wed Mar 30 11:19:53 2022
From: duke at openjdk.java.net (Brice Dutheil)
Date: Wed, 30 Mar 2022 11:19:53 GMT
Subject: RFR: 7508: Use preferred way for test-jars
In-Reply-To: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
References: <QuQHHDP2FppCUw3i-31Lpk8rHUo8b0HtcY0pJ6z0KJU=.a16e5ba5-c67c-4e9d-9045-23c7017f5ad4@github.com>
Message-ID: <ACcnuv9-UXifpPC4QK7FR8WzdVma0lC9EPA5KSlbHrM=.9d0a1ad7-dacb-4a6a-b398-6709ed5904ee@github.com>

On Thu, 13 Jan 2022 11:04:00 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> based on https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html
> I have modified the way test jars are structured:
> we put all classes in src/main/java instead of src/test/java
> and changed scope from test to compile accordingly
> we now don't need to create explicitly test-jar neither reference them
> as is.
> Help to build/run/debug correctly in Intellij

As a reminder this was done during the january R&D week

-------------

Marked as reviewed by bric3 at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jmc/pull/354

From duke at openjdk.java.net  Wed Mar 30 23:32:07 2022
From: duke at openjdk.java.net (Austin Brooks)
Date: Wed, 30 Mar 2022 23:32:07 GMT
Subject: RFR: 7576: Remove the need for a local jetty server for dependencies
Message-ID: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>

Using newer Tycho features to achieve result:

Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations
Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets

Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions

-------------

Commit messages:
 - Remove references to third-party from scripts/
 - Fix clean target trying to access third-party directory
 - XXX: Remove needing to use a local jetty server for dependencies

Changes: https://git.openjdk.java.net/jmc/pull/387/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=387&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7576
  Stats: 481 lines in 12 files changed: 130 ins; 346 del; 5 mod
  Patch: https://git.openjdk.java.net/jmc/pull/387.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/387/head:pull/387

PR: https://git.openjdk.java.net/jmc/pull/387

From duke at openjdk.java.net  Wed Mar 30 23:32:09 2022
From: duke at openjdk.java.net (Austin Brooks)
Date: Wed, 30 Mar 2022 23:32:09 GMT
Subject: RFR: 7576: Remove the need for a local jetty server for
 dependencies
In-Reply-To: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>
References: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>
Message-ID: <RwzTq4RA5IntIXmbU0KTPQ-dib-6ZwLD9h8avOFtIqc=.0947592f-8bd2-4857-b32e-fda917ecbf71@github.com>

On Fri, 18 Mar 2022 21:33:49 GMT, Austin Brooks <duke at openjdk.java.net> wrote:

> Using newer Tycho features to achieve result:
> 
> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations
> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets
> 
> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions

releng/platform-definitions/third-party.target line 121:

> 119: Bundle-Name:           Bundle derived from maven artifact ${mvnGroupId}:${mvnArtifactId}:${mvnVersion}
> 120: Import-Package:        *;resolution:=optional
> 121: Export-Package:        *

These are different than the standard Tycho defaults, but match what was in use by the old maven plugin:  https://github.com/reficio/p2-maven-plugin#default-options

-------------

PR: https://git.openjdk.java.net/jmc/pull/387

From duke at openjdk.java.net  Thu Mar 31 19:10:02 2022
From: duke at openjdk.java.net (Virag Purnam)
Date: Thu, 31 Mar 2022 19:10:02 GMT
Subject: RFR: 7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins
 launcher
Message-ID: <osoDvLub5O_aF7mx5nMTcDmlHYtAJg-k-AXL0XX4qA0=.2a1703b4-33d1-484b-83d0-4136e9fbeb2f@github.com>

Below mentioned required plugins are missing in JMC-RCP and JMC-RCP-plug-ins launcher. Added them as an additional plugins.
org.eclipse.jetty.http (10.0.7)
org.eclipse.jetty.io (10.0.7)
org.eclipse.jetty.security (10.0.7)
org.eclipse.jetty.server (10.0.7)
org.eclipse.jetty.servlet (10.0.7)
org.eclipse.jetty.util (10.0.7)

![MissingRequiredPlugins](https://user-images.githubusercontent.com/97600378/161130307-0e56892a-b435-4db6-bf50-2b9fc121a2db.png)

-------------

Commit messages:
 - 7581: Missing required plugins in JMC-RCP and JMC-RCP-plug-ins launcher

Changes: https://git.openjdk.java.net/jmc/pull/393/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jmc&pr=393&range=00
  Issue: https://bugs.openjdk.java.net/browse/JMC-7581
  Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jmc/pull/393.diff
  Fetch: git fetch https://git.openjdk.java.net/jmc pull/393/head:pull/393

PR: https://git.openjdk.java.net/jmc/pull/393

From jpbempel at openjdk.java.net  Thu Mar 31 19:39:42 2022
From: jpbempel at openjdk.java.net (Jean-Philippe Bempel)
Date: Thu, 31 Mar 2022 19:39:42 GMT
Subject: RFR: 7581: Missing required plugins in JMC-RCP and
 JMC-RCP-plug-ins launcher
In-Reply-To: <osoDvLub5O_aF7mx5nMTcDmlHYtAJg-k-AXL0XX4qA0=.2a1703b4-33d1-484b-83d0-4136e9fbeb2f@github.com>
References: <osoDvLub5O_aF7mx5nMTcDmlHYtAJg-k-AXL0XX4qA0=.2a1703b4-33d1-484b-83d0-4136e9fbeb2f@github.com>
Message-ID: <sNeBFTG9DfKawQs0eeG5m2p3ZlcA2QmnkJOIB8CTPus=.5859dafd-3a5c-4c81-b2dc-2c50ef06ab7f@github.com>

On Thu, 31 Mar 2022 19:04:43 GMT, Virag Purnam <duke at openjdk.java.net> wrote:

> Below mentioned required plugins are missing in JMC-RCP and JMC-RCP-plug-ins launcher. Added them as an additional plugins.
> org.eclipse.jetty.http (10.0.7)
> org.eclipse.jetty.io (10.0.7)
> org.eclipse.jetty.security (10.0.7)
> org.eclipse.jetty.server (10.0.7)
> org.eclipse.jetty.servlet (10.0.7)
> org.eclipse.jetty.util (10.0.7)
> 
> ![MissingRequiredPlugins](https://user-images.githubusercontent.com/97600378/161130307-0e56892a-b435-4db6-bf50-2b9fc121a2db.png)

Marked as reviewed by jpbempel (Committer).

-------------

PR: https://git.openjdk.java.net/jmc/pull/393