RFR: 7455: Add support for jolokia JMX service connection [v12]

Martin Skarsaune duke at openjdk.java.net
Fri May 20 08:00:04 UTC 2022


On Fri, 14 Jan 2022 19:41:02 GMT, Martin Skarsaune <duke at openjdk.java.net> wrote:

>> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>> 
>>  - JMC-7455: Remaining OSGi cleanup
>>  - JMC-7455: Re-export jolokia JMX adapter for simplicity
>>  - JMC-7455: Use third party to pull inn Jolokia modules
>>  - Review corrections: Javadoc and refactoring attempt to use local operation info
>>  - Removed -XstartOnFirstThread as it is not valid for some JVMs
>>  - Used spotbugs to format more code
>>  - Used spotbugs to format according to convention
>>  - json.simple is needed by kubernetes plugin downstream
>>  - Adding test plugin for Jolokia
>>  - Revert unwanted change unrelated to new plugins
>>  - ... and 4 more: https://git.openjdk.java.net/jmc/compare/80fce51c...dc047f95
>
> application/tests/org.openjdk.jmc.jolokia.test/pom.xml line 86:
> 
>> 84: 			<plugin>
>> 85: 				<groupId>org.apache.maven.plugins</groupId>
>> 86: 				<artifactId>maven-dependency-plugin</artifactId>
> 
> Wondering whether I should do the same OSGi packaging solution with third party and platform definitions here. But is it ok to include test dependencies there as well, or should they be kept out of it?

https://jdkmissioncontrol.slack.com/archives/CGMRA4ALW/p1643685017130109

-------------

PR: https://git.openjdk.java.net/jmc/pull/332


More information about the jmc-dev mailing list