RFR: JMC-7798: Make the frame type extensible [v2]

Jaroslav Bachorik jbachorik at openjdk.java.net
Wed May 25 16:19:03 UTC 2022


On Thu, 19 May 2022 12:29:57 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo in javadoc
>
> Generally looks good, I have some suggestions.
> 
> Also, the copyright years need to be updated in all the files you touched.

@RealCLanger , thanks for the review.
I have pushed the changes you asked for.

> core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/internal/util/ParserToolkitTest.java line 1:
> 
>> 1: package org.openjdk.jmc.flightrecorder.test.internal.util;
> 
> This file needs a copyright header and it needs to be moved to src/main from src/test as the project structure has been modified a little lately with https://github.com/openjdk/jmc/commit/6aeee1375d8ea5739ba2a85675fb5e00f1eea9af

Ok. I moved it to the indicated location. However, this breaks the IDE integration for IntelliJ but you are probably aware of that.

-------------

PR: https://git.openjdk.java.net/jmc/pull/401


More information about the jmc-dev mailing list