RFR: JMC-7798: Make the frame type extensible [v3]
Christoph Langer
clanger at openjdk.java.net
Wed May 25 16:47:58 UTC 2022
On Wed, 25 May 2022 16:18:59 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> This change allows the JMC parser users to consume frames with the type set to non-standard values (eg. from async-profiler).
>>
>> The hard-wired enum approach is replaced with a hybrid solution keeping the standard types in enum-like structure and using a cache for the non-standard types. This allows being fairly flexible when dealing with new frame types while keeping full backward compatibility.
>
> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>
> Addressing review comments
Looks good from my end now. I however, have only reviewed it from a formal point of view. Probably somebody with some more knowledge of the usage of the parsing should give it a blessing.
-------------
Marked as reviewed by clanger (Author).
PR: https://git.openjdk.java.net/jmc/pull/401
More information about the jmc-dev
mailing list