RFR: JMC-7798: Make the frame type extensible [v4]

Jaroslav Bachorik jbachorik at openjdk.java.net
Tue May 31 09:31:55 UTC 2022


On Tue, 31 May 2022 09:18:19 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> core/tests/org.openjdk.jmc.flightrecorder.test/src/main/java/org/openjdk/jmc/flightrecorder/test/internal/util/ParserToolkitTest.java line 45:
>> 
>>> 43: 	public void testParseBuiltinFrameType() {
>>> 44: 		Assert.assertTrue(IMCFrame.Type.INTERPRETED == ParserToolkit.parseFrameType(ParserToolkit.INTERPRETED_TYPE_ID));
>>> 45: 		Assert.assertTrue(
>> 
>> Make one line out of L45 & L46? (Although the IDE probably did the line break...)
>
> Actually, I think this was done by spotless. I always run `mvn spotless:apply` but it seems like not all style nuances are captured in its rules.

Yep. Checked it. Spotless will do this change.

-------------

PR: https://git.openjdk.java.net/jmc/pull/401


More information about the jmc-dev mailing list