RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results.
Marcus Hirt
hirt at openjdk.org
Tue Oct 4 14:18:34 UTC 2022
On Mon, 29 Aug 2022 22:09:37 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:
>> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.
>
>> Is https://bugs.openjdk.org/browse/JMC-7879 a duplicate of https://bugs.openjdk.org/browse/JMC-7248?
>>
>> It looks like this PR is #248 with some of the review comments addressed, should the former PR be closed in favor of this?
>>
>> There are a couple of review comments that didn't receive any changes in this PR: https://github.com/openjdk/jmc/pull/248/files#r756349943 https://github.com/openjdk/jmc/pull/248/files#r756353644
>>
>> It looks like the consensus on #248 was that it was good enough to go in, maybe ping @bric3 and/or @Gunde for a re-review/approval?
>
> This PR is a superset of the previous one. The older one deals with only optimization of the class leak rule but this one deals with the optimization as well as the correction of the results shown on automated analysis page for class leak rule. I have implemented all the review comments given on the previous PR. With respect to the two comments mentioned above, the configured timeout is being fetched from preference hence I am finding it difficult to make it final. The interrupted exception handling is done where the method is called in catch block. I had already pinged about this issue in general slack channel and it was discussed in hangout also.
>
> @Gunde and @bric3 Request both of you to please take a look at this PR and let me know your review comments. Thanks in advance.
Hi @Suchitainf! When will you be able to fix the remaining issues?
-------------
PR: https://git.openjdk.org/jmc/pull/419
More information about the jmc-dev
mailing list