RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results.

[Suchita Chaturvedi]

On Wed, 5 Oct 2022 11:43:37 GMT, Henrik Dafgård <hdafgard at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java line 105:
>> 
>>> 103: 
>>> 104: 	public static final TypedPreference<IQuantity> MAX_TIMEOUT = new TypedPreference<>(
>>> 105: 			"classLeaking.calculation.timeout", //$NON-NLS-1$
>> 
>> Just a suggestion
>> 
>> Suggestion:
>> 
>> 			"classLeakingRuke.calculation.timeout", //$NON-NLS-1$
>
> `classLeakingRule`, no?

I have checked at other places and "Rule" is not mentioned anywhere for Preferences. For ClassLeakRule also there are other preferences like classLeaking.warning.limit and classLeaking.classesToReport.limit , the keyword Rule is not used anywhere. Hence, I have skipped it to follow the convention. For other rules also like Biased Revocation Rule, the preference is biasedRevocation.classesToReport.limit.

-------------

PR: https://git.openjdk.org/jmc/pull/419