RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v2]

Brice Dutheil bdutheil at openjdk.org
Wed Oct 5 20:21:33 UTC 2022


On Wed, 5 Oct 2022 18:40:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/ItemResultSetFactory.java line 43:

> 41: public class ItemResultSetFactory {
> 42: 	public IItemResultSet createResultSet(IItemCollection items, IItemQuery query) {
> 43: 		return new DefaultIItemResultSet(items, query, 0);

The issue with a value of 0 means the termination will be effective immediately (after the first 60 seconds), I think you can choose either
* a guard value like `-1` is better and in `DefaultIItemResultSet` just skip the termination.
* chose a very big value like one day (that's what JDK 19 does in `ExecutorService.close`, but the code can even wait longer)

-------------

PR: https://git.openjdk.org/jmc/pull/419


More information about the jmc-dev mailing list