RFR: 7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v2]

[Jaroslav Bachorik]

On Mon, 18 Jul 2022 11:57:08 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Update copyrights
>>  - Merge branch 'master' into jb/JMC-7855
>>  - JMC-7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks
>
> core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/api/RecordingSettingsBuilder.java line 57:
> 
>> 55: 	 * @since 8.3.0
>> 56: 	 */
>> 57: 	default RecordingSettingsBuilder withStartTicks(long ticks) {
> 
> Do we really need a default method here? That is, could it be that we load an older implementation class of this interface that doesn't have this method implemented?

I was being defensive here since this is a public API.
But perhaps we can get away with a technically breaking change since our writer APIs are never accepting an instance of `RecordingSettings` but rather just providing it in a callback - that way we are still having the full control over the concrete instance being used.

-------------

PR: https://git.openjdk.org/jmc/pull/412