RFR: 7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v2]

Marcus Hirt hirt at openjdk.org
Thu Oct 6 11:44:34 UTC 2022


On Thu, 6 Oct 2022 07:29:08 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> I was being defensive here since this is a public API.
>> But perhaps we can get away with a technically breaking change since our writer APIs are never accepting an instance of `RecordingSettings` but rather just providing it in a callback - that way we are still having the full control over the concrete instance being used.
>
> Let's see what @thegreystone has to say - I agree that in this case the default methods don't make much sense, on the other hand there is the thing about API evolution and added interface methods ...
> So it is more of a question of the code hygiene here.

I think it's friendly to not introduce compilation breaking changes for people using this. Especially in a minor version upgrade.

-------------

PR: https://git.openjdk.org/jmc/pull/412


More information about the jmc-dev mailing list