RFR: 7855: JFR Writer incorrectly uses epoch nanoseconds as the start ticks [v3]
Christoph Langer
clanger at openjdk.org
Mon Oct 10 21:28:57 UTC 2022
On Thu, 6 Oct 2022 08:28:28 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> Currently, the JFR recordings created by the JMC writer will have the start ticks set to the same value as the start timestamp. This will cause problems with the duration calculation which is using directly `System.nanoTime()` and as such the resulting value will be rather nonsensical.
>>
>> This PR adds two new recording settings - `startTicks` and `duration` which can be used to write a JFR recording with correct values set. If the user does not set those settings `startTicks` will be set to the value of `System.nanoTime()` at the moment the recording is started (a `Recording` instance is created) and `duration` will be computed as a diff between the current value of `System.nanoTime()` and `startTicks`.
>
> Jaroslav Bachorik has updated the pull request incrementally with two additional commits since the last revision:
>
> - Outstanding 'duration' fixes and cleanup
> - Update and formalize new jfr.writer dependencies
Looks good to me now. Thanks for working in my review comments.
-------------
Marked as reviewed by clanger (Committer).
PR: https://git.openjdk.org/jmc/pull/412
More information about the jmc-dev
mailing list