RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v4]

[Suchita Chaturvedi]

On Thu, 6 Oct 2022 20:28:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding higher timeout as default value

This PR is with respect to an issue raised by one of our customers where Class Leak Rule is taking 60-90 minutes to evaluate the results. The issue was raised on Sat Apr 24 2021. Its been more than a year and we couldn't give any solution to our customers, they are still living with that unacceptable calculation time. Now they are chasing us with several messages and mails to understand when will they receive a fix for it. They have marked it as P2.

Hence, considering below points:
1. We are reducing the rule calculation time from 60-90 mins to less than 60 seconds. These calculation timings are with respect to the JFR shared by customer while raising the issue in BugDB (Oracle Internal portal for raising issues).
2. We are correcting the results shown for Class Leak Rule and the correction is a drastic change. The existing approach is showing everything in GREEN even if there is a big issue and HIGH ALERT should be given as part of this rule results. This PR is fixing that issue and showing the correct result to the customers.
3. We have a fix which is not breaking anything as such. No Critical or Must DO review comment is left out unattended.

Is it possible to accept this PR for 8.3 release and create a new lesser priority enhancement request if there are any modifications required with respect to re-designing of this Rule or using some other data structure?

@thegreystone @Gunde @aptmac @bric3 I would like to know your views on this. Thanks in advance.

-------------

PR: https://git.openjdk.org/jmc/pull/419