RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v2]

Alex Macdonald aptmac at openjdk.org
Fri Oct 21 18:33:56 UTC 2022


On Thu, 3 Feb 2022 16:42:44 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.
>> 
>> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.
>> 
>> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:
>> 
>> - org.openjdk.jmc.ui.common.action (3)
>>     Executable, IActionProvider, IUserAction
>> 
>> - org.openjdk.jmc.ui.common.jvm (5)
>>     Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType
>> 
>> - org.openjdk.jmc.ui.common.resource (2)
>>     IImageResource, Resource
>> 
>> - org.openjdk.jmc.ui.common.security (10)
>>     ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory
>> 
>> - org.opendjk.jmc.ui.common.tree (3)
>>     IArray, IChild, IParent
>> 
>> - org.openjdk.jmc.ui.common.util (4)
>>     Environment, Filename, ICopyable, IObservable
>> 
>> - org.openjdk.jmc.ui.common.xydata (5)
>>     DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-7308
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - update license headers to 2022
>  - update license headers
>  - update agent plugin imports
>  - migrate classes from ui.common.resource to core
>  - migrate interfaces from ui.common.action to core
>  - migrate most of the remainder from ui.common.security to core
>  - migrate ui.common.xydata to core
>  - migrate Environment, Filename, ICopyable, and IObservable from ui.common.util to core
>  - migrate ui.common.tree to core
>  - migrate ui.common.jvm to core
>  - ... and 1 more: https://git.openjdk.org/jmc/compare/9ec05b30...69aeed33

Similar to my other PR (https://github.com/openjdk/jmc/pull/299), this has been rebased onto the current master branch for consideration in JMC 9.

-------------

PR: https://git.openjdk.org/jmc/pull/300


More information about the jmc-dev mailing list