RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v4]

[Alex Macdonald]

On Thu, 6 Oct 2022 20:28:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding higher timeout as default value

I think it looks okay for me. It would be nice to have a way of reproducing the issue to verify, but I get it's tough if the original jfr is from a customer and can't be shared.

Having said that, @Gunde and @bric3 did substantial review on this PR as well as the previous (https://github.com/openjdk/jmc/pull/248), and while on the surface it looks like everything has been addressed I would feel much more comfortable if they could just confirm that what they wanted addressed was updated in this PR before merging it.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 84:

> 82: 	private void calculateData(IItemCollection input, int configuredTimeout) throws InterruptedException {
> 83: 		input = input.apply(query.getFilter());
> 84: 		final IItemCollection newInput = input;

Very minor nit, but this could be moved to be inside the else block where it's used? It's not required for the first chunk of the if-statement.

-------------

PR: https://git.openjdk.org/jmc/pull/419