RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v5]

Alex Macdonald aptmac at openjdk.org
Tue Oct 25 19:15:51 UTC 2022


On Tue, 25 Oct 2022 18:33:33 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - update license headers to 2022
>>  - fix package name in JFCXMLValidator logger
>>  - re-order flightrecorder.configuration.test in test pom
>>  - update license headers
>>  - migrate VolatileStorageDelegate to flightrecorder.configuration.model
>>  - revert .classpath files to their original from application
>>  - minor cleanup
>>  - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
>>    
>>    The controlpanel.ui.configuration only had the XML test, which is now
>>    located in flightrecorder.configuration.test in core. Currently all
>>    tests in both core and application will pass.
>>  - move flightrecorder.configuration coverage from application to core
>>  - temporarily silence test modules that are moved, will cleanup after
>>  - ... and 2 more: https://git.openjdk.org/jmc/compare/0e8e2004...9fad2d39
>
> I'm addressing the issues in common.test via #448

Thanks @RealCLanger ! Lots of great review points, much appreciate you taking a look at the PR. I'll see if I can find some time this week to address what you've raised.

-------------

PR: https://git.openjdk.org/jmc/pull/299


More information about the jmc-dev mailing list