From duke at openjdk.org Thu Sep 1 08:54:47 2022 From: duke at openjdk.org (Virag Purnam) Date: Thu, 1 Sep 2022 08:54:47 GMT Subject: Integrated: 7874: Update thirdpartyreadme.txt file for upgraded third party libraries In-Reply-To: References: Message-ID: On Fri, 26 Aug 2022 15:41:20 GMT, Virag Purnam wrote: > Updated the License information in thirdpartyreadme.txt file. This pull request has now been integrated. Changeset: f573b72d Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/f573b72d7a4d9d4bd8b57b77554caf10a36423a8 Stats: 6894 lines in 1 file changed: 5547 ins; 857 del; 490 mod 7874: Update thirdpartyreadme.txt file for upgraded third party libraries Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/422 From duke at openjdk.org Thu Sep 1 08:56:20 2022 From: duke at openjdk.org (Virag Purnam) Date: Thu, 1 Sep 2022 08:56:20 GMT Subject: Integrated: 7096: Bring back Object statistics table for heap. In-Reply-To: References: Message-ID: On Tue, 23 Aug 2022 07:56:19 GMT, Virag Purnam wrote: > In the memory page, below mentioned columns have been added as per the request from customer. These columns are not visible by default. Users can select these from "Visible Columns" option. Customer wants these columns for the "Object Statistics". > > - Avg Live Count > - Avg Live Size > - Live Instances Increase > - Percentage of Heap > > ![ObjectStatistics](https://user-images.githubusercontent.com/97600378/186091512-b434560a-96b1-4e62-80b8-029ae95169bf.jpg) This pull request has now been integrated. Changeset: c03822bd Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/c03822bdc231003d30b7f7df42ca44b2ae6cd78f Stats: 71 lines in 9 files changed: 69 ins; 0 del; 2 mod 7096: Bring back Object statistics table for heap. Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/420 From hirt at openjdk.org Fri Sep 2 10:48:01 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 2 Sep 2022 10:48:01 GMT Subject: RFR: 6757: Selector for attribute in the flame graph [v2] In-Reply-To: <8ChKbGOuqVMi-l5FCae_Jlsw7or7DDBIo13wR6Yrum4=.5a250de2-5906-4770-b11c-7ca98a9bf443@github.com> References: <8ChKbGOuqVMi-l5FCae_Jlsw7or7DDBIo13wR6Yrum4=.5a250de2-5906-4770-b11c-7ca98a9bf443@github.com> Message-ID: On Mon, 29 Aug 2022 20:59:07 GMT, Jean-Philippe Bempel wrote: >> Add support for aggregating flamegraph by custom attribute. >> >> Available attributes are chosen by their content type (number or memory). >> >> Screenshot 2022-04-22 at 08 35 
>> 47 >> >> Screenshot 2022-04-22 at 08 36 06 >> >> Added support on StacktraceView: >> >> Screenshot 2022-05-10 at 22 20 13 > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > Filter items containing selected attribute > > Add separator and Samples as first in attribute selection > Fix copyright year Changes requested by hirt (Lead). Do we want to not even show attributes that only exist in event types that do not have stacktraces? Or perhaps at least sort those attributes under its own subgroup or after a delimiter? Either way, I think it's fine to take this PR once the last copyright fix is in. We can take any changes to what attributes are shown as a separate improvement. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AttributeSelection.java line 2: > 1: /* > 2: * Copyright (c) 2022, Datadog, Inc. All rights reserved. Copyrights must have a dual Oracle/Datadog copyright header per OCA. See other copyrighted files. core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/json/FlameGraphJsonSerializer.java line 2: > 1: /* > 2: * Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved. See this file for an example of copyright header with Oracle + Datadog copyright. ------------- PR: https://git.openjdk.org/jmc/pull/365 From jpbempel at openjdk.org Fri Sep 2 19:51:46 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Fri, 2 Sep 2022 19:51:46 GMT Subject: RFR: 6757: Selector for attribute in the flame graph [v3] In-Reply-To: References: Message-ID: > Add support for aggregating flamegraph by custom attribute. > > Available attributes are chosen by their content type (number or memory). > > Screenshot 2022-04-22 at 08 35 
> 47 > > Screenshot 2022-04-22 at 08 36 06 > > Added support on StacktraceView: > > Screenshot 2022-05-10 at 22 20 13 Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: fix copyright header ------------- Changes: - all: https://git.openjdk.org/jmc/pull/365/files - new: https://git.openjdk.org/jmc/pull/365/files/b2e48e13..05a33c30 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/365.diff Fetch: git fetch https://git.openjdk.org/jmc pull/365/head:pull/365 PR: https://git.openjdk.org/jmc/pull/365 From jpbempel at openjdk.org Fri Sep 2 20:06:49 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Fri, 2 Sep 2022 20:06:49 GMT Subject: RFR: 6757: Selector for attribute in the flame graph [v4] In-Reply-To: References: Message-ID: > Add support for aggregating flamegraph by custom attribute. > > Available attributes are chosen by their content type (number or memory). > > Screenshot 2022-04-22 at 08 35 
> 47 > > Screenshot 2022-04-22 at 08 36 06 > > Added support on StacktraceView: > > Screenshot 2022-05-10 at 22 20 13 Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: Filter event without stacktrace as attribute ------------- Changes: - all: https://git.openjdk.org/jmc/pull/365/files - new: https://git.openjdk.org/jmc/pull/365/files/05a33c30..a8badd6e Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=365&range=02-03 Stats: 7 lines in 1 file changed: 3 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/365.diff Fetch: git fetch https://git.openjdk.org/jmc pull/365/head:pull/365 PR: https://git.openjdk.org/jmc/pull/365 From hirt at openjdk.org Fri Sep 2 20:42:51 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 2 Sep 2022 20:42:51 GMT Subject: RFR: 6757: Selector for attribute in the flame graph [v4] In-Reply-To: References: Message-ID: On Fri, 2 Sep 2022 20:06:49 GMT, Jean-Philippe Bempel wrote: >> Add support for aggregating flamegraph by custom attribute. >> >> Available attributes are chosen by their content type (number or memory). >> >> Screenshot 2022-04-22 at 08 35 
>> 47 >> >> Screenshot 2022-04-22 at 08 36 06 >> >> Added support on StacktraceView: >> >> Screenshot 2022-05-10 at 22 20 13 > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > Filter event without stacktrace as attribute Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/365 From jpbempel at openjdk.org Sat Sep 3 11:10:48 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Sat, 3 Sep 2022 11:10:48 GMT Subject: Integrated: 6757: Selector for attribute in the flame graph In-Reply-To: References: Message-ID: On Wed, 19 Jan 2022 13:04:35 GMT, Jean-Philippe Bempel wrote: > Add support for aggregating flamegraph by custom attribute. > > Available attributes are chosen by their content type (number or memory). > > Screenshot 2022-04-22 at 08 35 
> 47 > > Screenshot 2022-04-22 at 08 36 06 > > Added support on StacktraceView: > > Screenshot 2022-05-10 at 22 20 13 This pull request has now been integrated. Changeset: 9a46d3ec Author: Jean-Philippe Bempel URL: https://git.openjdk.org/jmc/commit/9a46d3ec54e80d310b27b73ceb4c84deda9ead47 Stats: 438 lines in 11 files changed: 374 ins; 0 del; 64 mod 6757: Selector for attribute in the flame graph Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/365 From duke at openjdk.org Thu Sep 8 13:32:19 2022 From: duke at openjdk.org (Brice Dutheil) Date: Thu, 8 Sep 2022 13:32:19 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization Message-ID: This change introduces a possible replacement for the current flamegraph view. **Motivation** The current is based on a web view. In the current state, - the web view can be slow to render especially when the tree is large. - the web view don't feel well integrated, in particular when popups are shown. - web view are difficult to work with from a JMC developer perspective. ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) **Description** Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. As the intent of this view is to eventually replace the current one, the icons are the same. Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. cd releng/third-party mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar # if sources are wanted mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources # make the p2 site, don't forget the -U mvn p2:site -U; mvn jetty:run **Outstanding issues / limitation** - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. - [x] Currently the view does not initializes correctly: the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. https://github.com/bric3/fireplace/issues/79 - [x] Fireplace only supports _icicle_ view at this time. https://github.com/bric3/fireplace/issues/22 - [x] Icons for minimap toggle and zoom reset image - [x] Export to image https://github.com/bric3/fireplace/issues/99 - [x] Export to print ? Can be done at a later time - [x] release of fireplace ------------- Commit messages: - Use fireplace pre-release 0.0.1-rc3 - Adds zoom animation support - Use the new fireplace swt-swt bridge - Use #637CA5 instead of light gray #3b3b3b - Use #3b3b3b instead of black for icons - Make copyrights headers attributed to datadog in 2022 - Adds reset zoom and minimap icons - Avoid dead-locking the main thread with AWT-EventQueue-0 - Make the code Java 1.8 compliant - Supports saving to image - ... and 8 more: https://git.openjdk.org/jmc/compare/cd7b6e6c...2e0428cf Changes: https://git.openjdk.org/jmc/pull/408/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7894 Stats: 1202 lines in 35 files changed: 1182 ins; 6 del; 14 mod Patch: https://git.openjdk.org/jmc/pull/408.diff Fetch: git fetch https://git.openjdk.org/jmc pull/408/head:pull/408 PR: https://git.openjdk.org/jmc/pull/408 From hirt at openjdk.org Thu Sep 8 13:32:19 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 8 Sep 2022 13:32:19 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization In-Reply-To: References: Message-ID: <8-lwVDd9-U2F4jt_NmD5uLyVaqs-fkN23wrjGa8PNuU=.3a06d79e-7475-4f0d-9f43-3d2a7fbae586@github.com> On Wed, 6 Jul 2022 11:36:47 GMT, Brice Dutheil wrote: > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace This is great! All we need now is: * Support for rendering the thing upside down (flame rather than icicle). * Support for hooking in alternative tooltip mechanisms, e.g. perhaps we can do the tooltips in SWT and thereby bypass the limitation of rendering them on the AWT surface? * Use an SWT scrolled composite? If you're the only contributor, you don't need to explicitly add yourself. ;) ------------- PR: https://git.openjdk.org/jmc/pull/408 From duke at openjdk.org Thu Sep 8 13:32:19 2022 From: duke at openjdk.org (Brice Dutheil) Date: Thu, 8 Sep 2022 13:32:19 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization In-Reply-To: References: Message-ID: On Wed, 6 Jul 2022 11:36:47 GMT, Brice Dutheil wrote: > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace Hi thanks > * Support for rendering the thing upside down (flame rather than icicle). Need some time around this. Can this come at a later time? > * Support for hooking in alternative tooltip mechanisms, e.g. perhaps we can do the tooltips in SWT and thereby bypass the limitation of rendering them on the AWT surface? Actually tooltips are based on Eclipse's JFace ; in a previous implementation I played with SWT's `ToolTip` but the component doesn't allow multiline or even give some style. > * Use an SWT scrolled composite? Let's not rule that out, but that represents a significant work. Currently we should see the fireplace flamegraph as a coherent unit that is composed of a JScrollPane among other swing component. So https://github.com/openjdk/jmc/pull/408/commits/736b3c1f26ee7e8a5e167ca016bd550513d78d96 adds iciclegraph ? (already there) and flamegraph ? image Also the library now highlight sibling frames (the screenshot above shows several `AccessControler.doPrivileged`), the comparison is based on `AggregatableFrame`. ------------- PR: https://git.openjdk.org/jmc/pull/408 From hirt at openjdk.org Thu Sep 8 13:32:19 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 8 Sep 2022 13:32:19 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization In-Reply-To: References: Message-ID: On Wed, 6 Jul 2022 23:43:57 GMT, Brice Dutheil wrote: > Actually tooltips are based on Eclipse's JFace. Nice! So that means we can have similar tooltips to the current ones, but they will not be cut off at the panel boundaries? That's great! Regarding using an SWT scrolled composite to wrap the component, isn't that the way to do this? I mean, basically setting the width to the width of the parent container, and have the height calculated (and reported) accordingly? ------------- PR: https://git.openjdk.org/jmc/pull/408 From duke at openjdk.org Thu Sep 8 13:32:19 2022 From: duke at openjdk.org (Brice Dutheil) Date: Thu, 8 Sep 2022 13:32:19 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization In-Reply-To: References: Message-ID: On Thu, 7 Jul 2022 16:37:18 GMT, Marcus Hirt wrote: > Regarding using an SWT scrolled composite to wrap the component, isn't that the way to do this? I mean, basically setting the width to the width of the parent container, and have the height calculated (and reported) accordingly? This could have been possible this way, but in order to react correctly to mouse events there's a "tight" integration between listeners. While it could be possible it represents a big rework. And anyway I spend some time figuring out what was wrong in bric3/fireplace#79, and fixed the issue. @thegreystone The view is almost on par with the existing, there's no two outstanding issues, icons for some actions, and export actions. ---- Also. Since fireplace has now no release yet, it's a bit hard to test this PR for a few reasons : - The maven p2 plugin replaces `-SNAPSHOT` by a timestamp that is set when the local p2 site is created, not the timestamp of the snapshot artifact. See https://github.com/reficio/p2-maven-plugin/issues/59 - Which means that `.target` files have to be changed locally, after the `mvn p2:site -U` has been run with the actual filename timestamp e.g. the jar file is `releng/third-party/target/repository/plugins/fireplace-swing_0.0.1.20220804110518.jar` so the version to update in the `.target` files is `0.0.1.20220804110518` - Don't open the `.target` from the project view, you actually need to open the file using the menu otherwise Eclipse don't see that the `.target` file has changed so it doesn't use the new snapshot version. I'd like to release a version soon, but I'd like to make sure most things are alright. ------------- PR: https://git.openjdk.org/jmc/pull/408 From hirt at openjdk.org Wed Sep 14 17:30:52 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 14 Sep 2022 17:30:52 GMT Subject: RFR: 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs In-Reply-To: References: Message-ID: On Tue, 11 Jan 2022 17:44:09 GMT, Jean-Philippe Bempel wrote: > 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs Changes requested by hirt (Lead). core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/graph/Pruning.java line 2: > 1: /* > 2: * Copyright (c) 2019, 2022, Datadog, Inc. All rights reserved. Need an Oracle copyright. ------------- PR: https://git.openjdk.org/jmc/pull/349 From jpbempel at openjdk.org Thu Sep 15 19:51:53 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Thu, 15 Sep 2022 19:51:53 GMT Subject: RFR: 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs [v2] In-Reply-To: References: Message-ID: > 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: Add copyright ------------- Changes: - all: https://git.openjdk.org/jmc/pull/349/files - new: https://git.openjdk.org/jmc/pull/349/files/95462c04..e251afbc Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=349&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=349&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/349.diff Fetch: git fetch https://git.openjdk.org/jmc pull/349/head:pull/349 PR: https://git.openjdk.org/jmc/pull/349 From hirt at openjdk.org Thu Sep 15 20:35:58 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 15 Sep 2022 20:35:58 GMT Subject: RFR: 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs [v2] In-Reply-To: References: Message-ID: On Thu, 15 Sep 2022 19:51:53 GMT, Jean-Philippe Bempel wrote: >> 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs > > Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision: > > Add copyright Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/349 From duke at openjdk.org Fri Sep 16 06:19:49 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 06:19:49 GMT Subject: RFR: 7381: Better descriptions for reports Message-ID: Merge changes of 8.2.1 into master branch ------------- Commit messages: - 7381: Better descriptions for reports Changes: https://git.openjdk.org/jmc/pull/423/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=423&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7381 Stats: 10 lines in 4 files changed: 7 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/423.diff Fetch: git fetch https://git.openjdk.org/jmc pull/423/head:pull/423 PR: https://git.openjdk.org/jmc/pull/423 From duke at openjdk.org Fri Sep 16 06:43:47 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 06:43:47 GMT Subject: RFR: 7381: Better descriptions for reports [v2] In-Reply-To: References: Message-ID: > Merge changes of 8.2.1 into master branch Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: 7896: Merge changes of 8.2.1 into master branch ------------- Changes: - all: https://git.openjdk.org/jmc/pull/423/files - new: https://git.openjdk.org/jmc/pull/423/files/e8e5f6fc..e116e2d5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=423&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=423&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/423.diff Fetch: git fetch https://git.openjdk.org/jmc pull/423/head:pull/423 PR: https://git.openjdk.org/jmc/pull/423 From jpbempel at openjdk.org Fri Sep 16 07:02:49 2022 From: jpbempel at openjdk.org (Jean-Philippe Bempel) Date: Fri, 16 Sep 2022 07:02:49 GMT Subject: Integrated: 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs In-Reply-To: References: Message-ID: On Tue, 11 Jan 2022 17:44:09 GMT, Jean-Philippe Bempel wrote: > 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs This pull request has now been integrated. Changeset: b29aefc2 Author: Jean-Philippe Bempel URL: https://git.openjdk.org/jmc/commit/b29aefc2fc59f8fe00d750fb0f0681c351b49ae1 Stats: 293 lines in 5 files changed: 247 ins; 0 del; 46 mod 7074: Smart pruning of graphs to make it possible to sensibly render larger graphs Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/349 From duke at openjdk.org Fri Sep 16 07:23:57 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 07:23:57 GMT Subject: Withdrawn: 7381: Better descriptions for reports In-Reply-To: References: Message-ID: On Fri, 16 Sep 2022 06:13:47 GMT, Virag Purnam wrote: > Merge changes of 8.2.1 into master branch This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/423 From duke at openjdk.org Fri Sep 16 07:45:52 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 07:45:52 GMT Subject: RFR: 7896: Merge changes of 8.2.1 into master branch Message-ID: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> Merging changes of 8.2.1 into master branch. ------------- Commit messages: - 7896: Merge changes of 8.2.1 into master branch Changes: https://git.openjdk.org/jmc/pull/424/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=424&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7896 Stats: 11 lines in 4 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/424.diff Fetch: git fetch https://git.openjdk.org/jmc pull/424/head:pull/424 PR: https://git.openjdk.org/jmc/pull/424 From schaturvedi at openjdk.org Fri Sep 16 08:12:07 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 16 Sep 2022 08:12:07 GMT Subject: RFR: 7896: Merge changes of 8.2.1 into master branch In-Reply-To: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> References: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> Message-ID: On Fri, 16 Sep 2022 07:39:52 GMT, Virag Purnam wrote: > Merging changes of 8.2.1 into master branch. Marked as reviewed by schaturvedi (Committer). ------------- PR: https://git.openjdk.org/jmc/pull/424 From hirt at openjdk.org Fri Sep 16 08:16:46 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 16 Sep 2022 08:16:46 GMT Subject: RFR: 7896: Merge changes of 8.2.1 into master branch In-Reply-To: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> References: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> Message-ID: On Fri, 16 Sep 2022 07:39:52 GMT, Virag Purnam wrote: > Merging changes of 8.2.1 into master branch. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/424 From duke at openjdk.org Fri Sep 16 08:18:49 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 08:18:49 GMT Subject: Integrated: 7896: Merge changes of 8.2.1 into master branch In-Reply-To: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> References: <8EKO3twdBXJTy9e_cY1h2PzlWXUFIQweQDENGNr_zik=.b6ff24a9-9de2-45a0-8506-cf70e94f90db@github.com> Message-ID: On Fri, 16 Sep 2022 07:39:52 GMT, Virag Purnam wrote: > Merging changes of 8.2.1 into master branch. This pull request has now been integrated. Changeset: 0b91cf1d Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/0b91cf1df15b65eec27ad3cf4d64f2c015291ea6 Stats: 11 lines in 4 files changed: 8 ins; 0 del; 3 mod 7896: Merge changes of 8.2.1 into master branch Reviewed-by: schaturvedi, hirt ------------- PR: https://git.openjdk.org/jmc/pull/424 From duke at openjdk.org Fri Sep 16 09:27:25 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 09:27:25 GMT Subject: RFR: 7812: Unable to open links from Automated Result analysis page Message-ID: <6R4m8dwbRbF_LcYeE5oxx_Clu06KTAP0lu_sZck89Nc=.fec297c3-bac7-43b7-8694-55c186b2493b@github.com> Issue is present on Mac and Linux, as the system browser blocks the request coming from "Windows.open()". With this commit all the urls will open within the JMC web browser. Introduced a small icon as well. Please refer the screen shot. ![1](https://user-images.githubusercontent.com/97600378/190602190-988d6632-334c-4222-9b22-484001208450.jpg) ![2](https://user-images.githubusercontent.com/97600378/190602218-0e1b3af9-1109-4c51-b433-c21ce7e13779.jpg) ------------- Commit messages: - 7812: Unable to open links from Automated Result analysis page Changes: https://git.openjdk.org/jmc/pull/425/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=425&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7812 Stats: 52 lines in 8 files changed: 42 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jmc/pull/425.diff Fetch: git fetch https://git.openjdk.org/jmc pull/425/head:pull/425 PR: https://git.openjdk.org/jmc/pull/425 From hirt at openjdk.org Fri Sep 16 15:19:51 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 16 Sep 2022 15:19:51 GMT Subject: RFR: 7812: Unable to open links from Automated Result analysis page In-Reply-To: <6R4m8dwbRbF_LcYeE5oxx_Clu06KTAP0lu_sZck89Nc=.fec297c3-bac7-43b7-8694-55c186b2493b@github.com> References: <6R4m8dwbRbF_LcYeE5oxx_Clu06KTAP0lu_sZck89Nc=.fec297c3-bac7-43b7-8694-55c186b2493b@github.com> Message-ID: On Fri, 16 Sep 2022 09:19:57 GMT, Virag Purnam wrote: > Issue is present on Mac and Linux, as the system browser blocks the request coming from "Windows.open()". With this commit all the urls will open within the JMC web browser. Introduced a small icon as well. Please refer the screen shot. > > ![1](https://user-images.githubusercontent.com/97600378/190602190-988d6632-334c-4222-9b22-484001208450.jpg) > > > ![2](https://user-images.githubusercontent.com/97600378/190602218-0e1b3af9-1109-4c51-b433-c21ce7e13779.jpg) Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/425 From duke at openjdk.org Fri Sep 16 17:19:50 2022 From: duke at openjdk.org (Virag Purnam) Date: Fri, 16 Sep 2022 17:19:50 GMT Subject: Integrated: 7812: Unable to open links from Automated Result analysis page In-Reply-To: <6R4m8dwbRbF_LcYeE5oxx_Clu06KTAP0lu_sZck89Nc=.fec297c3-bac7-43b7-8694-55c186b2493b@github.com> References: <6R4m8dwbRbF_LcYeE5oxx_Clu06KTAP0lu_sZck89Nc=.fec297c3-bac7-43b7-8694-55c186b2493b@github.com> Message-ID: On Fri, 16 Sep 2022 09:19:57 GMT, Virag Purnam wrote: > Issue is present on Mac and Linux, as the system browser blocks the request coming from "Windows.open()". With this commit all the urls will open within the JMC web browser. Introduced a small icon as well. Please refer the screen shot. > > ![1](https://user-images.githubusercontent.com/97600378/190602190-988d6632-334c-4222-9b22-484001208450.jpg) > > > ![2](https://user-images.githubusercontent.com/97600378/190602218-0e1b3af9-1109-4c51-b433-c21ce7e13779.jpg) This pull request has now been integrated. Changeset: 9b8e0449 Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/9b8e04494384400a902ad6e4a22587764576e5a7 Stats: 52 lines in 8 files changed: 42 ins; 0 del; 10 mod 7812: Unable to open links from Automated Result analysis page Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/425 From duke at openjdk.org Mon Sep 19 12:36:42 2022 From: duke at openjdk.org (Virag Purnam) Date: Mon, 19 Sep 2022 12:36:42 GMT Subject: RFR: 7870: JMC 8.3.0 Update Site Pages require changes Message-ID: Updated the correct links and details in the update site pages. ------------- Commit messages: - 7870: JMC 8.3.0 Update Site Pages require changes Changes: https://git.openjdk.org/jmc/pull/426/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=426&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7870 Stats: 9 lines in 4 files changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/426.diff Fetch: git fetch https://git.openjdk.org/jmc pull/426/head:pull/426 PR: https://git.openjdk.org/jmc/pull/426 From schaturvedi at openjdk.org Wed Sep 21 08:40:27 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 21 Sep 2022 08:40:27 GMT Subject: RFR: 7892: JMC Automated UI MasterPasswordTests is failing Message-ID: <2o1_mUMSPLs0OTNg-HNo7xIBi99gj04iyw91jn1RF5g=.c1d8a5bb-5bf6-47c3-856c-1b6d2f6bcedd@github.com> The ui test case was not adhering to new password validation requirement, hence it was failing. This PR fixes the issue and uitests are passing after that. ------------- Commit messages: - 7892: JMC Automated UI MasterPasswordTests is failing Changes: https://git.openjdk.org/jmc/pull/427/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=427&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7892 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/427.diff Fetch: git fetch https://git.openjdk.org/jmc pull/427/head:pull/427 PR: https://git.openjdk.org/jmc/pull/427 From hirt at openjdk.org Wed Sep 21 11:03:56 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 21 Sep 2022 11:03:56 GMT Subject: RFR: 7892: JMC Automated UI MasterPasswordTests is failing In-Reply-To: <2o1_mUMSPLs0OTNg-HNo7xIBi99gj04iyw91jn1RF5g=.c1d8a5bb-5bf6-47c3-856c-1b6d2f6bcedd@github.com> References: <2o1_mUMSPLs0OTNg-HNo7xIBi99gj04iyw91jn1RF5g=.c1d8a5bb-5bf6-47c3-856c-1b6d2f6bcedd@github.com> Message-ID: <9Fsmk50WkJrM8sEJW5M8ZFbOE6yc1AhIO83MkvUNYr8=.4f649766-e4bc-4d72-8cc9-e5191f03eecf@github.com> On Wed, 21 Sep 2022 08:34:29 GMT, Suchita Chaturvedi wrote: > The ui test case was not adhering to new password validation requirement, hence it was failing. This PR fixes the issue and uitests are passing after that. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/427 From hirt at openjdk.org Wed Sep 21 11:05:59 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 21 Sep 2022 11:05:59 GMT Subject: RFR: 7870: JMC 8.3.0 Update Site Pages require changes In-Reply-To: References: Message-ID: On Mon, 19 Sep 2022 12:32:22 GMT, Virag Purnam wrote: > Updated the correct links and details in the update site pages. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/426 From schaturvedi at openjdk.org Wed Sep 21 11:09:52 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 21 Sep 2022 11:09:52 GMT Subject: Integrated: 7892: JMC Automated UI MasterPasswordTests is failing In-Reply-To: <2o1_mUMSPLs0OTNg-HNo7xIBi99gj04iyw91jn1RF5g=.c1d8a5bb-5bf6-47c3-856c-1b6d2f6bcedd@github.com> References: <2o1_mUMSPLs0OTNg-HNo7xIBi99gj04iyw91jn1RF5g=.c1d8a5bb-5bf6-47c3-856c-1b6d2f6bcedd@github.com> Message-ID: On Wed, 21 Sep 2022 08:34:29 GMT, Suchita Chaturvedi wrote: > The ui test case was not adhering to new password validation requirement, hence it was failing. This PR fixes the issue and uitests are passing after that. This pull request has now been integrated. Changeset: de649008 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/de649008bf4b5eec761c2487e0c8c9069ff5ab31 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7892: JMC Automated UI MasterPasswordTests is failing Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/427 From duke at openjdk.org Wed Sep 21 11:15:43 2022 From: duke at openjdk.org (Virag Purnam) Date: Wed, 21 Sep 2022 11:15:43 GMT Subject: Integrated: 7870: JMC 8.3.0 Update Site Pages require changes In-Reply-To: References: Message-ID: On Mon, 19 Sep 2022 12:32:22 GMT, Virag Purnam wrote: > Updated the correct links and details in the update site pages. This pull request has now been integrated. Changeset: 359f6abe Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/359f6abe17d81131e6091fa5596d6f45f56613d7 Stats: 9 lines in 4 files changed: 0 ins; 1 del; 8 mod 7870: JMC 8.3.0 Update Site Pages require changes Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/426 From duke at openjdk.org Thu Sep 22 07:42:14 2022 From: duke at openjdk.org (Virag Purnam) Date: Thu, 22 Sep 2022 07:42:14 GMT Subject: RFR: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 Message-ID: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> By adding 'org.eclipse.jdt.core' bundle as an explicit dependency to our documentation bundle as direct dependency, we can fix this issue. This fixes the old issue [JMC-7321](https://bugs.openjdk.org/browse/JMC-7321) as well. This is just a workaround. Proper solution is, org.apache.jasper.glassfish package must be updated to contain a more up to date JDT compiler and this updated package must be used as a dependency by the documentation bundle. (In Progress) Details can be found in below link. [https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937](https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937) ------------- Commit messages: - 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 Changes: https://git.openjdk.org/jmc/pull/428/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=428&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7813 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/428.diff Fetch: git fetch https://git.openjdk.org/jmc pull/428/head:pull/428 PR: https://git.openjdk.org/jmc/pull/428 From hirt at openjdk.org Thu Sep 22 14:51:36 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 22 Sep 2022 14:51:36 GMT Subject: RFR: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 In-Reply-To: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> References: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> Message-ID: On Thu, 22 Sep 2022 07:35:04 GMT, Virag Purnam wrote: > By adding 'org.eclipse.jdt.core' bundle as an explicit dependency to our documentation bundle as direct dependency, we can fix this issue. This fixes the old issue [JMC-7321](https://bugs.openjdk.org/browse/JMC-7321) as well. > > This is just a workaround. > Proper solution is, org.apache.jasper.glassfish package must be updated to contain a more up to date JDT compiler and this updated package must be used as a dependency by the documentation bundle. (In Progress) > > Details can be found in below link. [https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937](https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937) Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/428 From duke at openjdk.org Thu Sep 22 15:26:26 2022 From: duke at openjdk.org (Brice Dutheil) Date: Thu, 22 Sep 2022 15:26:26 GMT Subject: RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. In-Reply-To: References: Message-ID: On Mon, 29 Aug 2022 22:09:37 GMT, Suchita Chaturvedi wrote: >> This PR takes care of optimizing and correcting the Class leak rule results on Automated Analysis Page. > >> Is https://bugs.openjdk.org/browse/JMC-7879 a duplicate of https://bugs.openjdk.org/browse/JMC-7248? >> >> It looks like this PR is #248 with some of the review comments addressed, should the former PR be closed in favor of this? >> >> There are a couple of review comments that didn't receive any changes in this PR: https://github.com/openjdk/jmc/pull/248/files#r756349943 https://github.com/openjdk/jmc/pull/248/files#r756353644 >> >> It looks like the consensus on #248 was that it was good enough to go in, maybe ping @bric3 and/or @Gunde for a re-review/approval? > > This PR is a superset of the previous one. The older one deals with only optimization of the class leak rule but this one deals with the optimization as well as the correction of the results shown on automated analysis page for class leak rule. I have implemented all the review comments given on the previous PR. With respect to the two comments mentioned above, the configured timeout is being fetched from preference hence I am finding it difficult to make it final. The interrupted exception handling is done where the method is called in catch block. I had already pinged about this issue in general slack channel and it was discussed in hangout also. > > @Gunde and @bric3 Request both of you to please take a look at this PR and let me know your review comments. Thanks in advance. @Suchitainf Sorry for the lack of response, I was on vacation in August, and got some stuff at work to handle, I should have more luck next week. Thanks for your patience ! ------------- PR: https://git.openjdk.org/jmc/pull/419 From hirt at openjdk.org Sun Sep 25 00:45:17 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Sun, 25 Sep 2022 00:45:17 GMT Subject: RFR: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 In-Reply-To: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> References: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> Message-ID: On Thu, 22 Sep 2022 07:35:04 GMT, Virag Purnam wrote: > By adding 'org.eclipse.jdt.core' bundle as an explicit dependency to our documentation bundle as direct dependency, we can fix this issue. This fixes the old issue [JMC-7321](https://bugs.openjdk.org/browse/JMC-7321) as well. > > This is just a workaround. > Proper solution is, org.apache.jasper.glassfish package must be updated to contain a more up to date JDT compiler and this updated package must be used as a dependency by the documentation bundle. (In Progress) > > Details can be found in below link. [https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937](https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937) @viragpurnam - please integrate. ------------- PR: https://git.openjdk.org/jmc/pull/428 From duke at openjdk.org Sun Sep 25 00:45:17 2022 From: duke at openjdk.org (Virag Purnam) Date: Sun, 25 Sep 2022 00:45:17 GMT Subject: RFR: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 In-Reply-To: References: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> Message-ID: On Sat, 24 Sep 2022 14:01:13 GMT, Marcus Hirt wrote: > @viragpurnam - please integrate. @thegreystone : Really Sorry, I missed to do that. I have done now. Could you please Sponsor. ------------- PR: https://git.openjdk.org/jmc/pull/428 From duke at openjdk.org Sun Sep 25 10:08:27 2022 From: duke at openjdk.org (Virag Purnam) Date: Sun, 25 Sep 2022 10:08:27 GMT Subject: Integrated: 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 In-Reply-To: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> References: <9y6DnKFWKZzr4EDZ_10s3aPCg3GsWXUrKKOSAF8aZBs=.9143151e-5208-4a8f-8bf1-f0e00248e49d@github.com> Message-ID: On Thu, 22 Sep 2022 07:35:04 GMT, Virag Purnam wrote: > By adding 'org.eclipse.jdt.core' bundle as an explicit dependency to our documentation bundle as direct dependency, we can fix this issue. This fixes the old issue [JMC-7321](https://bugs.openjdk.org/browse/JMC-7321) as well. > > This is just a workaround. > Proper solution is, org.apache.jasper.glassfish package must be updated to contain a more up to date JDT compiler and this updated package must be used as a dependency by the documentation bundle. (In Progress) > > Details can be found in below link. [https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937](https://bugs.eclipse.org/bugs/show_bug.cgi?id=574937) This pull request has now been integrated. Changeset: e6778b19 Author: vpurnam Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/e6778b191878c68d7c72af93a1a99ee49e0e7caa Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 7813: Unable to open Help page in macOS M1 when JMC started with JDK11 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/428 From schaturvedi at openjdk.org Tue Sep 27 07:40:09 2022 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 27 Sep 2022 07:40:09 GMT Subject: RFR: 7350: [Accessibility, JAWS] Deadlinks in Help Page Message-ID: This link is present in all the help pages and everywhere its just a dead link. As per the code, it navigates to the begin of the page which is already displayed and no extra navigation is required for the same. I can't find a logical purpose this link serves. Hence, this PR removes this link from all pages. ------------- Commit messages: - 7350: [Accessibility, JAWS] Deadlinks in Help Page Changes: https://git.openjdk.org/jmc/pull/430/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=430&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7350 Stats: 79 lines in 79 files changed: 0 ins; 79 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/430.diff Fetch: git fetch https://git.openjdk.org/jmc pull/430/head:pull/430 PR: https://git.openjdk.org/jmc/pull/430 From hirt at openjdk.org Tue Sep 27 13:20:17 2022 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 27 Sep 2022 13:20:17 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization In-Reply-To: References: Message-ID: On Wed, 6 Jul 2022 11:36:47 GMT, Brice Dutheil wrote: > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace Changes requested by hirt (Lead). application/org.openjdk.jmc.flightrecorder.flameview-java/plugin.properties line 2: > 1: # > 2: # Copyright (c) 2022, Datadog, Inc. All rights reserved. Needs to be an Oracle/Datadog dual copyright. Check other Datadog provided files for examples. application/org.openjdk.jmc.flightrecorder.flameview-java/plugin.xml line 3: > 1: > 2: