RFR: 7894: Provide an alternative Java based flamegraph visualization
Brice Dutheil
duke at openjdk.org
Thu Sep 8 13:32:19 UTC 2022
On Thu, 7 Jul 2022 16:37:18 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> Regarding using an SWT scrolled composite to wrap the component, isn't that the way to do this? I mean, basically setting the width to the width of the parent container, and have the height calculated (and reported) accordingly?
This could have been possible this way, but in order to react correctly to mouse events there's a "tight" integration between listeners. While it could be possible it represents a big rework.
And anyway I spend some time figuring out what was wrong in bric3/fireplace#79, and fixed the issue.
@thegreystone The view is almost on par with the existing, there's no two outstanding issues, icons for some actions, and export actions.
----
Also.
Since fireplace has now no release yet, it's a bit hard to test this PR for a few reasons :
- The maven p2 plugin replaces `-SNAPSHOT` by a timestamp that is set when the local p2 site is created, not the timestamp of the snapshot artifact. See https://github.com/reficio/p2-maven-plugin/issues/59
- Which means that `.target` files have to be changed locally, after the `mvn p2:site -U` has been run with the actual filename timestamp
e.g. the jar file is `releng/third-party/target/repository/plugins/fireplace-swing_0.0.1.20220804110518.jar` so the version to update in the `.target` files is `0.0.1.20220804110518`
- Don't open the `.target` from the project view, you actually need to open the file using the menu otherwise Eclipse don't see that the `.target` file has changed so it doesn't use the new snapshot version.
I'd like to release a version soon, but I'd like to make sure most things are alright.
-------------
PR: https://git.openjdk.org/jmc/pull/408
More information about the jmc-dev
mailing list