From duke at openjdk.org Thu Apr 6 09:20:20 2023 From: duke at openjdk.org (Pierre-Yves Bigourdan) Date: Thu, 6 Apr 2023 09:20:20 GMT Subject: RFR: 8063: IMCFrame Type cache not synchronized Message-ID: The type cache used in the IMCFrame Type inner class isn't synchronized and can thus cause a concurrent modification exception during e.g. JFR parsing. ------------- Commit messages: - 8063: IMCFrame Type cache not synchronized Changes: https://git.openjdk.org/jmc/pull/476/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=476&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8063 Stats: 10 lines in 1 file changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/476.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/476/head:pull/476 PR: https://git.openjdk.org/jmc/pull/476 From hdafgard at openjdk.org Thu Apr 6 09:20:21 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 6 Apr 2023 09:20:21 GMT Subject: RFR: 8063: IMCFrame Type cache not synchronized In-Reply-To: References: Message-ID: On Thu, 6 Apr 2023 09:12:37 GMT, Pierre-Yves Bigourdan wrote: > The type cache used in the IMCFrame Type inner class isn't synchronized and can thus cause a concurrent modification exception during e.g. JFR parsing. LGTM! ------------- Marked as reviewed by hdafgard (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/476#pullrequestreview-1374411133 From duke at openjdk.org Tue Apr 11 15:15:50 2023 From: duke at openjdk.org (Pierre-Yves Bigourdan) Date: Tue, 11 Apr 2023 15:15:50 GMT Subject: Integrated: 8063: IMCFrame Type cache not synchronized In-Reply-To: References: Message-ID: On Thu, 6 Apr 2023 09:12:37 GMT, Pierre-Yves Bigourdan wrote: > The type cache used in the IMCFrame Type inner class isn't synchronized and can thus cause a concurrent modification exception during e.g. JFR parsing. This pull request has now been integrated. Changeset: 8c0d1298 Author: Pierre-Yves Bigourdan Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/8c0d12982a921d6c7248ecc7cbf5672117715d81 Stats: 10 lines in 1 file changed: 2 ins; 0 del; 8 mod 8063: IMCFrame Type cache not synchronized Reviewed-by: hdafgard ------------- PR: https://git.openjdk.org/jmc/pull/476 From hirt at openjdk.org Wed Apr 12 17:10:44 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 12 Apr 2023 17:10:44 GMT Subject: RFR: 8057: Upgrade to 2023-03 Message-ID: Upgrading to the latest version of the Eclipse platform. ------------- Commit messages: - 8057: Upgrade to Eclipse 2023-03 Changes: https://git.openjdk.org/jmc/pull/477/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=477&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8057 Stats: 113 lines in 5 files changed: 108 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/477.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/477/head:pull/477 PR: https://git.openjdk.org/jmc/pull/477 From hirt at openjdk.org Wed Apr 12 20:19:44 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 12 Apr 2023 20:19:44 GMT Subject: RFR: 8057: Upgrade to 2023-03 In-Reply-To: References: Message-ID: On Wed, 12 Apr 2023 17:05:03 GMT, Marcus Hirt wrote: > Upgrading to the latest version of the Eclipse platform. Hm. java.lang.NoClassDefFoundError: org/owasp/encoder/Encode. ------------- PR Comment: https://git.openjdk.org/jmc/pull/477#issuecomment-1505871690 From hirt at openjdk.org Wed Apr 12 21:31:41 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 12 Apr 2023 21:31:41 GMT Subject: RFR: 8057: Upgrade to 2023-03 In-Reply-To: References: Message-ID: On Wed, 12 Apr 2023 17:05:03 GMT, Marcus Hirt wrote: > Upgrading to the latest version of the Eclipse platform. Hm. Forcing build with -P2022-12 / building from master also fail in the same way. ------------- PR Comment: https://git.openjdk.org/jmc/pull/477#issuecomment-1505973608 From duke at openjdk.org Thu Apr 13 09:54:41 2023 From: duke at openjdk.org (xpbob) Date: Thu, 13 Apr 2023 09:54:41 GMT Subject: RFR: 8065: Remove socket read illegal value Message-ID: ![??](https://user-images.githubusercontent.com/7837910/231721224-245f14e6-d3b7-4cc4-b1d0-b281ffdc272e.png) Socket read failure returns -1 Negative statistics affect accuracy After modification ?? ------------- Commit messages: - 8065: Remove socket read illegal value Changes: https://git.openjdk.org/jmc/pull/478/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8065 Stats: 37 lines in 2 files changed: 35 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/478.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/478/head:pull/478 PR: https://git.openjdk.org/jmc/pull/478 From duke at openjdk.org Thu Apr 13 12:13:32 2023 From: duke at openjdk.org (xpbob) Date: Thu, 13 Apr 2023 12:13:32 GMT Subject: RFR: 8065: Remove socket read illegal value [v2] In-Reply-To: References: Message-ID: > ?? > > > Socket read failure returns -1 > Negative statistics affect accuracy > > After modification > ?? xpbob has updated the pull request incrementally with one additional commit since the last revision: change code style ------------- Changes: - all: https://git.openjdk.org/jmc/pull/478/files - new: https://git.openjdk.org/jmc/pull/478/files/aa4851cc..989ade49 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/478.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/478/head:pull/478 PR: https://git.openjdk.org/jmc/pull/478 From duke at openjdk.org Fri Apr 14 01:27:27 2023 From: duke at openjdk.org (xpbob) Date: Fri, 14 Apr 2023 01:27:27 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: References: Message-ID: > ?? > > > Socket read failure returns -1 > Negative statistics affect accuracy > > After modification > ?? xpbob has updated the pull request incrementally with one additional commit since the last revision: format code ------------- Changes: - all: https://git.openjdk.org/jmc/pull/478/files - new: https://git.openjdk.org/jmc/pull/478/files/989ade49..7cbf73cf Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=01-02 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/478.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/478/head:pull/478 PR: https://git.openjdk.org/jmc/pull/478 From rschmelter at openjdk.org Tue Apr 18 20:17:01 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 18 Apr 2023 20:17:01 GMT Subject: Integrated: 8046: build.bat --packageAgent doesn't detect failed builds In-Reply-To: References: Message-ID: On Mon, 27 Feb 2023 16:36:16 GMT, Ralf Schmelter wrote: > When running build.bat --packageAgent, the build.bat doesn't detect if the maven call fails, since the ERRORLEVEL variable is overridden by the "cd .." call before it is checked. Additionally the format of the if/else construct is wrong (uses curly braces in the else part). This pull request has now been integrated. Changeset: 1fb69d47 Author: Ralf Schmelter Committer: Christoph Langer URL: https://git.openjdk.org/jmc/commit/1fb69d47fa54bbf98e2463c0b07be2272b6f8a87 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod 8046: build.bat --packageAgent doesn't detect failed builds Reviewed-by: clanger, hirt ------------- PR: https://git.openjdk.org/jmc/pull/472 From duke at openjdk.org Thu Apr 20 17:23:47 2023 From: duke at openjdk.org (Virag Purnam) Date: Thu, 20 Apr 2023 17:23:47 GMT Subject: RFR: 8067: JMC Automated Analysis Page shows blank Message-ID: <1Xkpx1kBj2fJEsONxpyZUMDLtG92R380wgNenMcmpJo=.95e0b6b6-2151-4437-9e64-d427cc86e491@github.com> Automated analysis page was showing blank. Log was showing error "**java.lang.NoClassDefFoundError: org/owasp/encoder/Encode**". Imported missing packages in "org.openjdk.jmc.flightrecorder.rules.jdk" and "org.openjdk.jmc.flightrecorder.rules". ------------- Commit messages: - 8067: MC Automated Analysis Page shows blank Changes: https://git.openjdk.org/jmc/pull/479/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=479&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8067 Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/479.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/479/head:pull/479 PR: https://git.openjdk.org/jmc/pull/479 From hirt at openjdk.org Thu Apr 20 19:10:54 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 20 Apr 2023 19:10:54 GMT Subject: RFR: 8067: JMC Automated Analysis Page shows blank In-Reply-To: <1Xkpx1kBj2fJEsONxpyZUMDLtG92R380wgNenMcmpJo=.95e0b6b6-2151-4437-9e64-d427cc86e491@github.com> References: <1Xkpx1kBj2fJEsONxpyZUMDLtG92R380wgNenMcmpJo=.95e0b6b6-2151-4437-9e64-d427cc86e491@github.com> Message-ID: On Thu, 20 Apr 2023 17:17:08 GMT, Virag Purnam wrote: > Automated analysis page was showing blank. Log was showing error "**java.lang.NoClassDefFoundError: org/owasp/encoder/Encode**". > Imported missing packages in "org.openjdk.jmc.flightrecorder.rules.jdk" and "org.openjdk.jmc.flightrecorder.rules". Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/479#pullrequestreview-1394605266 From duke at openjdk.org Fri Apr 21 06:07:49 2023 From: duke at openjdk.org (Virag Purnam) Date: Fri, 21 Apr 2023 06:07:49 GMT Subject: Integrated: 8067: JMC Automated Analysis Page shows blank In-Reply-To: <1Xkpx1kBj2fJEsONxpyZUMDLtG92R380wgNenMcmpJo=.95e0b6b6-2151-4437-9e64-d427cc86e491@github.com> References: <1Xkpx1kBj2fJEsONxpyZUMDLtG92R380wgNenMcmpJo=.95e0b6b6-2151-4437-9e64-d427cc86e491@github.com> Message-ID: On Thu, 20 Apr 2023 17:17:08 GMT, Virag Purnam wrote: > Automated analysis page was showing blank. Log was showing error "**java.lang.NoClassDefFoundError: org/owasp/encoder/Encode**". > Imported missing packages in "org.openjdk.jmc.flightrecorder.rules.jdk" and "org.openjdk.jmc.flightrecorder.rules". This pull request has now been integrated. Changeset: 7d888771 Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/7d8887714ff5f2c8c0065f1e01f53997f5bc85ce Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod 8067: JMC Automated Analysis Page shows blank Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/479 From hirt at openjdk.org Fri Apr 21 08:21:52 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 21 Apr 2023 08:21:52 GMT Subject: RFR: 8057: Upgrade to 2023-03 In-Reply-To: References: Message-ID: On Wed, 12 Apr 2023 17:05:03 GMT, Marcus Hirt wrote: > Upgrading to the latest version of the Eclipse platform. #479 fixed this. ------------- PR Comment: https://git.openjdk.org/jmc/pull/477#issuecomment-1517459060 From hirt at openjdk.org Fri Apr 21 09:35:43 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 21 Apr 2023 09:35:43 GMT Subject: RFR: 8057: Upgrade to 2023-03 [v2] In-Reply-To: References: Message-ID: > Upgrading to the latest version of the Eclipse platform. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Updating l10n ------------- Changes: - all: https://git.openjdk.org/jmc/pull/477/files - new: https://git.openjdk.org/jmc/pull/477/files/a75cebd3..db20cb9b Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=477&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=477&range=00-01 Stats: 20 lines in 5 files changed: 0 ins; 4 del; 16 mod Patch: https://git.openjdk.org/jmc/pull/477.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/477/head:pull/477 PR: https://git.openjdk.org/jmc/pull/477 From hirt at openjdk.org Fri Apr 21 09:39:31 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 21 Apr 2023 09:39:31 GMT Subject: RFR: 8057: Upgrade to 2023-03 [v3] In-Reply-To: References: Message-ID: > Upgrading to the latest version of the Eclipse platform. Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: Fix ------------- Changes: - all: https://git.openjdk.org/jmc/pull/477/files - new: https://git.openjdk.org/jmc/pull/477/files/db20cb9b..7bf100c0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=477&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=477&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/477.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/477/head:pull/477 PR: https://git.openjdk.org/jmc/pull/477 From schaturvedi at openjdk.org Mon Apr 24 00:43:46 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 24 Apr 2023 00:43:46 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. Message-ID: One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. The Automated Analysis screen will look like this: ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. Please review the PR and let me know your review comments. ------------- Commit messages: - 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. Changes: https://git.openjdk.org/jmc/pull/481/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=481&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8050 Stats: 15 lines in 3 files changed: 11 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/481.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/481/head:pull/481 PR: https://git.openjdk.org/jmc/pull/481 From vpurnam at openjdk.org Mon Apr 24 09:33:52 2023 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 24 Apr 2023 09:33:52 GMT Subject: RFR: 8057: Upgrade to 2023-03 [v3] In-Reply-To: References: Message-ID: On Fri, 21 Apr 2023 09:39:31 GMT, Marcus Hirt wrote: >> Upgrading to the latest version of the Eclipse platform. > > Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision: > > Fix Looks good. I have compared the feature versions and versions for 'org.eclipse.babel'. ------------- Marked as reviewed by vpurnam (Committer). PR Review: https://git.openjdk.org/jmc/pull/477#pullrequestreview-1397554867 From hirt at openjdk.org Mon Apr 24 11:52:54 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 24 Apr 2023 11:52:54 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. Hi @Suchitainf! I'm thinking the single line of "Ignored" is eating valuable screen estate, and that it forces you to expand the rule result to see if a result was ignored. Should we perhaps have an "Ignored" result that renders as Ignored instead of N/A? ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1520001619 From hirt at openjdk.org Mon Apr 24 12:00:59 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 24 Apr 2023 12:00:59 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. Also, it would perhaps be less confusing if there wasn't an implicit double negation when presenting the results. Instead of saying: "The rule was not evaluated because the following requirements were not met: X - AVAILABLE, Y - ENABLED." Perhaps instead say, The rule could not be evaluated because: No events available of X, The Y event was disabled." Now, the first time I read it, I read it as X was available, and I was momentarily confused as to it being available would be a problem. ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1520014023 From hirt at openjdk.org Mon Apr 24 12:09:59 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 24 Apr 2023 12:09:59 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: References: Message-ID: <2EJ85umspHw3OrA_mTOo8xkfNfsTlO5vszGIIDBxCeg=.6f77f532-22fe-405b-9ee8-6310349136d6@github.com> On Fri, 14 Apr 2023 01:27:27 GMT, xpbob wrote: >> ?? >> >> >> Socket read failure returns -1 >> Negative statistics affect accuracy >> >> After modification >> ?? > > xpbob has updated the pull request incrementally with one additional commit since the last revision: > > format code Marked as reviewed by hirt (Lead). Thanks for the contribution! ? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/Aggregators.java line 150: > 148: > 149: SumConsumer(IMemberAccessor accessor, Predicate predicate) { > 150: super(accessor); Nit: I think I'd prefer this as this(accessor). ------------- PR Review: https://git.openjdk.org/jmc/pull/478#pullrequestreview-1397832372 PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1520034014 PR Review Comment: https://git.openjdk.org/jmc/pull/478#discussion_r1175189301 From hirt at openjdk.org Mon Apr 24 12:12:59 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 24 Apr 2023 12:12:59 GMT Subject: Integrated: 8057: Upgrade to 2023-03 In-Reply-To: References: Message-ID: On Wed, 12 Apr 2023 17:05:03 GMT, Marcus Hirt wrote: > Upgrading to the latest version of the Eclipse platform. This pull request has now been integrated. Changeset: 06bbd5fe Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/06bbd5feb4f0b18cb8fbce53f447f70f5418a60b Stats: 129 lines in 9 files changed: 108 ins; 4 del; 17 mod 8057: Upgrade to 2023-03 Reviewed-by: vpurnam ------------- PR: https://git.openjdk.org/jmc/pull/477 From bdutheil at openjdk.org Mon Apr 24 14:09:06 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 24 Apr 2023 14:09:06 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization [v5] In-Reply-To: References: Message-ID: <3SavjDCsdQ-kY-DkdOKI0XzJKDy2NeNsrFXOT4ZdWjI=.325935ec-33ad-48b0-b7d7-e2943e0b585e@github.com> > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - fix missing project and classpath, mistakenly removed - Merge branch 'master' into flamegraph-swing - Drop the dash in the module name - Use fireplace 0.0.1-rc3 version in all target - Fix copyrights - Fix copyrights - Use fireplace pre-release 0.0.1-rc3 - Adds zoom animation support - Use the new fireplace swt-swt bridge This may prevent possible race putting the component in an invalid state (when installing the component, then adding data to it). - Use #637CA5 instead of light gray #3b3b3b - ... and 14 more: https://git.openjdk.org/jmc/compare/7d888771...ac58e166 ------------- Changes: https://git.openjdk.org/jmc/pull/408/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=04 Stats: 1201 lines in 35 files changed: 1187 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/408.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/408/head:pull/408 PR: https://git.openjdk.org/jmc/pull/408 From duke at openjdk.org Tue Apr 25 06:14:14 2023 From: duke at openjdk.org (xpbob) Date: Tue, 25 Apr 2023 06:14:14 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: <2EJ85umspHw3OrA_mTOo8xkfNfsTlO5vszGIIDBxCeg=.6f77f532-22fe-405b-9ee8-6310349136d6@github.com> References: <2EJ85umspHw3OrA_mTOo8xkfNfsTlO5vszGIIDBxCeg=.6f77f532-22fe-405b-9ee8-6310349136d6@github.com> Message-ID: <1DIQHKwhE_QO1Cf5DK3-v89bsAfDlBb0LFrR1uWYz2I=.c2162d95-73db-4418-b687-27e3225c42ef@github.com> On Mon, 24 Apr 2023 12:07:06 GMT, Marcus Hirt wrote: >> xpbob has updated the pull request incrementally with one additional commit since the last revision: >> >> format code > > Thanks for the contribution! ? @thegreystone Thanks for the review ------------- PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1521205150 From duke at openjdk.org Tue Apr 25 06:28:20 2023 From: duke at openjdk.org (xpbob) Date: Tue, 25 Apr 2023 06:28:20 GMT Subject: RFR: 8065: Remove socket read illegal value [v4] In-Reply-To: References: Message-ID: > ?? > > > Socket read failure returns -1 > Negative statistics affect accuracy > > After modification > ?? xpbob has updated the pull request incrementally with one additional commit since the last revision: Code modification ------------- Changes: - all: https://git.openjdk.org/jmc/pull/478/files - new: https://git.openjdk.org/jmc/pull/478/files/7cbf73cf..8cc9d1c3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=478&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/478.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/478/head:pull/478 PR: https://git.openjdk.org/jmc/pull/478 From duke at openjdk.org Tue Apr 25 06:29:15 2023 From: duke at openjdk.org (xpbob) Date: Tue, 25 Apr 2023 06:29:15 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: References: Message-ID: <6T4LQUw7EXjQD1h9YxBBkpY7MQ7aIs4ENEYH-PHQQu4=.b308ec0b-f1bd-46b6-abe5-c986a9c38001@github.com> On Fri, 14 Apr 2023 01:27:27 GMT, xpbob wrote: >> ?? >> >> >> Socket read failure returns -1 >> Negative statistics affect accuracy >> >> After modification >> ?? > > xpbob has updated the pull request incrementally with one additional commit since the last revision: > > format code The code has been updated ------------- PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1521218919 From schaturvedi at openjdk.org Tue Apr 25 08:10:14 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 25 Apr 2023 08:10:14 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 11:50:11 GMT, Marcus Hirt wrote: > Hi @Suchitainf! I'm thinking the single line of "Ignored" is eating valuable screen estate, and that it forces you to expand the rule result to see if a result was ignored. Should we perhaps have an "Ignored" result that renders as Ignored instead of N/A? Yes we can do that. ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521351431 From schaturvedi at openjdk.org Tue Apr 25 08:18:13 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 25 Apr 2023 08:18:13 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 11:57:58 GMT, Marcus Hirt wrote: > Also, it would perhaps be less confusing if there wasn't an implicit double negation when presenting the results. Instead of saying: "The rule was not evaluated because the following requirements were not met: X - AVAILABLE, Y - ENABLED." Perhaps instead say, The rule could not be evaluated because: No events available of X, The Y event was disabled." > > Now, the first time I read it, I read it as X was available, and I was momentarily confused as to it being available would be a problem. The event names and their corresponding status which I have shown is the desired / expected combinations. If all the events are present as per the status mentioned then only rule will be calculated. We can show the actual status also but then we need to evaluate the presence of event with their corresponding status just to show on this screen. Because the actual implementation logic is implemented considering fail fast approach i.e. if any one of the condition is not met it will just say Ignored. To be more clear: For ex: To evaluate any rule there are 3 events required with status as Available (A), Enabled (E). Requirement : Event 1 - A , Event 2 .- E, Event 3 - A. Actual : Event 1 - D , Event 2 .- E, Event 3 - A. As per current logic, rule engine will check only for Event 1 - D . Since condition is not met. It will say Ignore. So on this screen, we wont have information about the actual status of Event 2 and Event 3. Although, we can implement this logic just to show the actual status but it will be overhead. That's why I preferred to stick with the Requirement rather than Actual. Your thoughts will be appreciated on this. I can implement accordingly. ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521363683 From hirt at openjdk.org Tue Apr 25 10:31:14 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 25 Apr 2023 10:31:14 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. I think the first thing you'd want to know is what you can do to make the rule be evaluated in the future. I think fail fast is still a good idea, though. Perhaps we can capture at least the first reason it failed? Something along the lines of: So first recording might be: "The rule wasn't evaluated since the event type A wasn't enabled. The requirements for this rule is: * Event A is ENABLED * Event B is AVAILABLE * Event C is AVAILABLE" Then, after enabling A, and getting no events of type C: "The rule wasn't evaluated since no events of type C could be found, even though it was enabled. The requirements for this rule is: * Event A is ENABLED * Event B is AVAILABLE * Event C is AVAILABLE" WDYT? ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521550990 From schaturvedi at openjdk.org Tue Apr 25 11:52:12 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Tue, 25 Apr 2023 11:52:12 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. Sounds good. But in the actual JFRs there are 5 values of status possible and we will have to create several meaningful messages based on permutation and combinations. These are the 5 possible values with their meanings: AVAILABLE(4) : The type has events available in the collection. ENABLED(3) : The type was actively enabled in the collection. DISABLED(2) : The type was actively disabled in the collection. NONE(1) : The type is known in the collection, but no events were found. UNKNOWN(0) : The type is unknown in the collection. ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521655240 From hirt at openjdk.org Tue Apr 25 13:00:18 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 25 Apr 2023 13:00:18 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: <5CimcOFov_-Ik_cHKFxNnIwMQJeNcCX__zsJaqITFhA=.1789f929-8005-491f-b709-41331e02472c@github.com> On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. That's right. I just gave an example. In the end we shortcut for a reason for an expectation on a specific event type. I meant that I think a valid compromise is to report on the first fail to meet the expectations, but always state the full list of expectations. At least the user can take a specific action to get a step closer to have the rule being evaluated. ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1521746102 From hirt at openjdk.org Tue Apr 25 13:01:21 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 25 Apr 2023 13:01:21 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: <6T4LQUw7EXjQD1h9YxBBkpY7MQ7aIs4ENEYH-PHQQu4=.b308ec0b-f1bd-46b6-abe5-c986a9c38001@github.com> References: <6T4LQUw7EXjQD1h9YxBBkpY7MQ7aIs4ENEYH-PHQQu4=.b308ec0b-f1bd-46b6-abe5-c986a9c38001@github.com> Message-ID: On Tue, 25 Apr 2023 06:26:32 GMT, xpbob wrote: >> xpbob has updated the pull request incrementally with one additional commit since the last revision: >> >> format code > > The code has been updated Hi @xpbob! Please /integrate again. ------------- PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1521747929 From duke at openjdk.org Wed Apr 26 03:47:59 2023 From: duke at openjdk.org (xpbob) Date: Wed, 26 Apr 2023 03:47:59 GMT Subject: RFR: 8065: Remove socket read illegal value [v3] In-Reply-To: References: <6T4LQUw7EXjQD1h9YxBBkpY7MQ7aIs4ENEYH-PHQQu4=.b308ec0b-f1bd-46b6-abe5-c986a9c38001@github.com> Message-ID: On Tue, 25 Apr 2023 12:58:51 GMT, Marcus Hirt wrote: >> The code has been updated > > Hi @xpbob! Please /integrate again. Hi @thegreystone Thanks for the review I add tag /integrate ------------- PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1522729018 From duke at openjdk.org Wed Apr 26 08:29:27 2023 From: duke at openjdk.org (xpbob) Date: Wed, 26 Apr 2023 08:29:27 GMT Subject: Integrated: 8065: Remove socket read illegal value In-Reply-To: References: Message-ID: <7P0pqDlq7b2543LGaHs2NlRYS6RjFzPww4XcLt8YpFs=.cd57b0b7-64ca-4c63-ba2b-b241a11ba809@github.com> On Thu, 13 Apr 2023 09:48:30 GMT, xpbob wrote: > ?? > > > Socket read failure returns -1 > Negative statistics affect accuracy > > After modification > ?? This pull request has now been integrated. Changeset: 58c9ede2 Author: bobpengxie Committer: Christoph Langer URL: https://git.openjdk.org/jmc/commit/58c9ede2aa1fb5c966f588f6576514ff0802e002 Stats: 37 lines in 2 files changed: 35 ins; 0 del; 2 mod 8065: Remove socket read illegal value Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/478 From marcus.hirt at datadoghq.com Thu Apr 27 15:29:27 2023 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 27 Apr 2023 17:29:27 +0200 Subject: Proposing to move JMC 9 to JDK 17. Message-ID: Hi all, I propose that we move JMC 9 to use JDK 17 for compiling all parts of JMC 9, including JMC core. The reason is that we need to move to Tycho 3.0 to properly support working with the project in the newer versions of Eclipse. I also propose to require JDK 17 for running all parts of JMC 9, to simplify requirements, and to allow developers to use JDK 17 features when developing JMC. We already require JDK 17 to run the RCP application build of JMC, since newer versions of the Eclipse platform require JDK 17 to run. Note that it will still be possible to connect to, read and process JFR recordings from, and run the other tools (e.g. JOverflow) on processes running JDK 8+. Kind regards, Marcus From miro.wengner at gmail.com Thu Apr 27 18:18:10 2023 From: miro.wengner at gmail.com (Miro Wengner) Date: Thu, 27 Apr 2023 20:18:10 +0200 Subject: Proposing to move JMC 9 to JDK 17. In-Reply-To: References: Message-ID: <024C44F0-F9AB-44D0-B29B-BA008E3AB4BC@gmail.com> +1 Kind Regards Miro > On 27. Apr 2023, at 17:29, Marcus Hirt wrote: > > ?Hi all, > > I propose that we move JMC 9 to use JDK 17 for compiling all parts of > JMC 9, including JMC core. The reason is that we need to move to Tycho > 3.0 to properly support working with the project in the newer versions > of Eclipse. > > I also propose to require JDK 17 for running all parts of JMC 9, to > simplify requirements, and to allow developers to use JDK 17 features > when developing JMC. We already require JDK 17 to run the RCP > application build of JMC, since newer versions of the Eclipse platform > require JDK 17 to run. > > Note that it will still be possible to connect to, read and process > JFR recordings from, and run the other tools (e.g. JOverflow) on > processes running JDK 8+. > > Kind regards, > Marcus From brice.dutheil at gmail.com Fri Apr 28 07:11:12 2023 From: brice.dutheil at gmail.com (Brice Dutheil) Date: Fri, 28 Apr 2023 09:11:12 +0200 Subject: Proposing to move JMC 9 to JDK 17. In-Reply-To: <024C44F0-F9AB-44D0-B29B-BA008E3AB4BC@gmail.com> References: <024C44F0-F9AB-44D0-B29B-BA008E3AB4BC@gmail.com> Message-ID: +1 Non binding -- Brice On Thu 27 Apr 2023 at 20:18 Miro Wengner wrote: > +1 > Kind Regards > Miro > > > On 27. Apr 2023, at 17:29, Marcus Hirt > wrote: > > > > ?Hi all, > > > > I propose that we move JMC 9 to use JDK 17 for compiling all parts of > > JMC 9, including JMC core. The reason is that we need to move to Tycho > > 3.0 to properly support working with the project in the newer versions > > of Eclipse. > > > > I also propose to require JDK 17 for running all parts of JMC 9, to > > simplify requirements, and to allow developers to use JDK 17 features > > when developing JMC. We already require JDK 17 to run the RCP > > application build of JMC, since newer versions of the Eclipse platform > > require JDK 17 to run. > > > > Note that it will still be possible to connect to, read and process > > JFR recordings from, and run the other tools (e.g. JOverflow) on > > processes running JDK 8+. > > > > Kind regards, > > Marcus > -- Brice -------------- next part -------------- An HTML attachment was scrubbed... URL: From bdutheil at openjdk.org Fri Apr 28 08:45:55 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Fri, 28 Apr 2023 08:45:55 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization [v6] In-Reply-To: References: Message-ID: > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits: - Adds fireplace to 2023-3 target - Merge remote-tracking branch 'upstream/master' into flamegraph-swing - fix missing project and classpath, mistakenly removed - Merge branch 'master' into flamegraph-swing - Drop the dash in the module name - Use fireplace 0.0.1-rc3 version in all target - Fix copyrights - Fix copyrights - Use fireplace pre-release 0.0.1-rc3 - Adds zoom animation support - ... and 16 more: https://git.openjdk.org/jmc/compare/58c9ede2...4436e021 ------------- Changes: https://git.openjdk.org/jmc/pull/408/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=05 Stats: 1205 lines in 36 files changed: 1191 ins; 1 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/408.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/408/head:pull/408 PR: https://git.openjdk.org/jmc/pull/408 From christoph.langer at sap.com Fri Apr 28 16:12:54 2023 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 28 Apr 2023 16:12:54 +0000 Subject: Proposing to move JMC 9 to JDK 17. In-Reply-To: References: <024C44F0-F9AB-44D0-B29B-BA008E3AB4BC@gmail.com> Message-ID: Sounds fine and will make things less complicated. ? From: jmc-dev On Behalf Of Brice Dutheil Sent: Freitag, 28. April 2023 09:11 To: Miro Wengner Cc: Marcus Hirt ; jmc-dev at openjdk.java.net Subject: Re: Proposing to move JMC 9 to JDK 17. +1 Non binding -- Brice On Thu 27 Apr 2023 at 20:18 Miro Wengner > wrote: +1 Kind Regards Miro > On 27. Apr 2023, at 17:29, Marcus Hirt > wrote: > > ?Hi all, > > I propose that we move JMC 9 to use JDK 17 for compiling all parts of > JMC 9, including JMC core. The reason is that we need to move to Tycho > 3.0 to properly support working with the project in the newer versions > of Eclipse. > > I also propose to require JDK 17 for running all parts of JMC 9, to > simplify requirements, and to allow developers to use JDK 17 features > when developing JMC. We already require JDK 17 to run the RCP > application build of JMC, since newer versions of the Eclipse platform > require JDK 17 to run. > > Note that it will still be possible to connect to, read and process > JFR recordings from, and run the other tools (e.g. JOverflow) on > processes running JDK 8+. > > Kind regards, > Marcus -- Brice -------------- next part -------------- An HTML attachment was scrubbed... URL: From marcus.hirt at datadoghq.com Fri Apr 28 20:00:00 2023 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Fri, 28 Apr 2023 22:00:00 +0200 Subject: JMC 9 plan Message-ID: Hi all, I am hereby proposing the following plan for JMC 9. Plan: * 2023-11-29 - Rampdown Start (RDS) * 2023-12-27 - Rampdown Phase 2 (RDP2) * 2024-01-24 - Source Release Please let me know if you have any concerns! Kind regards, Marcus