RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules.

Marcus Hirt hirt at openjdk.org
Mon Apr 24 11:52:54 UTC 2023


On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement.
> 
> The Automated Analysis screen will look like this:
> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png)
> 
> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned.
> 
> Please review the PR and let me know your review comments.

Hi @Suchitainf! I'm thinking the single line of "Ignored" is eating valuable screen estate, and that it forces you to expand the rule result to see if a result was ignored. Should we perhaps have an "Ignored" result that renders as Ignored instead of N/A?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1520001619


More information about the jmc-dev mailing list