RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules.

[Marcus Hirt]

On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement.
> 
> The Automated Analysis screen will look like this:
> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png)
> 
> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned.
> 
> Please review the PR and let me know your review comments.

Also, it would perhaps be less confusing if there wasn't an implicit double negation when presenting the results. Instead of saying: "The rule was not evaluated because the following requirements were not met: X - AVAILABLE, Y - ENABLED." Perhaps instead say, The rule could not be evaluated because: No events available of X, The Y event was disabled."

Now, the first time I read it, I read it as X was available, and I was momentarily confused as to it being available would be a problem.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1520014023