RFR: 8065: Remove socket read illegal value [v3]
Marcus Hirt
hirt at openjdk.org
Mon Apr 24 12:09:59 UTC 2023
On Fri, 14 Apr 2023 01:27:27 GMT, xpbob <duke at openjdk.org> wrote:
>> <img width="647" alt="图片" src="https://user-images.githubusercontent.com/7837910/231723450-21839fe4-4454-4e25-bf59-308526ac0c10.png">
>>
>>
>> Socket read failure returns -1
>> Negative statistics affect accuracy
>>
>> After modification
>> <img width="548" alt="图片" src="https://user-images.githubusercontent.com/7837910/231723666-e9dd7983-a8de-4a14-b1e3-3dfad3dc6572.png">
>
> xpbob has updated the pull request incrementally with one additional commit since the last revision:
>
> format code
Marked as reviewed by hirt (Lead).
Thanks for the contribution! 👍
core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/Aggregators.java line 150:
> 148:
> 149: SumConsumer(IMemberAccessor<? extends IQuantity, IItem> accessor, Predicate predicate) {
> 150: super(accessor);
Nit: I think I'd prefer this as this(accessor).
-------------
PR Review: https://git.openjdk.org/jmc/pull/478#pullrequestreview-1397832372
PR Comment: https://git.openjdk.org/jmc/pull/478#issuecomment-1520034014
PR Review Comment: https://git.openjdk.org/jmc/pull/478#discussion_r1175189301
More information about the jmc-dev
mailing list