RFR: 7885: Graphical rendering of dependency view fails due to heap memory drain [v2]

[Virag Purnam]

On Wed, 16 Aug 2023 05:34:36 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

> I also made an attempt to work around this problem with the idea of adding stop flags like I did in #502 . You can find the results over in https://github.com/grandmasterpixel/jmc/tree/more_stop_flags if you are interested (I also did some experiments with making the generation of the graph view go faster in there. Just ignore that). In contrast to making json generation mutually exclusive that would reduce concurrent generation of JSONs by stopping unneeded computations as early as possible. So you do not use heap for JSONs that are thrown away soon anyway. I never made a pull request out of that because I think the real problem is having to use JSONs at all. I found it pretty easy to get OOMEs not because of to heap exhaustion but because of array size limits anyways.

Hi @grandmasterpixel, Sorry for late response as I was occupied with some other tasks and Thanks for your valuable comment. I have just gone through the code changes in  https://github.com/grandmasterpixel/jmc/tree/more_stop_flags. I tried with the changes specific to DependencyView and HaatmapView. With the changes, I do not hit Out Of Memory Error. If you are fine then I would like to take the changes and update this PR. I will overload the method in "IItemCollectionJsonSerializer" class. Method overloading is needed as we are doing changes in JMC core libraries and other consumers of this method will not be impacted. Could you please share your thoughts on this?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/511#issuecomment-1690194339