From jmatsuoka at openjdk.org Fri Dec 1 21:03:53 2023 From: jmatsuoka at openjdk.org (Joshua Matsuoka) Date: Fri, 1 Dec 2023 21:03:53 GMT Subject: Integrated: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core In-Reply-To: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com> References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com> Message-ID: On Thu, 23 Feb 2023 15:51:44 GMT, Joshua Matsuoka wrote: > This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core. > > This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 . > > [0] https://bugs.openjdk.java.net/browse/JMC-7307 This pull request has now been integrated. Changeset: 48162df7 Author: Joshua Matsuoka URL: https://git.openjdk.org/jmc/commit/48162df723e66d910731744958d4ee6188d39263 Stats: 1086 lines in 94 files changed: 326 ins; 604 del; 156 mod 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/469 From aptmac at openjdk.org Fri Dec 1 21:19:50 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Dec 2023 21:19:50 GMT Subject: Integrated: 8144: Add rule to detect GC Inverted Parallelism In-Reply-To: References: Message-ID: On Mon, 30 Oct 2023 15:11:48 GMT, Alex Macdonald wrote: > This PR addresses JMC-8144 [[0]](https://bugs.openjdk.org/browse/JMC-8144). There is a GC log analysis tool called Garbagecat [[1]](https://github.com/mgm3746/garbagecat/tree/main), which operates on GC logs and identifies performance issues and suggests potential solutions (similar to our automated analysis page). One metric Garbagecat flags is **"inverted parallelism"**, which takes a look at the sys+usr time of a parallel GC and compares it against the real (wall) time. If the parallelism is low, this can indicate that the parallel gc is operating at the efficiency of serial gc, and there could be room for improvement. This GC time information is now included in the jdk.GCCPUTime event added in JDK20+. > > This PR requires support for the jdk.GCCPUTime event [[2]](https://bugs.openjdk.org/browse/JDK-8291753), so it also doubles as a PR towards JMC-7895 [[3]](https://bugs.openjdk.org/browse/JMC-7895). > > [0] https://bugs.openjdk.org/browse/JMC-8144 > [1] https://github.com/mgm3746/garbagecat/tree/main > [2] https://bugs.openjdk.org/browse/JDK-8291753 > [3] https://bugs.openjdk.org/browse/JMC-7895 This pull request has now been integrated. Changeset: fea5d67e Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/fea5d67ec0b020d1dc9e5ee1c5bf4435a21bd04e Stats: 937 lines in 14 files changed: 937 ins; 0 del; 0 mod 8144: Add rule to detect GC Inverted Parallelism Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/528 From aptmac at openjdk.org Fri Dec 1 21:21:53 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Dec 2023 21:21:53 GMT Subject: Integrated: 4262: Duplicate headers when copying thread dump text to clipboard In-Reply-To: References: Message-ID: On Mon, 30 Oct 2023 17:31:47 GMT, Alex Macdonald wrote: > This PR addresses JMC-4262 [[0]](https://bugs.openjdk.org/browse/JMC-4262), in which copying thread dump nodes in the tree view exhibits some unexpected behaviour. > > The above issue describes that if you select two nodes from the tree and use the copy context menu action, then the thread dump header gets duplicated. However, what I'm seeing is that the parent thread dump information is also added to the clipboard along side the actual selected information I'm looking for. Further more, if I'm selecting parent nodes from the treeview, I get both the entire thread dump plus the thread dump body (duplicated) for each selected node. > > For example, if I'm trying to copy 2 parent nodes, I end up with 4 thread dump bodies. Or if I'm just trying to copy the entries from GC Threads 0 through 4, I end up with my selection, plus 4 copies of the thread dump. > > This PR adjusts the copy action to use the same functionality used for displaying the selection in the sashform. This way, the selections the user makes in the treeview is what is actually copied into the clipboard. > > Before: > - the clipboard text includes what the user selects in the treeviewer, along with the parent node for each selection > > After: > - clipboard text is based on exactly what the user selects in the treeviewer > > [0] https://bugs.openjdk.org/browse/JMC-4262 This pull request has now been integrated. Changeset: 8dd76834 Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/8dd76834b638c735cb06f6f025f6308e06934e84 Stats: 25 lines in 1 file changed: 0 ins; 19 del; 6 mod 4262: Duplicate headers when copying thread dump text to clipboard Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/529 From aptmac at openjdk.org Fri Dec 1 21:37:47 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Dec 2023 21:37:47 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v4] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Remove duplication of MRITransformationToolkit - Remove flightrecorder.configuration from application/coverage - Fix typo in SyntheticRepositoryInitializer function - Fix typo in license header - Update license headers - Restore rjmx.services.jfr Messages.java - 6627: Bring bundles to core - 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core ------------- Changes: https://git.openjdk.org/jmc/pull/531/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=03 Stats: 12192 lines in 479 files changed: 5692 ins; 5386 del; 1114 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From aptmac at openjdk.org Fri Dec 1 21:37:49 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Dec 2023 21:37:49 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v3] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Wed, 8 Nov 2023 01:01:29 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with three additional commits since the last revision: > > - Remove duplication of MRITransformationToolkit > - Remove flightrecorder.configuration from application/coverage > - Fix typo in SyntheticRepositoryInitializer function Rebasing on top of master now that JMC-7307 [[0]](https://bugs.openjdk.org/browse/JMC-7307) is in: https://github.com/openjdk/jmc/pull/469 Also re-naming this issue to target JMC-7069 [[1]](https://bugs.openjdk.org/browse/JMC-7069), because this deals with the RJMX bundle split + movement, and 6627 was the epic anyways. [0] https://bugs.openjdk.org/browse/JMC-7307 [1] https://bugs.openjdk.org/browse/JMC-7069 ------------- PR Comment: https://git.openjdk.org/jmc/pull/531#issuecomment-1836806670 From aptmac at openjdk.org Fri Dec 1 22:33:29 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 1 Dec 2023 22:33:29 GMT Subject: Integrated: 7449: Add GitHub action to verify copyright year In-Reply-To: References: Message-ID: <-9UOtaybMZrru2e6l-8qfqGh5jt6ylT7hIV9uQAv1jU=.43dfb68f-40d4-4994-a752-778402f29530@github.com> On Wed, 1 Nov 2023 02:24:20 GMT, Alex Macdonald wrote: > This PR looks to address JMC-7449 [[0]](https://bugs.openjdk.org/browse/JMC-7449), in which it'd be nice to have a GitHub action that checks the copyright year of changed files (useful for PR reviews). > > I've added a `check_copyright_year` job to the github workflow, that checks out the repository and then runs a bash script. This bash script lives alongside the `updatecopyrightyear.sh` script and other build-related scripts in `/scripts`. By using `fetch-depth: 0` on the workflow job, we're able to do a git diff against origin/master to get a list of all files that have been altered in a given PR. From there it does a similar file extension check to what `updatecopyrightyear.sh` does, and then uses sed to get the "latest" copyright years (there can be multiple if the header has multiple company names). It compares those years to the current year, and if there is not a match then it prints out the filename to the console and increases a counter that gets printed out when the script returns 1. > > I made a quick test commit ([link](https://github.com/aptmac/jmc/commit/d854e14109d775a8228d729c099463ac8b3a6b8a)) that changed a handful of files without updating their headers, the GH workflow can be found here: https://github.com/aptmac/jmc/actions/runs/6712104409/job/18240941002 > Example of what the workflow looks like: > > Run ./scripts/checkcopyrightyear.sh > Requires update: agent/src/main/java/org/openjdk/jmc/agent/impl/MalformedConverterException.java > Requires update: agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/package-info.java > Requires update: agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/package-info.java > Requires update: application/org.openjdk.jmc.browser/pom.xml > Requires update: application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/JVMBrowserPlugin.java > Requires update: application/org.openjdk.jmc.docs/html/toc.htm > Requires update: application/org.openjdk.jmc.rjmx/build.properties > There is a total of 7 copyright year(s) that require updating. > Error: Process completed with exit code 1. > > > > [0] https://bugs.openjdk.org/browse/JMC-7449 This pull request has now been integrated. Changeset: 51e952e5 Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/51e952e551591c258d732c8f4f22901fb18014a3 Stats: 39 lines in 2 files changed: 39 ins; 0 del; 0 mod 7449: Add GitHub action to verify copyright year Reviewed-by: hirt, clanger ------------- PR: https://git.openjdk.org/jmc/pull/530 From clanger at openjdk.org Fri Dec 1 23:58:54 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 1 Dec 2023 23:58:54 GMT Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v8] In-Reply-To: References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com> Message-ID: <_ldymtyc4uPOMwKWJcKeWfieYjrFoVIGQnVRGSQLMaI=.6aafcbf8-2a9f-4e5f-9a77-1467e7605bf8@github.com> On Thu, 30 Nov 2023 17:13:43 GMT, Joshua Matsuoka wrote: >> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core. >> >> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 . >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7307 > > Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision: > > Update license headers Sorry that I didn't get to review this in time. But overall it looks good. I just created a small follow-up change to clean a few items out: #534. Would be great if somebody can review it. ------------- PR Comment: https://git.openjdk.org/jmc/pull/469#issuecomment-1836936511 From clanger at openjdk.org Sat Dec 2 00:01:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 2 Dec 2023 00:01:20 GMT Subject: RFR: 8149: Cleanup project files after JMC-7307 Message-ID: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> [JMC-7307](https://bugs.openjdk.org/browse/JMC-7307) moved org.openjdk.jmc.flightrecorder.configuration to core. After that, there are a few plugin related files that are obsolete. Also, with latest Eclipse there are some changes in the .classpath files that get generated, e.g. when reimporting Maven projects. We should clean this up and unify .classpath files. ------------- Commit messages: - JMC-8149 Changes: https://git.openjdk.org/jmc/pull/534/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=534&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8149 Stats: 330 lines in 24 files changed: 210 ins; 112 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/534.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/534/head:pull/534 PR: https://git.openjdk.org/jmc/pull/534 From clanger at openjdk.org Sat Dec 2 00:08:00 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sat, 2 Dec 2023 00:08:00 GMT Subject: RFR: 8149: Cleanup project files after JMC-7307 [v2] In-Reply-To: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> References: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> Message-ID: > [JMC-7307](https://bugs.openjdk.org/browse/JMC-7307) moved org.openjdk.jmc.flightrecorder.configuration to core. After that, there are a few plugin related files that are obsolete. > > Also, with latest Eclipse there are some changes in the .classpath files that get generated, e.g. when reimporting Maven projects. We should clean this up and unify .classpath files. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Delete application/tests/org.openjdk.jmc.flightrecorder.configuration.test/.project ------------- Changes: - all: https://git.openjdk.org/jmc/pull/534/files - new: https://git.openjdk.org/jmc/pull/534/files/bea74904..1d21b988 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=534&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=534&range=00-01 Stats: 34 lines in 1 file changed: 0 ins; 34 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/534.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/534/head:pull/534 PR: https://git.openjdk.org/jmc/pull/534 From duke at openjdk.org Sat Dec 2 15:51:52 2023 From: duke at openjdk.org (Francesco Nigro) Date: Sat, 2 Dec 2023 15:51:52 GMT Subject: RFR: 8144: Add rule to detect GC Inverted Parallelism In-Reply-To: References: Message-ID: On Mon, 20 Nov 2023 18:21:35 GMT, Alex Macdonald wrote: >> Looks good. Perhaps a JDK 20 recording should be added to the tests so that some of the rule code is exercised from a recording/events? > >> Looks good. Perhaps a JDK 20 recording should be added to the tests so that some of the rule code is exercised from a recording/events? > > I've added two recordings here, taken on jdk21: > - **jdk21-inverted-parallelism.jfr**: has jdk.GCCPUTime enabled, and runs for ~10 seconds on a stress test application to force an instance of inverted parallelism > - **jdk21.jfr**: enables all events (minus the ones that have my system information), and runs on JMC itself for 1 minute > > Also added a requirement on jdk.GCConfiguration for GcInvertedParallelismRule, and rebased ontop of master. Nice @aptmac ?? ------------- PR Comment: https://git.openjdk.org/jmc/pull/528#issuecomment-1837186987 From aptmac at openjdk.org Sat Dec 2 18:00:50 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Sat, 2 Dec 2023 18:00:50 GMT Subject: RFR: 8149: Cleanup project files after JMC-7307 [v2] In-Reply-To: References: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> Message-ID: <1FsOD0M4Z7ZIdePdsNR5w4-Oz1k7e4jXYHcrwXiTeKc=.e28390cc-31ff-4ae2-8faf-8607b8dc738e@github.com> On Sat, 2 Dec 2023 00:08:00 GMT, Christoph Langer wrote: >> [JMC-7307](https://bugs.openjdk.org/browse/JMC-7307) moved org.openjdk.jmc.flightrecorder.configuration to core. After that, there are a few plugin related files that are obsolete. >> >> Also, with latest Eclipse there are some changes in the .classpath files that get generated, e.g. when reimporting Maven projects. We should clean this up and unify .classpath files. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Delete application/tests/org.openjdk.jmc.flightrecorder.configuration.test/.project Thanks for taking a look and cleaning up these files! Looks good to me, pending the update to license years in the build.properties files. ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/534#pullrequestreview-1760933284 From clanger at openjdk.org Sun Dec 3 11:46:26 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 3 Dec 2023 11:46:26 GMT Subject: RFR: 8149: Cleanup project files after JMC-7307 [v3] In-Reply-To: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> References: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> Message-ID: > [JMC-7307](https://bugs.openjdk.org/browse/JMC-7307) moved org.openjdk.jmc.flightrecorder.configuration to core. After that, there are a few plugin related files that are obsolete. > > Also, with latest Eclipse there are some changes in the .classpath files that get generated, e.g. when reimporting Maven projects. We should clean this up and unify .classpath files. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Update copyright years ------------- Changes: - all: https://git.openjdk.org/jmc/pull/534/files - new: https://git.openjdk.org/jmc/pull/534/files/1d21b988..6dda489b Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=534&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=534&range=01-02 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/534.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/534/head:pull/534 PR: https://git.openjdk.org/jmc/pull/534 From clanger at openjdk.org Sun Dec 3 14:41:51 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 3 Dec 2023 14:41:51 GMT Subject: RFR: 8149: Cleanup project files after JMC-7307 [v2] In-Reply-To: <1FsOD0M4Z7ZIdePdsNR5w4-Oz1k7e4jXYHcrwXiTeKc=.e28390cc-31ff-4ae2-8faf-8607b8dc738e@github.com> References: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> <1FsOD0M4Z7ZIdePdsNR5w4-Oz1k7e4jXYHcrwXiTeKc=.e28390cc-31ff-4ae2-8faf-8607b8dc738e@github.com> Message-ID: <3pXA8EXhcGQY_ocac6rXnvtlvvvxAgx66WovmWBXxXk=.ae106eb8-6e43-4e03-a49d-d0796ee7aa6e@github.com> On Sat, 2 Dec 2023 17:58:25 GMT, Alex Macdonald wrote: > Thanks for taking a look and cleaning up these files! Looks good to me, pending the update to license years in the build.properties files. Thanks for reviewing and thanks for the license year check. ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/534#issuecomment-1837502279 From clanger at openjdk.org Sun Dec 3 14:41:52 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 3 Dec 2023 14:41:52 GMT Subject: Integrated: 8149: Cleanup project files after JMC-7307 In-Reply-To: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> References: <5mch8TSaD3OhMAjwqn8f_v2cAjcQKgq47FaT5tyQdSw=.8e7bfafb-b968-4a4e-b1af-519bdf64ad15@github.com> Message-ID: <2IkHSNyL9OSfkzwy2uZ9jUpfT5FQpVwuDJqbmq-EQ9A=.eb6da54d-ac8f-4f85-bf2c-750ce2395f57@github.com> On Fri, 1 Dec 2023 23:53:56 GMT, Christoph Langer wrote: > [JMC-7307](https://bugs.openjdk.org/browse/JMC-7307) moved org.openjdk.jmc.flightrecorder.configuration to core. After that, there are a few plugin related files that are obsolete. > > Also, with latest Eclipse there are some changes in the .classpath files that get generated, e.g. when reimporting Maven projects. We should clean this up and unify .classpath files. This pull request has now been integrated. Changeset: 9fc022ba Author: Christoph Langer URL: https://git.openjdk.org/jmc/commit/9fc022ba22caba27fa6b7b1066dba01d23a33792 Stats: 368 lines in 25 files changed: 210 ins; 146 del; 12 mod 8149: Cleanup project files after JMC-7307 Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/534 From aptmac at openjdk.org Sun Dec 3 20:00:28 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Sun, 3 Dec 2023 20:00:28 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v5] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: <_iVFxNMovAkRgLZkfUuzox-8UOX5iI3lNas5o8EbTfA=.95649058-4a1a-41d6-a0f9-fe46b783e93d@github.com> > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Remove duplication of MRITransformationToolkit - Remove flightrecorder.configuration from application/coverage - Fix typo in SyntheticRepositoryInitializer function - Fix typo in license header - Update license headers - Restore rjmx.services.jfr Messages.java - 6627: Bring bundles to core ------------- Changes: https://git.openjdk.org/jmc/pull/531/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=04 Stats: 12125 lines in 474 files changed: 5654 ins; 5373 del; 1098 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From aptmac at openjdk.org Sun Dec 3 20:00:31 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Sun, 3 Dec 2023 20:00:31 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v4] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Fri, 1 Dec 2023 21:37:47 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. Rebased one more time now that JMC-8149 has been integrated ([link](https://github.com/openjdk/jmc/pull/534)). ------------- PR Comment: https://git.openjdk.org/jmc/pull/531#issuecomment-1837583703 From aptmac at openjdk.org Mon Dec 4 14:07:41 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Dec 2023 14:07:41 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v6] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: Update license headers flagged by the GH workflow ------------- Changes: - all: https://git.openjdk.org/jmc/pull/531/files - new: https://git.openjdk.org/jmc/pull/531/files/d14b392c..110a7835 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=05 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=04-05 Stats: 13 lines in 12 files changed: 0 ins; 0 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From aptmac at openjdk.org Mon Dec 4 19:07:53 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Dec 2023 19:07:53 GMT Subject: RFR: 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files Message-ID: This PR addresses JMC-8150 [[0]](https://bugs.openjdk.org/browse/JMC-8150), in which the .gitignore entry to ignore the spotbugs generated configuration directories inadvertently ignores the files under `core/org.openjdk.jmc.flightrecorder.configuration/java/org/openjdk/jmc/flightrecorder/configuration`. I noticed this when VSCode wasn't showing any of the flightrecorder.configuration files in my local file search, and it turns out that VSCode takes the .gitignore file into consideration when scanning for local files. When running spotbugs on my Windows machine I see a bunch of generated directories which is what this .gitignore entry was aiming to ignore. Example of generated directories: ![Screenshot from 2023-12-04 13-48-35](https://github.com/openjdk/jmc/assets/10425301/2dc857a1-cabe-4845-8f6b-518889a900c6) This PR simply changes the current `**/configuration/` to `**/configuration/spotbugs` to make it more specific. [0] https://bugs.openjdk.org/browse/JMC-8150 ------------- Commit messages: - 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration java files Changes: https://git.openjdk.org/jmc/pull/535/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=535&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8150 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/535.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/535/head:pull/535 PR: https://git.openjdk.org/jmc/pull/535 From clanger at openjdk.org Mon Dec 4 21:27:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 4 Dec 2023 21:27:50 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v6] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Mon, 4 Dec 2023 14:07:41 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: > > Update license headers flagged by the GH workflow I played with this and figured some minor suggestions. application/org.openjdk.jmc.rjmx/META-INF/MANIFEST.MF line 48: > 46: org.openjdk.jmc.rjmx.services.jfr.test, > 47: org.openjdk.jmc.rjmx.test", > 48: org.openjdk.jmc.rjmx.services.internal;x-friends:="org.openjdk.jmc.rjmx.test", Line 55 ` org.openjdk.jmc.rjmx.subscription.storage.internal;x-internal:=true,` has to be removed, otherwise I see an error in Eclipse. core/org.openjdk.jmc.rjmx.common/build.properties line 39: > 37: . > 38: pde.match.rule.bundle=compatible > 39: jre.compilation.profile = JavaSE-17 I think this line can go (jre.compilation.profile), at least it is not in the other build.properties of modules in core. Please also add a linebreak in the end. core/org.openjdk.jmc.rjmx.common/pom.xml line 42: > 40: > 41: rjmx.common > 42: Can you put the section after to follow suit with the style of the other pom.xml files? Also, the indentation has a few flaws. ------------- Changes requested by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/531#pullrequestreview-1762127739 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1414516501 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1414484122 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1414485789 From clanger at openjdk.org Mon Dec 4 21:27:53 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 4 Dec 2023 21:27:53 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v5] In-Reply-To: <_iVFxNMovAkRgLZkfUuzox-8UOX5iI3lNas5o8EbTfA=.95649058-4a1a-41d6-a0f9-fe46b783e93d@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> <_iVFxNMovAkRgLZkfUuzox-8UOX5iI3lNas5o8EbTfA=.95649058-4a1a-41d6-a0f9-fe46b783e93d@github.com> Message-ID: On Sun, 3 Dec 2023 20:00:28 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: > > - Remove duplication of MRITransformationToolkit > - Remove flightrecorder.configuration from application/coverage > - Fix typo in SyntheticRepositoryInitializer function > - Fix typo in license header > - Update license headers > - Restore rjmx.services.jfr Messages.java > - 6627: Bring bundles to core application/org.openjdk.jmc.rjmx/pom.xml line 46: > 44: ${project.basedir}/../../configuration > 45: > 46: This looks awkward here. I think the dependency should only be resolved via MANIFEST.MF, no in pom.xml here. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1413704726 From aptmac at openjdk.org Mon Dec 4 21:33:51 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Dec 2023 21:33:51 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v5] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> <_iVFxNMovAkRgLZkfUuzox-8UOX5iI3lNas5o8EbTfA=.95649058-4a1a-41d6-a0f9-fe46b783e93d@github.com> Message-ID: On Mon, 4 Dec 2023 10:57:06 GMT, Christoph Langer wrote: >> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: >> >> - Remove duplication of MRITransformationToolkit >> - Remove flightrecorder.configuration from application/coverage >> - Fix typo in SyntheticRepositoryInitializer function >> - Fix typo in license header >> - Update license headers >> - Restore rjmx.services.jfr Messages.java >> - 6627: Bring bundles to core > > application/org.openjdk.jmc.rjmx/pom.xml line 46: > >> 44: ${project.basedir}/../../configuration >> 45: >> 46: > > This looks awkward here. I think the dependency should only be resolved via MANIFEST.MF, no in pom.xml here. Ah good catch, thanks for finding that. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1414525609 From aptmac at openjdk.org Mon Dec 4 22:03:58 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 4 Dec 2023 22:03:58 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v7] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: Address initial review comments ------------- Changes: - all: https://git.openjdk.org/jmc/pull/531/files - new: https://git.openjdk.org/jmc/pull/531/files/110a7835..5a55147a Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=06 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=05-06 Stats: 22 lines in 5 files changed: 8 ins; 12 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From clanger at openjdk.org Tue Dec 5 07:58:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 5 Dec 2023 07:58:50 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v7] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Mon, 4 Dec 2023 22:03:58 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: > > Address initial review comments Looks good to me now. One minor comment. core/org.openjdk.jmc.rjmx.common/pom.xml line 56: > 54: ${project.version} > 55: > 56: Indentation in this line is still wrong. ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/531#pullrequestreview-1764222438 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415051376 From clanger at openjdk.org Tue Dec 5 08:00:47 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 5 Dec 2023 08:00:47 GMT Subject: RFR: 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files In-Reply-To: References: Message-ID: On Mon, 4 Dec 2023 18:50:02 GMT, Alex Macdonald wrote: > This PR addresses JMC-8150 [[0]](https://bugs.openjdk.org/browse/JMC-8150), in which the .gitignore entry to ignore the spotbugs generated configuration directories inadvertently ignores the files under `core/org.openjdk.jmc.flightrecorder.configuration/java/org/openjdk/jmc/flightrecorder/configuration`. > > I noticed this when VSCode wasn't showing any of the flightrecorder.configuration files in my local file search, and it turns out that VSCode takes the .gitignore file into consideration when scanning for local files. > > When running spotbugs on my Windows machine I see a bunch of generated directories which is what this .gitignore entry was aiming to ignore. > > Example of generated directories: > ![Screenshot from 2023-12-04 13-48-35](https://github.com/openjdk/jmc/assets/10425301/2dc857a1-cabe-4845-8f6b-518889a900c6) > > This PR simply changes the current `**/configuration/` to `**/configuration/spotbugs` to make it more specific. > > [0] https://bugs.openjdk.org/browse/JMC-8150 Looks good and trivial ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/535#pullrequestreview-1764236210 From clanger at openjdk.org Tue Dec 5 08:21:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 5 Dec 2023 08:21:50 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v7] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Mon, 4 Dec 2023 22:03:58 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: > > Address initial review comments I spotted a few Javadoc errors. You'll find them in the logs when building core. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/labelingrules/NameConverter.java line 48: > 46: > 47: /** > 48: * Converts names according to rules specified with the {@value #LABELING_RULES_EXTENSION_POINT} This causes a Javadoc error, same in line 143 ` * {@value #LABELING_RULES_EXTENSION_POINT} extension point.` core/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/IFlightRecorderService.java line 50: > 48: > 49: /** > 50: * This is the interface for the JDK Flight Recorder controller. Line 53 below has a Javadoc error: `error: reference not found * {@link IConnectionHandle#getServiceOrNull(Class)}` and there are a few more Javadoc errors in this file. core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/ISyntheticNotification.java line 36: > 34: > 35: import javax.management.MBeanServerConnection; > 36: import javax.management.modelmbean.ModelMBeanNotificationBroadcaster; Line 63 uses unsupported tag for Javadoc. core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/RJMXCorePlugin.java line 40: > 38: > 39: /** > 40: * There is one instance of the RJMX plugin available from {@link RJMXPlugin#getDefault()}. The This line causes a Javadoc error. core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/services/jfr/package-info.java line 5: > 3: * > 4: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > 5: * Line 67-69 below exhibit Javadoc errors. ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/531#pullrequestreview-1764287671 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415090339 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415095911 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415105274 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415100667 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415103135 From aptmac at openjdk.org Tue Dec 5 12:00:50 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 12:00:50 GMT Subject: Integrated: 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files In-Reply-To: References: Message-ID: On Mon, 4 Dec 2023 18:50:02 GMT, Alex Macdonald wrote: > This PR addresses JMC-8150 [[0]](https://bugs.openjdk.org/browse/JMC-8150), in which the .gitignore entry to ignore the spotbugs generated configuration directories inadvertently ignores the files under `core/org.openjdk.jmc.flightrecorder.configuration/java/org/openjdk/jmc/flightrecorder/configuration`. > > I noticed this when VSCode wasn't showing any of the flightrecorder.configuration files in my local file search, and it turns out that VSCode takes the .gitignore file into consideration when scanning for local files. > > When running spotbugs on my Windows machine I see a bunch of generated directories which is what this .gitignore entry was aiming to ignore. > > Example of generated directories: > ![Screenshot from 2023-12-04 13-48-35](https://github.com/openjdk/jmc/assets/10425301/2dc857a1-cabe-4845-8f6b-518889a900c6) > > This PR simply changes the current `**/configuration/` to `**/configuration/spotbugs` to make it more specific. > > [0] https://bugs.openjdk.org/browse/JMC-8150 This pull request has now been integrated. Changeset: 5d6d928d Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/5d6d928dc84a9a574978dc6bb66aeb532e44eb01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8150: SpotBugs entry in .gitignore hides flightrecorder.configuration files Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jmc/pull/535 From aptmac at openjdk.org Tue Dec 5 12:47:51 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 12:47:51 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v7] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Tue, 5 Dec 2023 07:55:31 GMT, Christoph Langer wrote: >> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: >> >> Address initial review comments > > core/org.openjdk.jmc.rjmx.common/pom.xml line 56: > >> 54: ${project.version} >> 55: >> 56: > > Indentation in this line is still wrong. Ah, thank you now I see it. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415549896 From aptmac at openjdk.org Tue Dec 5 14:16:50 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 14:16:50 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v7] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: <96Eq3i63mctiTUlVs2QiUuSwPQ0Pn-4DQNWiqxHFL7Y=.41837f57-cda4-45f3-b7ac-a0088c6f93f7@github.com> On Tue, 5 Dec 2023 08:19:02 GMT, Christoph Langer wrote: > I spotted a few Javadoc errors. You'll find them in the logs when building core. Thanks for pointing them out, I see these now. It looks like there's some javadoc errors from flightrecorder.configuration as well, I'll address them in my next commit. ------------- PR Comment: https://git.openjdk.org/jmc/pull/531#issuecomment-1840875177 From aptmac at openjdk.org Tue Dec 5 14:54:35 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 14:54:35 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v8] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: <0yPMJSGyM0cXO4aR41iz9cGbAf0J4Gv5Duom0lk-wpY=.b25ffafb-aa1d-4f5e-8a69-0caeee8d05d1@github.com> > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision: - Fix javadoc errors - Fix indent spacing in rjmx.common pom ------------- Changes: - all: https://git.openjdk.org/jmc/pull/531/files - new: https://git.openjdk.org/jmc/pull/531/files/5a55147a..c587ce0e Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=07 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=06-07 Stats: 21 lines in 8 files changed: 0 ins; 8 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From clanger at openjdk.org Tue Dec 5 16:18:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 5 Dec 2023 16:18:55 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v8] In-Reply-To: <0yPMJSGyM0cXO4aR41iz9cGbAf0J4Gv5Duom0lk-wpY=.b25ffafb-aa1d-4f5e-8a69-0caeee8d05d1@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> <0yPMJSGyM0cXO4aR41iz9cGbAf0J4Gv5Duom0lk-wpY=.b25ffafb-aa1d-4f5e-8a69-0caeee8d05d1@github.com> Message-ID: On Tue, 5 Dec 2023 14:54:35 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision: > > - Fix javadoc errors > - Fix indent spacing in rjmx.common pom Now it's close to perfect. ? One extremely minor suggestion left. core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/services/jfr/package-info.java line 68: > 66: * long duration = 5000; > 67: * IConstrainedMap<String> defaultRecordingOptions = jfr.getDefaultRecordingOptions(); > 68: * IDescribedMap<EventOptionID> defaultEventOptions = jfr.getDefaultEventOptions(); Maybe you can fix the indentation in this line, too. ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/531#pullrequestreview-1765523521 PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1415892463 From aptmac at openjdk.org Tue Dec 5 17:49:59 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 17:49:59 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v9] In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: Fix indent in rjmx.common.services.jfr package-info.java ------------- Changes: - all: https://git.openjdk.org/jmc/pull/531/files - new: https://git.openjdk.org/jmc/pull/531/files/c587ce0e..38b683ee Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=08 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=531&range=07-08 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/531.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/531/head:pull/531 PR: https://git.openjdk.org/jmc/pull/531 From aptmac at openjdk.org Tue Dec 5 17:50:01 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 5 Dec 2023 17:50:01 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v8] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> <0yPMJSGyM0cXO4aR41iz9cGbAf0J4Gv5Duom0lk-wpY=.b25ffafb-aa1d-4f5e-8a69-0caeee8d05d1@github.com> Message-ID: On Tue, 5 Dec 2023 16:14:40 GMT, Christoph Langer wrote: >> Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision: >> >> - Fix javadoc errors >> - Fix indent spacing in rjmx.common pom > > core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/services/jfr/package-info.java line 68: > >> 66: * long duration = 5000; >> 67: * IConstrainedMap<String> defaultRecordingOptions = jfr.getDefaultRecordingOptions(); >> 68: * IDescribedMap<EventOptionID> defaultEventOptions = jfr.getDefaultEventOptions(); > > Maybe you can fix the indentation in this line, too. Ah thanks again for the keen eye ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1416063827 From duke at openjdk.org Wed Dec 6 19:53:58 2023 From: duke at openjdk.org (Austin Brooks) Date: Wed, 6 Dec 2023 19:53:58 GMT Subject: RFR: 7576: Remove the need for a local jetty server for dependencies [v2] In-Reply-To: References: Message-ID: On Wed, 25 Oct 2023 17:23:10 GMT, Marcus Hirt wrote: >> Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: >> >> - Update latest targets to point to third-party >> - Merge branch 'master' into removeJettyMerged >> - Remove references to third-party from scripts/ >> - Fix clean target trying to access third-party directory >> - XXX: Remove needing to use a local jetty server for dependencies > > Hi @abrooksv! Is this something you'd like to get into JMC 9? Do you know if your changes will work well in the PDE / Eclipse? Hey @thegreystone, it was rough around the edges in Eclipse at the time, but PDE and Tycho were also a moving target in their improvements in the area. I am not sure the state of it now since I have not used Eclipse in over a year ------------- PR Comment: https://git.openjdk.org/jmc/pull/387#issuecomment-1843589348 From aptmac at openjdk.org Thu Dec 7 20:03:40 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 7 Dec 2023 20:03:40 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v9] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Tue, 5 Dec 2023 17:49:59 GMT, Alex Macdonald wrote: >> This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). >> >> While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. >> >> As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. >> >> There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. >> >> [0] https://bugs.openjdk.org/browse/JMC-6627 >> [1] https://github.com/openjdk/jmc/pull/469 >> [2] https://bugs.openjdk.org/browse/JMC-7307 >> [3] https://bugs.openjdk.org/browse/JMC-7069 >> [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f >> [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 > > Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision: > > Fix indent in rjmx.common.services.jfr package-info.java As mentioned in the bi-weekly dev team meeting yesterday, Marcus gave this PR the rubber stamp of approval and mentioned it should go in soon to allow more time for testing and potential fixes during rampdown 1. I gave it the day to sit just in-case there were any straggling reviews, but plan on integrating this shortly as a heads up. ------------- PR Comment: https://git.openjdk.org/jmc/pull/531#issuecomment-1846025463 From hirt at openjdk.org Thu Dec 7 20:51:38 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 7 Dec 2023 20:51:38 GMT Subject: RFR: 8154: Some JMX attributes are missing unit specifications in the Console Message-ID: I also noticed that TotalPhysicalMemorySize had been deprecated. I'll keep using it though, so that the console will keep working with pre-JDK 14 versions of the JDK. ------------- Commit messages: - Use same case for deprecated - 8154: Adding MRI Metadata for some attributes missing it Changes: https://git.openjdk.org/jmc/pull/536/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=536&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8154 Stats: 28 lines in 1 file changed: 25 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/536.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/536/head:pull/536 PR: https://git.openjdk.org/jmc/pull/536 From clanger at openjdk.org Thu Dec 7 21:32:35 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 7 Dec 2023 21:32:35 GMT Subject: RFR: 8154: Some JMX attributes are missing unit specifications in the Console In-Reply-To: References: Message-ID: <5MncArKlgL4EYBTDgoFc8tVu81wNBmCuBF3uktM5DLw=.cf751e40-158a-4739-92e4-cc67917f89fd@github.com> On Thu, 7 Dec 2023 20:45:52 GMT, Marcus Hirt wrote: > I also noticed that TotalPhysicalMemorySize had been deprecated. I'll keep using it though, so that the console will keep working with pre-JDK 14 versions of the JDK. LGTM ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/536#pullrequestreview-1771161031 From clanger at openjdk.org Thu Dec 7 21:53:27 2023 From: clanger at openjdk.org (Christoph Langer) Date: Thu, 7 Dec 2023 21:53:27 GMT Subject: RFR: 7069: Move rjmx bundle from application to core [v9] In-Reply-To: References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: <_lpJ5ExKPR0HLR7ONwOnsdCk-6w-QHP2-sMoshOuCjo=.176cf84b-6443-4850-adc8-b4388fe03d8a@github.com> On Thu, 7 Dec 2023 20:00:42 GMT, Alex Macdonald wrote: > As mentioned in the bi-weekly dev team meeting yesterday, Marcus gave this PR the rubber stamp of approval and mentioned it should go in soon to allow more time for testing and potential fixes during rampdown 1. I gave it the day to sit just in-case there were any straggling reviews, but plan on integrating this shortly as a heads up. Yes, sure, please integrate. ? ------------- PR Comment: https://git.openjdk.org/jmc/pull/531#issuecomment-1846164720 From aptmac at openjdk.org Thu Dec 7 22:20:28 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 7 Dec 2023 22:20:28 GMT Subject: Integrated: 7069: Move rjmx bundle from application to core In-Reply-To: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> References: <9wthogRbq4YBsRzMYmr-lYCwotywABIpVGbxzjXXzPc=.c55e1e10-b0ab-4f98-8393-3e11293fc9c3@github.com> Message-ID: On Fri, 3 Nov 2023 19:11:38 GMT, Alex Macdonald wrote: > This PR addresses JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627) in which it would be nice to bring some bundles from application to core. Most notably, **flightrecorder.configuration** which has a PR open for review [[1]](https://github.com/openjdk/jmc/pull/469) and is also tracked by JMC-7307 [[2]](https://bugs.openjdk.org/browse/JMC-7307), and **RJMX** which is also tracked by JMC-7069 [[3]](https://bugs.openjdk.org/browse/JMC-7069). > > While #469 is still under review, I copied a branch of it and squashed all the commits down into one commit [[4]](https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f) for easier rebasing. Review comments for flightrecorder.configuration should go towards #469. RJMX does have reliance on the flightrecorder.configuration changes (and some still in ui.common), so the second commit [[5]](https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72) here is where this PR really starts. Once #469 is merged I can rebase this PR so that it handles RJMX. > > As mentioned in JMC-6627 [[0]](https://bugs.openjdk.org/browse/JMC-6627), because of the way Eclipse is intertwined with the RJMX code, this isn't a straightforward movement of classes. There are some parts that will need to stay on the side of jmc/application, but much of the code can come over to jmc/core with modification. This is accomplished by having a `rjmx.common` module in core, and keeping regular `rjmx` in application. > > There are a handful of classes (e.g., `NameConverter`, `SyntheticAttributeRepository`, `SyntheticNotificationRepository`, ..) that use Eclipse to initialize them by parsing through values in plugin.xml, or use classes (like Persistence and Preferences) that are closely tied to the Eclipse RCP side of things. I brought over these classes to core and kept the code that initializes the values from extensions on the application side, so they could be set from application -> core when running JMC, but for third-party applications that want to use the RJMX code then they might not need/require this initialization. > > [0] https://bugs.openjdk.org/browse/JMC-6627 > [1] https://github.com/openjdk/jmc/pull/469 > [2] https://bugs.openjdk.org/browse/JMC-7307 > [3] https://bugs.openjdk.org/browse/JMC-7069 > [4] https://github.com/openjdk/jmc/commit/72c08b3f65671d16fcbb1333a5782e10ac9c874f > [5] https://github.com/openjdk/jmc/commit/f1c828dd46f24d9075cd3eedbf5a15bb9daf9a72 This pull request has now been integrated. Changeset: 8635f415 Author: Alex Macdonald URL: https://git.openjdk.org/jmc/commit/8635f415e507a6ef876b540fffc6d8ea3c21ef42 Stats: 12317 lines in 475 files changed: 5737 ins; 5468 del; 1112 mod 7069: Move rjmx bundle from application to core Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jmc/pull/531 From hirt at openjdk.org Fri Dec 8 12:17:27 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 8 Dec 2023 12:17:27 GMT Subject: Integrated: 8154: Some JMX attributes are missing unit specifications in the Console In-Reply-To: References: Message-ID: On Thu, 7 Dec 2023 20:45:52 GMT, Marcus Hirt wrote: > I also noticed that TotalPhysicalMemorySize had been deprecated. I'll keep using it though, so that the console will keep working with pre-JDK 14 versions of the JDK. This pull request has now been integrated. Changeset: 3cf45bb1 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/3cf45bb1de9bc98a206127d51ec658cb890d827b Stats: 28 lines in 1 file changed: 25 ins; 0 del; 3 mod 8154: Some JMX attributes are missing unit specifications in the Console Reviewed-by: clanger ------------- PR: https://git.openjdk.org/jmc/pull/536 From aptmac at openjdk.org Fri Dec 8 16:08:38 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 8 Dec 2023 16:08:38 GMT Subject: RFR: 5994: Ensure dropins folder works Message-ID: This short PR looks to address JMC-5994 [[0]](https://bugs.openjdk.org/browse/JMC-5994), in which the plugin dropins folder does not work for JMC. The idea behind the dropins folder is that you can place an external Eclipse plugin directly into the folder and it'll be loaded by Eclipse into JMC during application start. Taking a look at the debug logs, it looks like there are a couple of features that are missing that are required for running UI related plugins (`org.eclipse.ui.ide` & `org.eclipse.ui.editors`). The issue description [0] mentions checking if the dropins functionality worked in JMC 6, as it was also not working in JMC 7, so this looks to be a long-running issue. I've created a very basic plugin that can be found here for testing purposes: https://github.com/aptmac/5994-dummy-plugin To test this PR you can place the dummy folder into the dropins folder and verify the installation using the dialog at `Help -> About JDK Mission Control -> Installation Details -> Plug-ins`. You can also place the `.option` file into the same directory as your build jmc application and then run jmc using the debug console: `./jmc -debug -console -consoleLog` **Before:** Log: !ENTRY org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 !MESSAGE Problems resolving provisioning plan. !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.editors 0.0.0. !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.ide 0.0.0. Installation Details: ![before](https://github.com/openjdk/jmc/assets/10425301/c1c7f5f6-5fa4-4a9f-a8f4-2d9f26d76431) **After:** Log: [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Cached timestamp file empty. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Performing reconciliation. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] [dropins] Interesting feature or bundle added: /home/aptmac/workspace/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK Mission Control/dropins/dummy [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Timestamp file does not exist. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Performing reconciliation. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Profile timestamp not found in cache. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Performing reconciliation. [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Adding IU: dummy 1.0.0.qualifier [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Adding IU property: dummy 1.0.0.qualifier->{org.eclipse.equinox.p2.type.lock=1, org.eclipse.equinox.p2.internal.inclusion.rules=OPTIONAL, org.eclipse.equinox.p2.reconciler.dropins=true} Installation Details: ![after](https://github.com/openjdk/jmc/assets/10425301/1633255e-1f7e-4842-9994-750dee962711) Additions to the features directory: ![features](https://github.com/openjdk/jmc/assets/10425301/6d5cce1b-3701-4e90-94d6-6023c0ef65e9) [0] https://bugs.openjdk.org/browse/JMC-5994 ------------- Commit messages: - 5994: Ensure dropins folder works Changes: https://git.openjdk.org/jmc/pull/537/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=537&range=00 Issue: https://bugs.openjdk.org/browse/JMC-5994 Stats: 14 lines in 1 file changed: 14 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/537.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/537/head:pull/537 PR: https://git.openjdk.org/jmc/pull/537 From schaturvedi at openjdk.org Sun Dec 10 23:08:40 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sun, 10 Dec 2023 23:08:40 GMT Subject: RFR: 5560: Support new nio events in JDK 10. [v2] In-Reply-To: References: Message-ID: > This PR addresses the enhancement request of missing event File Force. > 1. A new rule File Force has been added to the "Automated Analysis Page", Under Java Application -> File I/O. > image > > 2. "File I/O" screen is updated to accomodate values for the new event. There are two new columns added - Force Count, Update Metadata. Both these columns are hidden by default and user need to make them visible by right clicking the header of the table. Also the corresponding chart for File Force Event has been introduced. > image > > 3. There is a new preference/configuration introduced for the File Force Rule. > > image Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Implemented review comments ------------- Changes: - all: https://git.openjdk.org/jmc/pull/533/files - new: https://git.openjdk.org/jmc/pull/533/files/f974d6f9..17121e6a Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=533&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=533&range=00-01 Stats: 236 lines in 9 files changed: 123 ins; 97 del; 16 mod Patch: https://git.openjdk.org/jmc/pull/533.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/533/head:pull/533 PR: https://git.openjdk.org/jmc/pull/533 From schaturvedi at openjdk.org Mon Dec 11 02:12:43 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 11 Dec 2023 02:12:43 GMT Subject: RFR: 4263: Support monitor inflation event in JMC Message-ID: <9jk-4-9F_En4TGULJ9pcckJZVJ7PZDzckcvodTBT_DQ=.11ac4a40-bb88-43ad-a076-406410891f56@github.com> Included monitor inflate events on Lock Instance page. Two columns "Inflated Count" and "Inflation reason" are added to all the three tables - Monitor class, Monitor address and Thread. Both the columns are hidden by default which can be made visible by column header settings. image ------------- Commit messages: - 4263: Support monitor inflation event in JMC Changes: https://git.openjdk.org/jmc/pull/538/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=538&range=00 Issue: https://bugs.openjdk.org/browse/JMC-4263 Stats: 30 lines in 7 files changed: 26 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/538.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/538/head:pull/538 PR: https://git.openjdk.org/jmc/pull/538 From hirt at openjdk.org Mon Dec 11 17:59:30 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 11 Dec 2023 17:59:30 GMT Subject: RFR: 5994: Ensure dropins folder works In-Reply-To: References: Message-ID: <1doqljlabRDhriPowjNL8-IQsQRLtpZwzUIgTdbSX6U=.b49afa7a-5962-4047-867e-841ed19abf23@github.com> On Fri, 8 Dec 2023 16:04:08 GMT, Alex Macdonald wrote: > This short PR looks to address JMC-5994 [[0]](https://bugs.openjdk.org/browse/JMC-5994), in which the plugin dropins folder does not work for JMC. > > The idea behind the dropins folder is that you can place an external Eclipse plugin directly into the folder and it'll be loaded by Eclipse into JMC during application start. Taking a look at the debug logs, it looks like there are a couple of features that are missing that are required for running UI related plugins (`org.eclipse.ui.ide` & `org.eclipse.ui.editors`). The issue description [0] mentions checking if the dropins functionality worked in JMC 6, as it was also not working in JMC 7, so this looks to be a long-running issue. > > I've created a very basic plugin that can be found here for testing purposes: https://github.com/aptmac/5994-dummy-plugin > > To test this PR you can place the dummy folder into the dropins folder and verify the installation using the dialog at `Help -> About JDK Mission Control -> Installation Details -> Plug-ins`. You can also place the `.option` file into the same directory as your build jmc application and then run jmc using the debug console: `./jmc -debug -console -consoleLog` > > **Before:** > Log: > > !ENTRY org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Problems resolving provisioning plan. > !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.editors 0.0.0. > !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.ide 0.0.0. > > > Installation Details: > ![before](https://github.com/openjdk/jmc/assets/10425301/c1c7f5f6-5fa4-4a9f-a8f4-2d9f26d76431) > > **After:** > Log: > > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Cached timestamp file empty. > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Performing reconciliation. > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] [dropins] Interesting feature or bundle added: /home/aptmac/workspace/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK Mission Control/dropins/dummy > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Ti... Nice! Do we get any additional preference pages that we may want to filter out, or any other potentially unwanted contributed behaviour from including these plug-ins? ------------- PR Comment: https://git.openjdk.org/jmc/pull/537#issuecomment-1850590309 From aptmac at openjdk.org Mon Dec 11 18:09:32 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 11 Dec 2023 18:09:32 GMT Subject: RFR: 5994: Ensure dropins folder works In-Reply-To: <1doqljlabRDhriPowjNL8-IQsQRLtpZwzUIgTdbSX6U=.b49afa7a-5962-4047-867e-841ed19abf23@github.com> References: <1doqljlabRDhriPowjNL8-IQsQRLtpZwzUIgTdbSX6U=.b49afa7a-5962-4047-867e-841ed19abf23@github.com> Message-ID: On Mon, 11 Dec 2023 17:56:55 GMT, Marcus Hirt wrote: > Nice! Do we get any additional preference pages that we may want to filter out, or any other potentially unwanted contributed behaviour from including these plug-ins? Good question, I'll poke around a bit more around the ui and see if there's anything extra added. ------------- PR Comment: https://git.openjdk.org/jmc/pull/537#issuecomment-1850609864 From ckozak at ckozak.net Wed Dec 13 15:19:12 2023 From: ckozak at ckozak.net (Carter Kozak) Date: Wed, 13 Dec 2023 10:19:12 -0500 Subject: IOToolkit.openUncompressedStream silently fails to decompresses certain InputStreams Message-ID: <185ab3cc-c48e-4873-8a49-5c60ba1ff9c5@app.fastmail.com> Hi all, The IOToolkit.openUncompressedStream utility in JMC only seems to decompress streams which support mark/reset, returning the input otherwise. Within JMC this seems not to cause any issues because the input is usually a file, however using this functionality as a library produces unexpected behavior where compressed recordings appear corrupted. I'd be grateful if anyone could help me create a JMC issue for this, I lack permissions to do so myself. I have proposed a fix here: https://github.com/openjdk/jmc/pull/539 Thanks, Carter Kozak -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Wed Dec 13 15:43:16 2023 From: duke at openjdk.org (Carter Kozak) Date: Wed, 13 Dec 2023 15:43:16 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams Message-ID: Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. The new tests in this commit fail without the accompanying change to `IOToolkit.java`. I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). ------------- Commit messages: - 8159: openUncompressedStream supports compressed inputs on all streams Changes: https://git.openjdk.org/jmc/pull/539/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=539&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8159 Stats: 72 lines in 2 files changed: 52 ins; 6 del; 14 mod Patch: https://git.openjdk.org/jmc/pull/539.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/539/head:pull/539 PR: https://git.openjdk.org/jmc/pull/539 From aptmac at openjdk.org Wed Dec 13 15:43:17 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 13 Dec 2023 15:43:17 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 21:50:16 GMT, Carter Kozak wrote: > Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. > The new tests in this commit fail without the accompanying change to `IOToolkit.java`. > > I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). @carterkozak I've created an issue for this: https://bugs.openjdk.org/browse/JMC-8159 ------------- PR Comment: https://git.openjdk.org/jmc/pull/539#issuecomment-1854157221 From duke at openjdk.org Wed Dec 13 15:43:17 2023 From: duke at openjdk.org (Carter Kozak) Date: Wed, 13 Dec 2023 15:43:17 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 15:35:15 GMT, Alex Macdonald wrote: >> Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. >> The new tests in this commit fail without the accompanying change to `IOToolkit.java`. >> >> I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). > > @carterkozak I've created an issue for this: https://bugs.openjdk.org/browse/JMC-8159 Thank you, @aptmac! ------------- PR Comment: https://git.openjdk.org/jmc/pull/539#issuecomment-1854166716 From duke at openjdk.org Wed Dec 13 15:43:17 2023 From: duke at openjdk.org (Carter Kozak) Date: Wed, 13 Dec 2023 15:43:17 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams In-Reply-To: References: Message-ID: On Mon, 11 Dec 2023 21:50:16 GMT, Carter Kozak wrote: > Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. > The new tests in this commit fail without the accompanying change to `IOToolkit.java`. > > I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/io/IOToolkit.java line 171: > 169: } > 170: in.reset(); > 171: return in; This diff is much easier to follow with whitespace hidden. By moving the `BufferedInputStream` to the beginning of the method we can guarantee mark is supported and remove the conditional. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/539#discussion_r1425501609 From aptmac at openjdk.org Wed Dec 13 16:16:59 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 13 Dec 2023 16:16:59 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 15:40:22 GMT, Carter Kozak wrote: >> @carterkozak I've created an issue for this: https://bugs.openjdk.org/browse/JMC-8159 > > Thank you, @aptmac! @carterkozak It looks like you'll have to enable the workflows to run on your personal fork, more details can be found at: https://wiki.openjdk.org/display/SKARA/Testing#Testing-Configuringworkflowstorun ------------- PR Comment: https://git.openjdk.org/jmc/pull/539#issuecomment-1854238890 From duke at openjdk.org Wed Dec 13 16:27:10 2023 From: duke at openjdk.org (Carter Kozak) Date: Wed, 13 Dec 2023 16:27:10 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams [v2] In-Reply-To: References: Message-ID: > Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. > The new tests in this commit fail without the accompanying change to `IOToolkit.java`. > > I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: empty commit for CI ------------- Changes: - all: https://git.openjdk.org/jmc/pull/539/files - new: https://git.openjdk.org/jmc/pull/539/files/480a1cec..f085c7cb Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=539&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=539&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/539.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/539/head:pull/539 PR: https://git.openjdk.org/jmc/pull/539 From duke at openjdk.org Wed Dec 13 18:04:32 2023 From: duke at openjdk.org (Carter Kozak) Date: Wed, 13 Dec 2023 18:04:32 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams [v3] In-Reply-To: References: Message-ID: > Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. > The new tests in this commit fail without the accompanying change to `IOToolkit.java`. > > I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: Update copyright ------------- Changes: - all: https://git.openjdk.org/jmc/pull/539/files - new: https://git.openjdk.org/jmc/pull/539/files/f085c7cb..976909f2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=539&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=539&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/539.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/539/head:pull/539 PR: https://git.openjdk.org/jmc/pull/539 From hirt at openjdk.org Wed Dec 13 23:44:06 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 13 Dec 2023 23:44:06 GMT Subject: RFR: 8156: JfrRulesReport.printReport does not respect verbosity for text and json Message-ID: <3lK8yb0lP36CXhW0hKohE6cmnRxcV4Ru5j0fnCHoROg=.c1198fce-c86f-46d9-a82b-dc5e2cac5b22@github.com> The xslt files had not been updated to conform with the updated xml format. ------------- Commit messages: - Fixing copyright years - 8156: Fixing xslt templates Changes: https://git.openjdk.org/jmc/pull/540/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=540&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8156 Stats: 31 lines in 3 files changed: 13 ins; 0 del; 18 mod Patch: https://git.openjdk.org/jmc/pull/540.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/540/head:pull/540 PR: https://git.openjdk.org/jmc/pull/540 From bdutheil at openjdk.org Thu Dec 14 08:07:00 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 14 Dec 2023 08:07:00 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams [v3] In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 18:04:32 GMT, Carter Kozak wrote: >> Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. >> The new tests in this commit fail without the accompanying change to `IOToolkit.java`. >> >> I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). > > Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright Marked as reviewed by bdutheil (Author). ------------- PR Review: https://git.openjdk.org/jmc/pull/539#pullrequestreview-1781247120 From hdafgard at openjdk.org Thu Dec 14 21:10:52 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 14 Dec 2023 21:10:52 GMT Subject: RFR: 8156: JfrRulesReport.printReport does not respect verbosity for text and json In-Reply-To: <3lK8yb0lP36CXhW0hKohE6cmnRxcV4Ru5j0fnCHoROg=.c1198fce-c86f-46d9-a82b-dc5e2cac5b22@github.com> References: <3lK8yb0lP36CXhW0hKohE6cmnRxcV4Ru5j0fnCHoROg=.c1198fce-c86f-46d9-a82b-dc5e2cac5b22@github.com> Message-ID: On Wed, 13 Dec 2023 23:32:01 GMT, Marcus Hirt wrote: > The xslt files had not been updated to conform with the updated xml format. Marked as reviewed by hdafgard (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/540#pullrequestreview-1782753572 From hdafgard at openjdk.org Thu Dec 14 21:16:55 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 14 Dec 2023 21:16:55 GMT Subject: RFR: 4263: Support monitor inflation event in JMC In-Reply-To: <9jk-4-9F_En4TGULJ9pcckJZVJ7PZDzckcvodTBT_DQ=.11ac4a40-bb88-43ad-a076-406410891f56@github.com> References: <9jk-4-9F_En4TGULJ9pcckJZVJ7PZDzckcvodTBT_DQ=.11ac4a40-bb88-43ad-a076-406410891f56@github.com> Message-ID: <5Som6RPM6Z8ObgLZzNU6Htiqdf0Y_4a_Qk3NAKRFKmQ=.e00993fd-100f-4cb9-b1fe-153e86d2bdd7@github.com> On Mon, 11 Dec 2023 02:08:39 GMT, Suchita Chaturvedi wrote: > Included monitor inflate events on Lock Instance page. > > Two columns "Inflated Count" and "Inflation reason" are added to all the three tables - Monitor class, Monitor address and Thread. Both the columns are hidden by default which can be made visible by column header settings. > > image Marked as reviewed by hdafgard (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/538#pullrequestreview-1782771132 From hdafgard at openjdk.org Thu Dec 14 22:00:53 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Thu, 14 Dec 2023 22:00:53 GMT Subject: RFR: 5560: Support new nio events in JDK 10. [v2] In-Reply-To: References: Message-ID: <4yyupOfBJ1TUe4x53dbCN7VR_kyoCDiJXh9Rc00rPCc=.8a1fcade-2f4a-4a52-8916-30ab0a801901@github.com> On Sun, 10 Dec 2023 23:08:40 GMT, Suchita Chaturvedi wrote: >> This PR addresses the enhancement request of missing event File Force. >> 1. A new rule File Force has been added to the "Automated Analysis Page", Under Java Application -> File I/O. >> image >> >> 2. "File I/O" screen is updated to accomodate values for the new event. There are two new columns added - Force Count, Update Metadata. Both these columns are hidden by default and user need to make them visible by right clicking the header of the table. Also the corresponding chart for File Force Event has been introduced. >> image >> >> 3. There is a new preference/configuration introduced for the File Force Rule. >> >> image > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Implemented review comments Marked as reviewed by hdafgard (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/533#pullrequestreview-1782830384 From hirt at openjdk.org Thu Dec 14 22:41:53 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 14 Dec 2023 22:41:53 GMT Subject: Integrated: 8156: JfrRulesReport.printReport does not respect verbosity for text and json In-Reply-To: <3lK8yb0lP36CXhW0hKohE6cmnRxcV4Ru5j0fnCHoROg=.c1198fce-c86f-46d9-a82b-dc5e2cac5b22@github.com> References: <3lK8yb0lP36CXhW0hKohE6cmnRxcV4Ru5j0fnCHoROg=.c1198fce-c86f-46d9-a82b-dc5e2cac5b22@github.com> Message-ID: <8DBjlVHgUJe_BqJvskFxTwYZWRTyObSZndDKpJ5-U18=.df0718d8-1379-4418-b22b-7488ab7f03d8@github.com> On Wed, 13 Dec 2023 23:32:01 GMT, Marcus Hirt wrote: > The xslt files had not been updated to conform with the updated xml format. This pull request has now been integrated. Changeset: fc71bc89 Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/fc71bc893c2abd834449a5affba2d99b558587c1 Stats: 31 lines in 3 files changed: 13 ins; 0 del; 18 mod 8156: JfrRulesReport.printReport does not respect verbosity for text and json Reviewed-by: hdafgard ------------- PR: https://git.openjdk.org/jmc/pull/540 From schaturvedi at openjdk.org Fri Dec 15 04:33:53 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 15 Dec 2023 04:33:53 GMT Subject: Integrated: 4263: Support monitor inflation event in JMC In-Reply-To: <9jk-4-9F_En4TGULJ9pcckJZVJ7PZDzckcvodTBT_DQ=.11ac4a40-bb88-43ad-a076-406410891f56@github.com> References: <9jk-4-9F_En4TGULJ9pcckJZVJ7PZDzckcvodTBT_DQ=.11ac4a40-bb88-43ad-a076-406410891f56@github.com> Message-ID: <66QZY7wKR1qBL9yJ7fKzE-A8O50EGcQD8_0bUZdSF7Q=.808e70ad-f876-4065-aa65-49a5a7935ddf@github.com> On Mon, 11 Dec 2023 02:08:39 GMT, Suchita Chaturvedi wrote: > Included monitor inflate events on Lock Instance page. > > Two columns "Inflated Count" and "Inflation reason" are added to all the three tables - Monitor class, Monitor address and Thread. Both the columns are hidden by default which can be made visible by column header settings. > > image This pull request has now been integrated. Changeset: 9523d281 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/9523d281afb2c8188fae52a027b4e407ad705dba Stats: 29 lines in 7 files changed: 26 ins; 1 del; 2 mod 4263: Support monitor inflation event in JMC Reviewed-by: hdafgard ------------- PR: https://git.openjdk.org/jmc/pull/538 From schaturvedi at openjdk.org Fri Dec 15 04:33:54 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Fri, 15 Dec 2023 04:33:54 GMT Subject: Integrated: 5560: Support new nio events in JDK 10. In-Reply-To: References: Message-ID: On Mon, 13 Nov 2023 21:17:23 GMT, Suchita Chaturvedi wrote: > This PR addresses the enhancement request of missing event File Force. > 1. A new rule File Force has been added to the "Automated Analysis Page", Under Java Application -> File I/O. > image > > 2. "File I/O" screen is updated to accomodate values for the new event. There are two new columns added - Force Count, Update Metadata. Both these columns are hidden by default and user need to make them visible by right clicking the header of the table. Also the corresponding chart for File Force Event has been introduced. > image > > 3. There is a new preference/configuration introduced for the File Force Rule. > > image This pull request has now been integrated. Changeset: f7ee5856 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/f7ee5856528f474936b032361cc46a5ccfc6d4a7 Stats: 534 lines in 17 files changed: 444 ins; 85 del; 5 mod 5560: Support new nio events in JDK 10. Reviewed-by: hdafgard ------------- PR: https://git.openjdk.org/jmc/pull/533 From schaturvedi at openjdk.org Sun Dec 17 04:47:17 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sun, 17 Dec 2023 04:47:17 GMT Subject: RFR: 8160: Fix test failure in core due to missing new File Force rule in newly added JFRs Message-ID: <1NozZFv4Ns7EmKQrJPDOT7vOaYhUyiTPuvMf7qp288s=.ac5b6482-a1d7-46b6-bf16-8dcf4817a8d1@github.com> This PR fixes core test failure. ------------- Commit messages: - 8160: Fix test failure in core due to missing new File Force rule in newly added JFRs Changes: https://git.openjdk.org/jmc/pull/541/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=541&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8160 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/541.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/541/head:pull/541 PR: https://git.openjdk.org/jmc/pull/541 From hdafgard at openjdk.org Sun Dec 17 14:32:49 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sun, 17 Dec 2023 14:32:49 GMT Subject: RFR: 8160: Fix test failure in core due to missing new File Force rule in newly added JFRs In-Reply-To: <1NozZFv4Ns7EmKQrJPDOT7vOaYhUyiTPuvMf7qp288s=.ac5b6482-a1d7-46b6-bf16-8dcf4817a8d1@github.com> References: <1NozZFv4Ns7EmKQrJPDOT7vOaYhUyiTPuvMf7qp288s=.ac5b6482-a1d7-46b6-bf16-8dcf4817a8d1@github.com> Message-ID: On Sun, 17 Dec 2023 04:41:14 GMT, Suchita Chaturvedi wrote: > This PR fixes core test failure. Marked as reviewed by hdafgard (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/541#pullrequestreview-1785452676 From schaturvedi at openjdk.org Mon Dec 18 03:46:50 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Mon, 18 Dec 2023 03:46:50 GMT Subject: Integrated: 8160: Fix test failure in core due to missing new File Force rule in newly added JFRs In-Reply-To: <1NozZFv4Ns7EmKQrJPDOT7vOaYhUyiTPuvMf7qp288s=.ac5b6482-a1d7-46b6-bf16-8dcf4817a8d1@github.com> References: <1NozZFv4Ns7EmKQrJPDOT7vOaYhUyiTPuvMf7qp288s=.ac5b6482-a1d7-46b6-bf16-8dcf4817a8d1@github.com> Message-ID: On Sun, 17 Dec 2023 04:41:14 GMT, Suchita Chaturvedi wrote: > This PR fixes core test failure. This pull request has now been integrated. Changeset: 521e3cfa Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/521e3cfacad24bd33ee73ea945a97d3c3cc5aef3 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod 8160: Fix test failure in core due to missing new File Force rule in newly added JFRs Reviewed-by: hdafgard ------------- PR: https://git.openjdk.org/jmc/pull/541 From duke at openjdk.org Sun Dec 24 12:34:54 2023 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 24 Dec 2023 12:34:54 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v43] In-Reply-To: <48eJgmlXrRpj_NX8qsa6rLzIyk83TQqilSrV1dIJITk=.09b10119-648b-438f-8c84-5cb8ff56a989@github.com> References: <48eJgmlXrRpj_NX8qsa6rLzIyk83TQqilSrV1dIJITk=.09b10119-648b-438f-8c84-5cb8ff56a989@github.com> Message-ID: On Mon, 23 Oct 2023 18:03:15 GMT, Martin Skarsaune wrote: >> Setting back for review. The azure problem requires a fix in Jolokia. >> >> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-7455: Add jolokia to 2023-09 release definition Still troubleshooting Kubernetes tests. Now they run , but fail with class not found on Apache commons http classes ------------- PR Comment: https://git.openjdk.org/jmc/pull/332#issuecomment-1868506178