RFR: 7069: Move rjmx bundle from application to core [v5]
Alex Macdonald
aptmac at openjdk.org
Mon Dec 4 21:33:51 UTC 2023
On Mon, 4 Dec 2023 10:57:06 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Remove duplication of MRITransformationToolkit
>> - Remove flightrecorder.configuration from application/coverage
>> - Fix typo in SyntheticRepositoryInitializer function
>> - Fix typo in license header
>> - Update license headers
>> - Restore rjmx.services.jfr Messages.java
>> - 6627: Bring bundles to core
>
> application/org.openjdk.jmc.rjmx/pom.xml line 46:
>
>> 44: <jmc.config.path>${project.basedir}/../../configuration</jmc.config.path>
>> 45: </properties>
>> 46: <dependencies>
>
> This looks awkward here. I think the dependency should only be resolved via MANIFEST.MF, no <dependencies> in pom.xml here.
Ah good catch, thanks for finding that.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1414525609
More information about the jmc-dev
mailing list