RFR: 7069: Move rjmx bundle from application to core [v8]

Alex Macdonald aptmac at openjdk.org
Tue Dec 5 17:50:01 UTC 2023


On Tue, 5 Dec 2023 16:14:40 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix javadoc errors
>>  - Fix indent spacing in rjmx.common pom
>
> core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/services/jfr/package-info.java line 68:
> 
>> 66:  * 	long duration = 5000;
>> 67:  * 	IConstrainedMap<String> defaultRecordingOptions = jfr.getDefaultRecordingOptions();
>> 68:  *  IDescribedMap<EventOptionID> defaultEventOptions = jfr.getDefaultEventOptions();
> 
> Maybe you can fix the indentation in this line, too.

Ah thanks again for the keen eye

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/531#discussion_r1416063827


More information about the jmc-dev mailing list