From hirt at openjdk.org Thu Feb 16 01:39:24 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 16 Feb 2023 01:39:24 GMT Subject: RFR: 8031: Remove the Twitter plug-in Message-ID: Too big of a maintenance burden now that Twitter is updating APIs. ------------- Commit messages: - Fixing the remote launcher - Updating launchers - 8031: Remove the Twitter plug-in Changes: https://git.openjdk.org/jmc/pull/464/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=464&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8031 Stats: 2015 lines in 36 files changed: 0 ins; 1987 del; 28 mod Patch: https://git.openjdk.org/jmc/pull/464.diff Fetch: git fetch https://git.openjdk.org/jmc pull/464/head:pull/464 PR: https://git.openjdk.org/jmc/pull/464 From aptmac at openjdk.org Thu Feb 16 02:41:39 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 16 Feb 2023 02:41:39 GMT Subject: RFR: 8031: Remove the Twitter plug-in In-Reply-To: References: Message-ID: On Thu, 16 Feb 2023 00:36:06 GMT, Marcus Hirt wrote: > Too big of a maintenance burden now that Twitter is updating APIs. Marked as reviewed by aptmac (Reviewer). ------------- PR: https://git.openjdk.org/jmc/pull/464 From hirt at openjdk.org Thu Feb 16 15:08:42 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 16 Feb 2023 15:08:42 GMT Subject: Integrated: 8031: Remove the Twitter plug-in In-Reply-To: References: Message-ID: On Thu, 16 Feb 2023 00:36:06 GMT, Marcus Hirt wrote: > Too big of a maintenance burden now that Twitter is updating APIs. This pull request has now been integrated. Changeset: a44f017c Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/a44f017cc8f35ed606cbb58b2c8721a0ca11a9dc Stats: 2015 lines in 36 files changed: 0 ins; 1987 del; 28 mod 8031: Remove the Twitter plug-in Reviewed-by: aptmac ------------- PR: https://git.openjdk.org/jmc/pull/464 From clanger at openjdk.org Fri Feb 17 11:25:53 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 11:25:53 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 Message-ID: We can bump the GHA JDK to 11.0.18. ------------- Commit messages: - JMC-8035 Changes: https://git.openjdk.org/jmc/pull/465/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=465&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8035 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/465.diff Fetch: git fetch https://git.openjdk.org/jmc pull/465/head:pull/465 PR: https://git.openjdk.org/jmc/pull/465 From clanger at openjdk.org Fri Feb 17 11:31:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 11:31:50 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: > Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. > > So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. > > According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, > that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead > of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper > classes to other modules within eclipse any more. > > I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but > not contain any actual tests. > > Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing > the JMC projects into Eclipse. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into JMC-7951 - JMC-7951 ------------- Changes: https://git.openjdk.org/jmc/pull/451/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=01 Stats: 924 lines in 102 files changed: 195 ins; 368 del; 361 mod Patch: https://git.openjdk.org/jmc/pull/451.diff Fetch: git fetch https://git.openjdk.org/jmc pull/451/head:pull/451 PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 17 11:37:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 11:37:55 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v3] In-Reply-To: References: Message-ID: On Fri, 21 Oct 2022 18:33:56 GMT, Alex Macdonald wrote: >> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. >> >> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. >> >> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: >> >> - org.openjdk.jmc.ui.common.action (3) >> Executable, IActionProvider, IUserAction >> >> - org.openjdk.jmc.ui.common.jvm (5) >> Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType >> >> - org.openjdk.jmc.ui.common.resource (2) >> IImageResource, Resource >> >> - org.openjdk.jmc.ui.common.security (10) >> ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory >> >> - org.opendjk.jmc.ui.common.tree (3) >> IArray, IChild, IParent >> >> - org.openjdk.jmc.ui.common.util (4) >> Environment, Filename, ICopyable, IObservable >> >> - org.openjdk.jmc.ui.common.xydata (5) >> DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7308 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - fix imports for PersistentCredentials > > I must have missed this when I rebased onto the master branch. Fixing it > up here. > - update license headers to 2022 > - update license headers > - update agent plugin imports > - migrate classes from ui.common.resource to core > - migrate interfaces from ui.common.action to core > - migrate most of the remainder from ui.common.security to core > - migrate ui.common.xydata to core > - migrate Environment, Filename, ICopyable, and IObservable from ui.common.util to core > - migrate ui.common.tree to core > - ... and 2 more: https://git.openjdk.org/jmc/compare/0e8e2004...a99a9c1b Could you enable Github Actions on your repo and merge with master? ------------- PR: https://git.openjdk.org/jmc/pull/300 From bdutheil at openjdk.org Fri Feb 17 12:03:58 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Fri, 17 Feb 2023 12:03:58 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:12:03 GMT, Christoph Langer wrote: > We can bump the GHA JDK to 11.0.18. Marked as reviewed by bdutheil (Author). ------------- PR: https://git.openjdk.org/jmc/pull/465 From hirt at openjdk.org Fri Feb 17 14:59:53 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 17 Feb 2023 14:59:53 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:12:03 GMT, Christoph Langer wrote: > We can bump the GHA JDK to 11.0.18. Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/465 From hirt at openjdk.org Fri Feb 17 15:11:57 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 17 Feb 2023 15:11:57 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:31:50 GMT, Christoph Langer wrote: >> Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. >> >> So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. >> >> According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, >> that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead >> of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper >> classes to other modules within eclipse any more. >> >> I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but >> not contain any actual tests. >> >> Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing >> the JMC projects into Eclipse. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JMC-7951 > - JMC-7951 application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. Don't forget to update the RedHat year as well. ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 17 15:49:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 15:49:20 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 14:58:14 GMT, Marcus Hirt wrote: >> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JMC-7951 >> - JMC-7951 > > application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java line 2: > >> 1: /* >> 2: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. > > Don't forget to update the RedHat year as well. Hm, shouldn't one not just update the Oracle copyright year and that of one's own company, if applicable? ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 17 15:58:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 15:58:50 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 [v2] In-Reply-To: References: Message-ID: > We can bump the GHA JDK to 11.0.18. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Add copyright header ------------- Changes: - all: https://git.openjdk.org/jmc/pull/465/files - new: https://git.openjdk.org/jmc/pull/465/files/be7c5dbe..ed5388c7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=465&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=465&range=00-01 Stats: 34 lines in 1 file changed: 34 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/465.diff Fetch: git fetch https://git.openjdk.org/jmc pull/465/head:pull/465 PR: https://git.openjdk.org/jmc/pull/465 From bdutheil at openjdk.org Fri Feb 17 16:14:24 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Fri, 17 Feb 2023 16:14:24 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:31:50 GMT, Christoph Langer wrote: >> Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. >> >> So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. >> >> According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. >> >> I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. >> >> Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. > > Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: > > - Merge branch 'master' into JMC-7951 > - JMC-7951 application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/MCJemmyTestBase.java line 2: > 1: /* > 2: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. Shouldn't it be 2023 ? core/tests/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/MCTestCase.java line 33: > 31: * WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > 32: */ > 33: package org.openjdk.jmc.test; nitpick: I think the package name should follow the artifact name, maybe something like : Suggestion: package org.openjdk.jmc.test.lib; ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 17 16:46:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 16:46:20 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v3] In-Reply-To: References: Message-ID: > Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. > > So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. > > According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. > > I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. > > Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Some further cleanups ------------- Changes: - all: https://git.openjdk.org/jmc/pull/451/files - new: https://git.openjdk.org/jmc/pull/451/files/c49773b5..9f8b1a68 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=01-02 Stats: 6 lines in 5 files changed: 0 ins; 5 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/451.diff Fetch: git fetch https://git.openjdk.org/jmc pull/451/head:pull/451 PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 17 16:49:50 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 16:49:50 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:53:56 GMT, Brice Dutheil wrote: >> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JMC-7951 >> - JMC-7951 > > application/uitests/org.openjdk.jmc.test.jemmy/src/test/java/org/openjdk/jmc/test/jemmy/MCJemmyTestBase.java line 2: > >> 1: /* >> 2: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. > > Shouldn't it be 2023 ? I did these changes in 2022 already... ------------- PR: https://git.openjdk.org/jmc/pull/451 From hirt at openjdk.org Fri Feb 17 18:35:51 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 17 Feb 2023 18:35:51 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization [v4] In-Reply-To: References: Message-ID: On Tue, 27 Sep 2022 21:45:40 GMT, Brice Dutheil wrote: >> This change introduces a possible replacement for the current flamegraph view. >> >> **Motivation** >> The current is based on a web view. In the current state, >> - the web view can be slow to render especially when the tree is large. >> - the web view don't feel well integrated, in particular when popups are shown. >> - web view are difficult to work with from a JMC developer perspective. >> >> ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) >> >> **Description** >> Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. >> >> As the intent of this view is to eventually replace the current one, the icons are the same. >> >> Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. >> >> >> cd releng/third-party >> >> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar >> >> # if sources are wanted >> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources >> >> # make the p2 site, don't forget the -U >> mvn p2:site -U; mvn jetty:run >> >> >> **Outstanding issues / limitation** >> - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. >> - [x] Currently the view does not initializes correctly: >> the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. >> https://github.com/bric3/fireplace/issues/79 >> - [x] Fireplace only supports _icicle_ view at this time. >> https://github.com/bric3/fireplace/issues/22 >> - [x] Icons for minimap toggle and zoom reset >> image >> - [x] Export to image >> https://github.com/bric3/fireplace/issues/99 >> - [x] Export to print ? >> Can be done at a later time >> - [x] release of fireplace > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Drop the dash in the module name Hi Bric! Can you please merge master to resolve the merge conflicts? ------------- PR: https://git.openjdk.org/jmc/pull/408 From clanger at openjdk.org Fri Feb 17 18:47:07 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 17 Feb 2023 18:47:07 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 [v3] In-Reply-To: References: Message-ID: <55OXkczoKy4l3JBJfjja26hoXeuJFtrmMDWeXUO_9Mk=.38259fbe-7cbe-40bc-a732-6718976d41d7@github.com> > We can bump the GHA JDK to 11.0.18. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Update Datadog copyright year ------------- Changes: - all: https://git.openjdk.org/jmc/pull/465/files - new: https://git.openjdk.org/jmc/pull/465/files/ed5388c7..600c235d Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=465&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=465&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/465.diff Fetch: git fetch https://git.openjdk.org/jmc pull/465/head:pull/465 PR: https://git.openjdk.org/jmc/pull/465 From hirt at openjdk.org Fri Feb 17 18:47:08 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 17 Feb 2023 18:47:08 GMT Subject: RFR: 8035: Update Java version in GHA workflow to 11.0.18 [v3] In-Reply-To: <55OXkczoKy4l3JBJfjja26hoXeuJFtrmMDWeXUO_9Mk=.38259fbe-7cbe-40bc-a732-6718976d41d7@github.com> References: <55OXkczoKy4l3JBJfjja26hoXeuJFtrmMDWeXUO_9Mk=.38259fbe-7cbe-40bc-a732-6718976d41d7@github.com> Message-ID: On Fri, 17 Feb 2023 18:41:57 GMT, Christoph Langer wrote: >> We can bump the GHA JDK to 11.0.18. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Update Datadog copyright year Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/465 From aptmac at openjdk.org Sat Feb 18 03:45:30 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Sat, 18 Feb 2023 03:45:30 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v3] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:25:10 GMT, Christoph Langer wrote: > Could you enable Github Actions on your repo and merge with master? That sounds like a good idea to me, would you happen to know how to enable it? I tried looking at the documentation [[0]](https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow#enabling-a-workflow) and it's wanting me to use the Actions tab, which isn't visible on this repo (for me at least). [0] https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow#enabling-a-workflow ------------- PR: https://git.openjdk.org/jmc/pull/300 From clanger at openjdk.org Mon Feb 20 14:48:40 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 14:48:40 GMT Subject: Integrated: 8035: Update Java version in GHA workflow to 11.0.18 In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:12:03 GMT, Christoph Langer wrote: > We can bump the GHA JDK to 11.0.18. This pull request has now been integrated. Changeset: cce93507 Author: Christoph Langer URL: https://git.openjdk.org/jmc/commit/cce935078953ca84b3b341d01cda700707702e08 Stats: 35 lines in 1 file changed: 34 ins; 0 del; 1 mod 8035: Update Java version in GHA workflow to 11.0.18 Reviewed-by: bdutheil, hirt ------------- PR: https://git.openjdk.org/jmc/pull/465 From clanger at openjdk.org Mon Feb 20 16:48:26 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 16:48:26 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v4] In-Reply-To: References: Message-ID: > Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. > > So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. > > According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. > > I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. > > Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into JMC-7951 - Some further cleanups - Merge branch 'master' into JMC-7951 - JMC-7951 ------------- Changes: https://git.openjdk.org/jmc/pull/451/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=03 Stats: 929 lines in 102 files changed: 195 ins; 373 del; 361 mod Patch: https://git.openjdk.org/jmc/pull/451.diff Fetch: git fetch https://git.openjdk.org/jmc pull/451/head:pull/451 PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Mon Feb 20 18:24:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 18:24:22 GMT Subject: RFR: 8037: Cleanups in configuration.test and graphview.test Message-ID: A few cleanups for test projects ------------- Commit messages: - JMC-8037 Changes: https://git.openjdk.org/jmc/pull/466/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=466&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8037 Stats: 26 lines in 5 files changed: 16 ins; 8 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/466.diff Fetch: git fetch https://git.openjdk.org/jmc pull/466/head:pull/466 PR: https://git.openjdk.org/jmc/pull/466 From clanger at openjdk.org Mon Feb 20 18:38:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 18:38:22 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v5] In-Reply-To: References: Message-ID: > Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. > > So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. > > According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. > > I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. > > Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Update copyright years ------------- Changes: - all: https://git.openjdk.org/jmc/pull/451/files - new: https://git.openjdk.org/jmc/pull/451/files/6aef6cd2..aeede24c Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=04 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=451&range=03-04 Stats: 13 lines in 2 files changed: 11 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/451.diff Fetch: git fetch https://git.openjdk.org/jmc pull/451/head:pull/451 PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Mon Feb 20 18:38:27 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 18:38:27 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 15:43:47 GMT, Christoph Langer wrote: >> application/tests/org.openjdk.jmc.flightrecorder.ext.jfx.test/src/test/java/org/openjdk/jmc/flightrecorder/ext/jfx/test/JfxPulseDurationRuleTest.java line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved. >> >> Don't forget to update the RedHat year as well. > > Hm, shouldn't one not just update the Oracle copyright year and that of one's own company, if applicable? fixed. ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Mon Feb 20 18:38:34 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 18:38:34 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Fri, 17 Feb 2023 11:58:56 GMT, Brice Dutheil wrote: >> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JMC-7951 >> - JMC-7951 > > core/tests/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/MCTestCase.java line 33: > >> 31: * WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> 32: */ >> 33: package org.openjdk.jmc.test; > > nitpick: I think the package name should follow the artifact name, maybe something like : > > Suggestion: > > package org.openjdk.jmc.test.lib; Hm, that would be possible but it would render the change a lot larger. There are also subpackages `io` and `mock.item`. If we were to rename all 3 packages we'd probably have to touch more tests. So, if we opt to rename the packages I'd prefer to do it in a separate PR. ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Mon Feb 20 18:39:36 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 20 Feb 2023 18:39:36 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v3] In-Reply-To: References: Message-ID: On Sat, 18 Feb 2023 03:43:03 GMT, Alex Macdonald wrote: > > Could you enable Github Actions on your repo and merge with master? > > That sounds like a good idea to me, would you happen to know how to enable it? I tried looking at the documentation [[0]](https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow#enabling-a-workflow) and it's wanting me to use the Actions tab, which isn't visible on this repo (for me at least). > > [0] https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow#enabling-a-workflow You have to go to the Actions tab of your personal fork (https://github.com/aptmac/jmc). There you should be prompted with a dialog to activate it. ------------- PR: https://git.openjdk.org/jmc/pull/300 From bdutheil at openjdk.org Mon Feb 20 22:39:34 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 20 Feb 2023 22:39:34 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v2] In-Reply-To: References: Message-ID: On Mon, 20 Feb 2023 18:31:55 GMT, Christoph Langer wrote: >> core/tests/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/MCTestCase.java line 33: >> >>> 31: * WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >>> 32: */ >>> 33: package org.openjdk.jmc.test; >> >> nitpick: I think the package name should follow the artifact name, maybe something like : >> >> Suggestion: >> >> package org.openjdk.jmc.test.lib; > > Hm, that would be possible but it would render the change a lot larger. There are also subpackages `io` and `mock.item`. If we were to rename all 3 packages we'd probably have to touch more tests. So, if we opt to rename the packages I'd prefer to do it in a separate PR. Ok, I understand the concern. ------------- PR: https://git.openjdk.org/jmc/pull/451 From duke at openjdk.org Tue Feb 21 10:52:24 2023 From: duke at openjdk.org (Virag Purnam) Date: Tue, 21 Feb 2023 10:52:24 GMT Subject: RFR: 8036: Upgrading Jakarta Mail in JMC Message-ID: Upgrading Jakarta Mail in JMC as **Jakarta Mail implementation moved to Eclipse Angus** [https://eclipse-ee4j.github.io/angus-mail/](https://eclipse-ee4j.github.io/angus-mail/) **com.sun.mail.jakarta.mail** has been replaced by **org.eclipse.angus.jakarta.mail**. Future development will happen in Eclipse Angus. Dependencies of org.eclipse.angus.jakarta.mail 2.0.1 - angus-activation 2.0.0 - jakarta.activation-api 2.1.1 - osgi-resource-locator 1.0.3 ------------- Commit messages: - 8036: Upgrading Jakarta Mail in JMC Changes: https://git.openjdk.org/jmc/pull/467/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=467&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8036 Stats: 44 lines in 7 files changed: 12 ins; 1 del; 31 mod Patch: https://git.openjdk.org/jmc/pull/467.diff Fetch: git fetch https://git.openjdk.org/jmc pull/467/head:pull/467 PR: https://git.openjdk.org/jmc/pull/467 From duke at openjdk.org Tue Feb 21 11:13:10 2023 From: duke at openjdk.org (Virag Purnam) Date: Tue, 21 Feb 2023 11:13:10 GMT Subject: RFR: 8036: Upgrading Jakarta Mail in JMC [v2] In-Reply-To: References: Message-ID: > Upgrading Jakarta Mail in JMC as **Jakarta Mail implementation moved to Eclipse Angus** > [https://eclipse-ee4j.github.io/angus-mail/](https://eclipse-ee4j.github.io/angus-mail/) > > **com.sun.mail.jakarta.mail** has been replaced by **org.eclipse.angus.jakarta.mail**. Future development will happen in Eclipse Angus. > > Dependencies of org.eclipse.angus.jakarta.mail 2.0.1 > - angus-activation 2.0.0 > - jakarta.activation-api 2.1.1 > - osgi-resource-locator 1.0.3 Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: 8036: Upgrading Jakarta Mail in JMC ------------- Changes: - all: https://git.openjdk.org/jmc/pull/467/files - new: https://git.openjdk.org/jmc/pull/467/files/3d22497b..34da7980 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=467&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=467&range=00-01 Stats: 2320 lines in 1 file changed: 1566 ins; 753 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/467.diff Fetch: git fetch https://git.openjdk.org/jmc pull/467/head:pull/467 PR: https://git.openjdk.org/jmc/pull/467 From hirt at openjdk.org Tue Feb 21 12:33:33 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 21 Feb 2023 12:33:33 GMT Subject: RFR: 8036: Upgrading Jakarta Mail in JMC [v2] In-Reply-To: References: Message-ID: On Tue, 21 Feb 2023 11:13:10 GMT, Virag Purnam wrote: >> Upgrading Jakarta Mail in JMC as **Jakarta Mail implementation moved to Eclipse Angus** >> [https://eclipse-ee4j.github.io/angus-mail/](https://eclipse-ee4j.github.io/angus-mail/) >> >> **com.sun.mail.jakarta.mail** has been replaced by **org.eclipse.angus.jakarta.mail**. Future development will happen in Eclipse Angus. >> >> Dependencies of org.eclipse.angus.jakarta.mail 2.0.1 >> - angus-activation 2.0.0 >> - jakarta.activation-api 2.1.1 >> - osgi-resource-locator 1.0.3 > > Virag Purnam has updated the pull request incrementally with one additional commit since the last revision: > > 8036: Upgrading Jakarta Mail in JMC Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/467 From schaturvedi at openjdk.org Wed Feb 22 12:30:12 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 22 Feb 2023 12:30:12 GMT Subject: RFR: 8041: JfrRulesReport -format json produce incomplete results Message-ID: The output of JSON report contains blank placeholders like below: "message": "", "detailedMessage": "" After the fix: "message": "No long socket write pauses were found in this recording (the longest was 26.678?ms).", "detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication." ------------- Commit messages: - 8041: JfrRulesReport -format json produce incomplete results Changes: https://git.openjdk.org/jmc/pull/468/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=468&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8041 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/468.diff Fetch: git fetch https://git.openjdk.org/jmc pull/468/head:pull/468 PR: https://git.openjdk.org/jmc/pull/468 From duke at openjdk.org Wed Feb 22 13:23:17 2023 From: duke at openjdk.org (Virag Purnam) Date: Wed, 22 Feb 2023 13:23:17 GMT Subject: Integrated: 8036: Upgrading Jakarta Mail in JMC In-Reply-To: References: Message-ID: On Tue, 21 Feb 2023 10:46:16 GMT, Virag Purnam wrote: > Upgrading Jakarta Mail in JMC as **Jakarta Mail implementation moved to Eclipse Angus** > [https://eclipse-ee4j.github.io/angus-mail/](https://eclipse-ee4j.github.io/angus-mail/) > > **com.sun.mail.jakarta.mail** has been replaced by **org.eclipse.angus.jakarta.mail**. Future development will happen in Eclipse Angus. > > Dependencies of org.eclipse.angus.jakarta.mail 2.0.1 > - angus-activation 2.0.0 > - jakarta.activation-api 2.1.1 > - osgi-resource-locator 1.0.3 This pull request has now been integrated. Changeset: 8eb91157 Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/8eb911570b59cc4e601ae1c14bddae84600d19e9 Stats: 2364 lines in 8 files changed: 1578 ins; 754 del; 32 mod 8036: Upgrading Jakarta Mail in JMC Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/467 From hirt at openjdk.org Wed Feb 22 20:12:28 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 22 Feb 2023 20:12:28 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v5] In-Reply-To: References: Message-ID: On Mon, 20 Feb 2023 18:38:22 GMT, Christoph Langer wrote: >> Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. >> >> So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. >> >> According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. >> >> I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. >> >> Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright years Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/451 From jmatsuoka at openjdk.org Thu Feb 23 15:59:12 2023 From: jmatsuoka at openjdk.org (Joshua Matsuoka) Date: Thu, 23 Feb 2023 15:59:12 GMT Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core Message-ID: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core. This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 . [0] https://bugs.openjdk.java.net/browse/JMC-7307 ------------- Commit messages: - Merge remote-tracking branch 'upstream/master' into 7307 - Fixing manifest - Fixing visibility of XML classes - Addressing review comments - Merge remote-tracking branch 'aptmac/PR-7307' into 7307 - update license headers to 2022 - fix package name in JFCXMLValidator logger - re-order flightrecorder.configuration.test in test pom - update license headers - migrate VolatileStorageDelegate to flightrecorder.configuration.model - ... and 7 more: https://git.openjdk.org/jmc/compare/8eb91157...0bb0e8ca Changes: https://git.openjdk.org/jmc/pull/469/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=469&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7307 Stats: 1269 lines in 131 files changed: 410 ins; 626 del; 233 mod Patch: https://git.openjdk.org/jmc/pull/469.diff Fetch: git fetch https://git.openjdk.org/jmc pull/469/head:pull/469 PR: https://git.openjdk.org/jmc/pull/469 From clanger at openjdk.org Fri Feb 24 06:54:20 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 24 Feb 2023 06:54:20 GMT Subject: RFR: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module [v5] In-Reply-To: References: Message-ID: <6QKklpF1GQx7H0O5VxaEz_DhJkggpEH7h9VqV_xjdnQ=.759b4029-7e3c-454e-b07e-202f2dc135c2@github.com> On Mon, 20 Feb 2023 18:38:22 GMT, Christoph Langer wrote: >> Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. >> >> So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. >> >> According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. >> >> I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. >> >> Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. > > Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright years Thanks for the reviews. ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 24 06:54:22 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 24 Feb 2023 06:54:22 GMT Subject: Integrated: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module In-Reply-To: References: Message-ID: <1LkCiKvYThErJn-_8MbTR9JNbSnR0zvmc7GPV-rKpZ8=.116905d9-2485-4a1f-ac02-eb349b40e0ef@github.com> On Thu, 3 Nov 2022 21:59:46 GMT, Christoph Langer wrote: > Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring. > > So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module. > > According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying ${project.basedir}/src/main/java in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more. > > I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests. > > Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse. This pull request has now been integrated. Changeset: 456da390 Author: Christoph Langer URL: https://git.openjdk.org/jmc/commit/456da3900f3fe2fc35b6f50a1bc9217dc00b4069 Stats: 941 lines in 103 files changed: 206 ins; 373 del; 362 mod 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/451 From clanger at openjdk.org Fri Feb 24 07:52:02 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 24 Feb 2023 07:52:02 GMT Subject: RFR: 8037: Cleanups in configuration.test and graphview.test [v2] In-Reply-To: References: Message-ID: > A few cleanups for test projects Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge branch 'master' into JMC-8037 - JMC-8037 ------------- Changes: https://git.openjdk.org/jmc/pull/466/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=466&range=01 Stats: 26 lines in 5 files changed: 5 ins; 8 del; 13 mod Patch: https://git.openjdk.org/jmc/pull/466.diff Fetch: git fetch https://git.openjdk.org/jmc pull/466/head:pull/466 PR: https://git.openjdk.org/jmc/pull/466 From clanger at openjdk.org Fri Feb 24 15:46:29 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 24 Feb 2023 15:46:29 GMT Subject: RFR: 8041: JfrRulesReport -format json produce incomplete results In-Reply-To: References: Message-ID: On Wed, 22 Feb 2023 12:23:16 GMT, Suchita Chaturvedi wrote: > The output of JSON report contains blank placeholders like below: > "message": "", > "detailedMessage": "" > > After the fix: > > "message": "No long socket write pauses were found in this recording (the longest was 26.678?ms).", > "detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication." LGTM ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/468 From duke at openjdk.org Sat Feb 25 16:50:56 2023 From: duke at openjdk.org (Virag Purnam) Date: Sat, 25 Feb 2023 16:50:56 GMT Subject: RFR: 8043: Upgrading D3 from v6 to v7 Message-ID: D3 has been upgraded from v6 to v7. Lots of bugfixes and enhancements have been done in v7. Upgrading to v7 will keep JMC up to date with respect to third parties. https://github.com/d3/d3/blob/main/CHANGES.md ------------- Commit messages: - 8043: Upgrading D3 from v6 to v7 - 8043: Upgrading D3 from v6 to v7 Changes: https://git.openjdk.org/jmc/pull/470/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=470&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8043 Stats: 741 lines in 9 files changed: 531 ins; 84 del; 126 mod Patch: https://git.openjdk.org/jmc/pull/470.diff Fetch: git fetch https://git.openjdk.org/jmc pull/470/head:pull/470 PR: https://git.openjdk.org/jmc/pull/470 From hirt at openjdk.org Sat Feb 25 18:48:11 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 25 Feb 2023 18:48:11 GMT Subject: RFR: 8043: Upgrading D3 from v6 to v7 In-Reply-To: References: Message-ID: On Sat, 25 Feb 2023 16:45:42 GMT, Virag Purnam wrote: > D3 has been upgraded from v6 to v7. > Lots of bugfixes and enhancements have been done in v7. Upgrading to v7 will keep JMC up to date with respect to third parties. > https://github.com/d3/d3/blob/main/CHANGES.md Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/470 From hirt at openjdk.org Sat Feb 25 18:49:11 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Sat, 25 Feb 2023 18:49:11 GMT Subject: RFR: 8041: JfrRulesReport -format json produce incomplete results In-Reply-To: References: Message-ID: On Wed, 22 Feb 2023 12:23:16 GMT, Suchita Chaturvedi wrote: > The output of JSON report contains blank placeholders like below: > "message": "", > "detailedMessage": "" > > After the fix: > > "message": "No long socket write pauses were found in this recording (the longest was 26.678?ms).", > "detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication." Marked as reviewed by hirt (Lead). ------------- PR: https://git.openjdk.org/jmc/pull/468 From schaturvedi at openjdk.org Sun Feb 26 19:22:09 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Sun, 26 Feb 2023 19:22:09 GMT Subject: Integrated: 8041: JfrRulesReport -format json produce incomplete results In-Reply-To: References: Message-ID: On Wed, 22 Feb 2023 12:23:16 GMT, Suchita Chaturvedi wrote: > The output of JSON report contains blank placeholders like below: > "message": "", > "detailedMessage": "" > > After the fix: > > "message": "No long socket write pauses were found in this recording (the longest was 26.678?ms).", > "detailedMessage": "Note that there are some socket write patterns with high duration writes that we consider to be normal and are therefore excluded. Such patterns include JMX RMI communication." This pull request has now been integrated. Changeset: dd11789e Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/dd11789ed48abb5e12bd99cc631a9be7a5afa9ff Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8041: JfrRulesReport -format json produce incomplete results Reviewed-by: clanger, hirt ------------- PR: https://git.openjdk.org/jmc/pull/468 From duke at openjdk.org Mon Feb 27 04:58:14 2023 From: duke at openjdk.org (Virag Purnam) Date: Mon, 27 Feb 2023 04:58:14 GMT Subject: Integrated: 8043: Upgrading D3 from v6 to v7 In-Reply-To: References: Message-ID: On Sat, 25 Feb 2023 16:45:42 GMT, Virag Purnam wrote: > D3 has been upgraded from v6 to v7. > Lots of bugfixes and enhancements have been done in v7. Upgrading to v7 will keep JMC up to date with respect to third parties. > https://github.com/d3/d3/blob/main/CHANGES.md This pull request has now been integrated. Changeset: cdc7964d Author: vpurnam Committer: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/cdc7964de61172135e2928261bcf4d8a1f4a01b2 Stats: 741 lines in 9 files changed: 531 ins; 84 del; 126 mod 8043: Upgrading D3 from v6 to v7 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/470 From rschmelter at openjdk.org Mon Feb 27 16:42:09 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Mon, 27 Feb 2023 16:42:09 GMT Subject: RFR: 8046: Detect failing agent builds on Windows Message-ID: When running build.bat --packageAgent, the build.bat doesn't detect if the maven call fails, since the ERRORLEVEL variable is overridden by the "cd .." call before it is checked. Additionally the format of the if/else construct is wrong (uses curly braces in the else part). ------------- Commit messages: - Detect failing agent builds Changes: https://git.openjdk.org/jmc/pull/472/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=472&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8046 Stats: 4 lines in 1 file changed: 1 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/472.diff Fetch: git fetch https://git.openjdk.org/jmc pull/472/head:pull/472 PR: https://git.openjdk.org/jmc/pull/472 From clanger at openjdk.org Mon Feb 27 21:46:53 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 27 Feb 2023 21:46:53 GMT Subject: RFR: 8046: Detect failing agent builds on Windows In-Reply-To: References: Message-ID: On Mon, 27 Feb 2023 16:36:16 GMT, Ralf Schmelter wrote: > When running build.bat --packageAgent, the build.bat doesn't detect if the maven call fails, since the ERRORLEVEL variable is overridden by the "cd .." call before it is checked. Additionally the format of the if/else construct is wrong (uses curly braces in the else part). Looks good. You have to change the PR title to match with the JBS item. ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/472 From rschmelter at openjdk.org Tue Feb 28 08:54:02 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 28 Feb 2023 08:54:02 GMT Subject: RFR: 8045: retransformClasses() doesn't retransform all needed classes Message-ID: 8045: retransformClasses() doesn't retransform all needed classes ------------- Commit messages: - Fixed copyright year - Added test - Fixed retransformClasses() methods Changes: https://git.openjdk.org/jmc/pull/471/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=471&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8045 Stats: 143 lines in 4 files changed: 129 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jmc/pull/471.diff Fetch: git fetch https://git.openjdk.org/jmc pull/471/head:pull/471 PR: https://git.openjdk.org/jmc/pull/471 From rschmelter at openjdk.org Tue Feb 28 11:33:41 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 28 Feb 2023 11:33:41 GMT Subject: RFR: 8045: retransformClasses() doesn't retransform all needed classes [v2] In-Reply-To: References: Message-ID: > 8045: retransformClasses() doesn't retransform all needed classes Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: Adjust format ------------- Changes: - all: https://git.openjdk.org/jmc/pull/471/files - new: https://git.openjdk.org/jmc/pull/471/files/04a0315b..495fec5c Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=471&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=471&range=00-01 Stats: 9 lines in 3 files changed: 0 ins; 1 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/471.diff Fetch: git fetch https://git.openjdk.org/jmc pull/471/head:pull/471 PR: https://git.openjdk.org/jmc/pull/471 From rschmelter at openjdk.org Tue Feb 28 12:10:55 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 28 Feb 2023 12:10:55 GMT Subject: RFR: 8045: retransformClasses() doesn't retransform all needed classes [v3] In-Reply-To: References: Message-ID: > 8045: retransformClasses() doesn't retransform all needed classes Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: Had to run spotless on Linux ------------- Changes: - all: https://git.openjdk.org/jmc/pull/471/files - new: https://git.openjdk.org/jmc/pull/471/files/495fec5c..3d5d51d3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=471&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=471&range=01-02 Stats: 114 lines in 1 file changed: 0 ins; 0 del; 114 mod Patch: https://git.openjdk.org/jmc/pull/471.diff Fetch: git fetch https://git.openjdk.org/jmc pull/471/head:pull/471 PR: https://git.openjdk.org/jmc/pull/471 From rschmelter at openjdk.org Tue Feb 28 14:23:54 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 28 Feb 2023 14:23:54 GMT Subject: RFR: 8048: Agent throws exceptions on missing or empty descriptions Message-ID: The agent throws exceptions when the description of an event or value is empty or missing. This change just omits the Description annotation for the generated event classes in this case. ------------- Commit messages: - Handle empty or missing descriptions gracefully Changes: https://git.openjdk.org/jmc/pull/473/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=473&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8048 Stats: 10 lines in 1 file changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jmc/pull/473.diff Fetch: git fetch https://git.openjdk.org/jmc pull/473/head:pull/473 PR: https://git.openjdk.org/jmc/pull/473 From clanger at openjdk.org Tue Feb 28 15:54:06 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 28 Feb 2023 15:54:06 GMT Subject: RFR: 8048: Agent throws exceptions on missing or empty descriptions In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 14:18:18 GMT, Ralf Schmelter wrote: > The agent throws exceptions when the description of an event or value is empty or missing. This change just omits the Description annotation for the generated event classes in this case. Looks good. Thanks for fixing this. Please update the copyright year before pushing. ------------- Marked as reviewed by clanger (Committer). PR: https://git.openjdk.org/jmc/pull/473 From rschmelter at openjdk.org Tue Feb 28 17:32:48 2023 From: rschmelter at openjdk.org (Ralf Schmelter) Date: Tue, 28 Feb 2023 17:32:48 GMT Subject: RFR: 8048: Agent throws exceptions on missing or empty descriptions [v2] In-Reply-To: References: Message-ID: > The agent throws exceptions when the description of an event or value is empty or missing. This change just omits the Description annotation for the generated event classes in this case. Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision: Updated copyright year ------------- Changes: - all: https://git.openjdk.org/jmc/pull/473/files - new: https://git.openjdk.org/jmc/pull/473/files/51e6aaf1..b89e20f8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=473&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=473&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/473.diff Fetch: git fetch https://git.openjdk.org/jmc pull/473/head:pull/473 PR: https://git.openjdk.org/jmc/pull/473