Integrated: 7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module

Christoph Langer clanger at openjdk.org
Fri Feb 24 06:54:22 UTC 2023


On Thu, 3 Nov 2022 21:59:46 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> Triggered by an issue in project core/tests/org.openjdk.jmc.common.test, I came up with a little refactoring.
> 
> So, org.openjdk.jmc.common.test is somewhat of a hybrid project. It contains both, some common test scaffolding classes plus some actual tests for the org.openjdk.jmc.common module.
> 
> According to our special setup, which is not really like what maven would expect, we have all sources, also for the tests in the src/main/java folder. With a little tweak, that is specifying <testSourceDirectory>${project.basedir}/src/main/java</testSourceDirectory> in the pom.xml, we can direct maven to consume the tests from there instead of the usually expected src/test/java subfolder. However, when updating the eclipse project configuration from that pom.xml, the project would not export the test helper classes to other modules within eclipse any more.
> 
> I'm hereby factoring out the test helper classes into a new module called core/tests/org.openjdk.jmc.testlib. This module will then only serve as a test helper library but not contain any actual tests.
> 
> Furthermore I include some other cleanups in project and manifest files, e.g. removal of .settings files which are .gitignored because they would be generated when importing the JMC projects into Eclipse.

This pull request has now been integrated.

Changeset: 456da390
Author:    Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/456da3900f3fe2fc35b6f50a1bc9217dc00b4069
Stats:     941 lines in 103 files changed: 206 ins; 373 del; 362 mod

7951: Factor out commonly used test helper classes from org.openjdk.jmc.common.test into dedicated test library module

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/451


More information about the jmc-dev mailing list