RFR: 8046: Detect failing agent builds on Windows

Christoph Langer clanger at openjdk.org
Mon Feb 27 21:46:53 UTC 2023


On Mon, 27 Feb 2023 16:36:16 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> When running build.bat --packageAgent, the build.bat doesn't detect if the maven call fails, since the ERRORLEVEL variable is overridden by the "cd .." call before it is checked. Additionally the format of the if/else construct is wrong (uses curly braces in the else part).

Looks good. You have to change the PR title to match with the JBS item.

-------------

Marked as reviewed by clanger (Committer).

PR: https://git.openjdk.org/jmc/pull/472


More information about the jmc-dev mailing list