RFR: 7879: Automated Analysis taking very long time to produce results for Class Leak Rule and showing wrong results. [v6]

[Suchita Chaturvedi]

On Wed, 18 Jan 2023 21:03:53 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed the synchronized block and used ConcurrentLinkedQueue instead
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/DefaultIItemResultSet.java line 166:
> 
>> 164: 			System.out.println(
>> 165: 					"The results may be inaccurate as JMC is unable to process all the class entries to determine "
>> 166: 							+ "the class leak results. Please increase the configured timeout in preferences to see the accurate results.  ");
> 
> I believe this should be changed to use the jul logger. Other flighrecorder component uses that.
> 
> E.g.
> 
> 
> private final static Logger LOGGER = Logger.getLogger("org.openjdk.jmc.flighrecorder.rules.jdk.util");

Hi @bric3 Thanks for taking out time and reviewing the PR. I have replaced sysout with Logger now.

-------------

PR: https://git.openjdk.org/jmc/pull/419