RFR: 8098: Remove obsolete checkformatting step in GHA
Christoph Langer
clanger at openjdk.org
Wed Jul 5 20:42:05 UTC 2023
On Wed, 5 Jul 2023 20:11:08 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
> I think this should be okay. I was a bit back and forth on the removal of spotless checks for the uitests, but they aren't run in the GH CI and are very infrequently built upon anyways. In the event of new uitests the reviewers would have to run the tests locally anyways, so any spotless checks would be flagged then.
Ah, good point, I wasn't really aware. But anyway, those who run uitests will hit spotless then. And we should probably strive to include the uitests in GHA if possible. Thanks for the review.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/504#issuecomment-1622467217
More information about the jmc-dev
mailing list