RFR: 8102: Automated analysis page does not expand the results for Windows
Virag Purnam
vpurnam at openjdk.org
Tue Jul 18 16:58:04 UTC 2023
On Tue, 18 Jul 2023 16:42:24 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:
> To fix the bug https://bugs.openjdk.org/browse/JMC-8073, **rules_overview.html** had been modified and **.includes()** method was added. But this method does not work with all browsers e.g IE. On windows Automated analysis page does not expand the results.
>
> Fix: I have replaced all **.includes()** with widely supported **.indexOf()**.
> e.g ` e.id.includes("_name") `has been replaced with` e.id.indexOf("_name") !== -1`
>
> With this change it works in all platforms.
Hi @aptmac, could you please review the changes? With this fix rule result html pages expansion and collapsing of individual rule results works for windows as well. .includes() method is not supported by IE.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/507#issuecomment-1640594806
More information about the jmc-dev
mailing list