RFR: 8102: Automated analysis page does not expand the results for Windows

Alex Macdonald aptmac at openjdk.org
Tue Jul 18 17:45:03 UTC 2023


On Tue, 18 Jul 2023 16:42:24 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> To fix the bug https://bugs.openjdk.org/browse/JMC-8073, **rules_overview.html** had been modified and **.includes()** method was added. But this method does not work with all browsers e.g IE.  On windows Automated analysis page does not expand the results. 
> 
> Fix: I have replaced all **.includes()** with widely supported **.indexOf()**.
> e.g ` e.id.includes("_name") `has been replaced with` e.id.indexOf("_name") !== -1`
> 
> With this change it works in all platforms.

lgtm

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/507#pullrequestreview-1535601284


More information about the jmc-dev mailing list