RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again

Vincent Beelte duke at openjdk.org
Wed Jul 26 18:28:07 UTC 2023


One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.

It looks to my like the issue is that the event groups must have chaged from when the test was written.
Here is what that looks like currently for me on Windows with a jdk 17.0.7
![JDK Mission Control 21 07 2023 20_13_20](https://github.com/openjdk/jmc/assets/917408/faa65318-5dd6-492b-ae2a-b5f4936a1f9d)
The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.

I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.

-------------

Commit messages:
 - Merge remote-tracking branch 'origin/master' into wizard_test
 - Merge remote-tracking branch 'origin/master' into wizard_test
 - improve test setup of JfrWizardTest.verifyMinimalRecordingEventSettings

Changes: https://git.openjdk.org/jmc/pull/509/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=509&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8113
  Stats: 32 lines in 2 files changed: 26 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/509.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/509/head:pull/509

PR: https://git.openjdk.org/jmc/pull/509


More information about the jmc-dev mailing list