RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again

Vincent Beelte duke at openjdk.org
Wed Jul 26 18:28:07 UTC 2023


On Tue, 25 Jul 2023 04:08:04 GMT, Vincent Beelte <duke at openjdk.org> wrote:

> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
> 
> It looks to my like the issue is that the event groups must have chaged from when the test was written.
> Here is what that looks like currently for me on Windows with a jdk 17.0.7
> ![JDK Mission Control 21 07 2023 20_13_20](https://github.com/openjdk/jmc/assets/917408/faa65318-5dd6-492b-ae2a-b5f4936a1f9d)
> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
> 
> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.

The wiki seems to be offline but I assume I can do something like this to add the issue

-------------

PR Comment: https://git.openjdk.org/jmc/pull/509#issuecomment-1652291793


More information about the jmc-dev mailing list