RFR: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again [v2]

Vincent Alexander Beelte duke at openjdk.org
Thu Jul 27 13:18:50 UTC 2023


On Thu, 27 Jul 2023 12:56:29 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

>> application/uitests/org.openjdk.jmc.test.jemmy/src/main/java/org/openjdk/jmc/test/jemmy/misc/wrappers/JfrWizard.java line 465:
>> 
>>> 463: 			final var eventSettingsTree = getEventSettingsTree();
>>> 464: 			final var names = eventSettingsTree.getAllItemTexts();
>>> 465: 			for (var name : names) {
>> 
>> You could simply do `for (var name : getEventSettingsTree().getAllItemTexts()) {` here
>
> Yes I know. There was a version of this where I first also used the eventSettingsTree to select the path. But I removed that because it turned out to not be needed.

other than that I really struggle to find a reason to do it one way or the other, other than someone saying "no really, please do it this way" :)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/509#discussion_r1276267418


More information about the jmc-dev mailing list