RFR: 8112: Flamegraph model creation performance improvements

[Alex Macdonald]

On Thu, 27 Jul 2023 15:34:58 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

> So reporting on the ui tests: I do not seem to have broken more of them. In fact I fixed one setup over in #509 But it looks like they are currently reporting actual bugs even on master. There are three tests that are currently failing regularly for me on Windows with a JDK 17.0.7 (specifically Temurin-17.0.7+7) They are ControlRecordingsTest.modifyEventPeriod, ControlRecordingsTest.modifyEventThreshold and ControlRecordingsTest.modifyRecordingEvents. ControlRecordingsTest.modifyRecordingEvents is the least likely to get a successful run. It basically never succeeds. The others are sucessfull every now and again. I clicked through the "test plan" of ControlRecordingsTest.modifyRecordingEvents manually (as in "no junit, no jemmy, just me") and I can confirm that I could reproduce the failure case. I think the details about that should be discussed elsewhere though, to not detract from the topic of this pull request.

Thanks for taking a run at the uitests, what you've written looks good to me. I can confirm I'm seeing errors at:

  ControlRecordingsTest.modifyEventThreshold:324 Event "Compilation" threshold value should be 5 ms but was: 1 s
  ControlRecordingsTest.modifyRecordingEvents:277 Event "Allocation Requiring GC" should be turned on


but these will be covered by a different issue.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/502#issuecomment-1653904359