Integrated: 8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again

Vincent Alexander Beelte duke at openjdk.org
Thu Jul 27 16:01:49 UTC 2023


On Tue, 25 Jul 2023 04:08:04 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

> One test I see failing all the time when I run the ui tests for my other pull requst is JfrWizardTest.verifyMinimalRecordingEventSettings.
> 
> It looks to my like the issue is that the event groups must have chaged from when the test was written.
> Here is what that looks like currently for me on Windows with a jdk 17.0.7
> ![JDK Mission Control 21 07 2023 20_13_20](https://github.com/openjdk/jmc/assets/917408/faa65318-5dd6-492b-ae2a-b5f4936a1f9d)
> The Java Development Kit group is not explicitly disabled by the test and so it always fails when it tries to assert that only the "Flight Recorder">"Recording Setting" Event is enabled.
> 
> I changed the test so that is does not need to explicitly disable other groups by name. I think even if for some reason this test failing is a result of my setup on this computer, this way is more robust to changes in the groups.

This pull request has now been integrated.

Changeset: e0a24803
Author:    Vincent Alexander Beelte <grandmasterpixel at googlemail.com>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/e0a248032c2c29d107687b68a2818daf1901f460
Stats:     34 lines in 2 files changed: 26 ins; 5 del; 3 mod

8113: Make JfrWizardTest.verifyMinimalRecordingEventSettings work again

Reviewed-by: aptmac, clanger

-------------

PR: https://git.openjdk.org/jmc/pull/509


More information about the jmc-dev mailing list