RFR: 8079: Issue in Dev environment due to maven-checkstyle-plugin [v2]

[Virag Purnam]

On Mon, 5 Jun 2023 14:34:59 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8079: Issue in Dev environment due to maven-checkstyle-plugin
>
> Yes, could you please remove the `org.eclipse.jdt.core.prefs` file from this PR? Or do you have a hard reason for adding it back? Other than that, looks good. I'm aware of this issue and currently working on cleaning up some stuff in the pom.xml files, which would have included exactly this setting as well. :)
> 
> Update: I read the PR description once more and I think you wanted to address the --release issue by adding back `org.eclipse.jdt.core.prefs` again. But I found that this does not work. Importing the project in Eclipse or doing "Update Maven project" would reset/rewrite the prefs file. So that's why it is of no use having it in the source tree and it should be removed.

Hi @RealCLanger, Thanks for the comment. Yes, it reset/rewrite the prefs file. I missed this point during testing. I have removed `\application\org.openjdk.jmc.browser.attach.settings\org.eclipse.jdt.core.prefs` file in latest commit.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/490#issuecomment-1577913276