RFR: 7894: Provide an alternative Java based flamegraph visualization [v21]
Brice Dutheil
bdutheil at openjdk.org
Mon Jun 12 22:15:33 UTC 2023
> This change introduces a possible replacement for the current flamegraph view.
>
> **Motivation**
> The current is based on a web view. In the current state,
> - the web view can be slow to render especially when the tree is large.
> - the web view don't feel well integrated, in particular when popups are shown.
> - web view are difficult to work with from a JMC developer perspective.
>
> 
>
> **Description**
> Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class.
>
> As the intent of this view is to eventually replace the current one, the icons are the same.
>
> Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server.
>
>
> cd releng/third-party
>
> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar
>
> # if sources are wanted
> mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources
>
> # make the p2 site, don't forget the -U
> mvn p2:site -U; mvn jetty:run
>
>
> **Outstanding issues / limitation**
> - [x] Fireplace has not yet a stable release as some part of its API are a bit rough.
> - [x] Currently the view does not initializes correctly:
> the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time.
> https://github.com/bric3/fireplace/issues/79
> - [x] Fireplace only supports _icicle_ view at this time.
> https://github.com/bric3/fireplace/issues/22
> - [x] Icons for minimap toggle and zoom reset
> <img width="237" alt="image" src="https://user-images.githubusercontent.com/803621/183126781-07af0e94-a5d5-458c-97e3-a5e012177248.png">
> - [x] Export to image
> https://github.com/bric3/fireplace/issues/99
> - [x] Export to print ?
> Can be done at a later time
> - [x] release of fireplace
Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
chore: PR review
-------------
Changes:
- all: https://git.openjdk.org/jmc/pull/408/files
- new: https://git.openjdk.org/jmc/pull/408/files/f722f3bf..9237cb4f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=20
- incr: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=19-20
Stats: 9 lines in 3 files changed: 1 ins; 5 del; 3 mod
Patch: https://git.openjdk.org/jmc/pull/408.diff
Fetch: git fetch https://git.openjdk.org/jmc.git pull/408/head:pull/408
PR: https://git.openjdk.org/jmc/pull/408
More information about the jmc-dev
mailing list