RFR: 8080: Add support for enabling jfr on native images [v3]
Alex Macdonald
aptmac at openjdk.org
Tue Jun 13 17:04:30 UTC 2023
On Tue, 13 Jun 2023 16:33:26 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
>>
>> run mvn:spotless apply
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java line 94:
>
>> 92: * @param vmName
>> 93: * the JVM name to check.
>> 94: * @return {@code true} of it is a JRockit, {@code false} if it isn't or if it was not possible
>
> Haha, as you touch it, you should also fix this typo: "of it is" -> "if it is" 😄
Boo, I should have taken a bit of a deeper read there .. thanks for checking again!
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/491#discussion_r1228439560
More information about the jmc-dev
mailing list