RFR: 8086: Some refactoring for jmc/core [v5]

Christoph Langer clanger at openjdk.org
Wed Jun 14 07:38:43 UTC 2023


> I worked on some improvements/refactoring for jmc/core. In detail:
> 
> Better handling of Spotless and Checkstyle:
>     - Fix calling spotless/checkstyle directly in submodules by refering to a jmc.config.path
>     - Integrate spotless into the regular build workflow
> 
> Cleanup of core/pom.xml:
>     - Better order of elements
>     - URL cleanups
>     - Plugin version bumps
>     - Use plugins section instead of pluginManagement because settings apply to the jmc project only and no other project would inherit
> 
> Lighter test projects:
>     - They don't need to be p2 plugin projects since they only test basic functionality but not in the context of Eclipse/OSGI modules
>     - Disable some maven plugin executions that are not needed there

Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

  Don't touch checkformatting scripts in this change

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/495/files
  - new: https://git.openjdk.org/jmc/pull/495/files/20366496..c4d896be

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=495&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=495&range=03-04

  Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/495.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/495/head:pull/495

PR: https://git.openjdk.org/jmc/pull/495


More information about the jmc-dev mailing list